Implement new API for sign_and_submit_then_watch (#354)

* WIP Implementing new event subscription API

* back to lifetimes, fix example

* no more need for accept_weak_inclusion

* thread lifetime through to prevent 'temporary dropped' issue

* make working with events a little nicer

* Get tests compiling

* fmt and clippy

* _name back to name

* dont take ownership, just have stronger note

* Attempt to fix test

* remove commented-out code

* Add a couple more helper methods and a test

* Remove custom ExtrinsicFailed handling; treat them like other events

* Handle runtime errors in TransactionProgress related bits

* cargo fmt + clippy

* Fix some of the failing tests

* remove unused import

* fix transfer_error test

* Fix compile errors against new substrate latest

* Comment tweaks, and force test-runtime rebuild

* Drop the TransactionProgress subscription when we hit 'end' statuses

* cargo fmt

* find_event to find_first_event and helper to return all matching events

* TransactionProgressStatus to TransactionStatus

* Copy and improve docs on TransactionStatus from substrate

* debug impl for Client to avoid manual debug impls elsewhere

* Add and tweak comments, specifically a note about block inclusion on errors

* clippy + fmt

* Fix docs

* Ignore 'error' statuses and adhere to the substrate docs

* tweak and improve some comments per @dvdplm's suggestions

* Break transaction* structs into separate file

* fmt and fix doc link

tests/integration/frame/sudo.rs

@@ -22,7 +22,6 @@ use crate::{
     },
     test_context,
 };
-use assert_matches::assert_matches;
 use sp_keyring::AccountKeyring;
 use subxt::extrinsic::PairSigner;
 
@@ -30,7 +29,7 @@ type Call = runtime_types::node_runtime::Call;
 type BalancesCall = runtime_types::pallet_balances::pallet::Call;
 
 #[async_std::test]
-async fn test_sudo() {
+async fn test_sudo() -> Result<(), subxt::Error> {
     let alice = PairSigner::<DefaultConfig, _>::new(AccountKeyring::Alice.pair());
     let bob = AccountKeyring::Bob.to_account_id().into();
     let cxt = test_context().await;
@@ -40,20 +39,23 @@ async fn test_sudo() {
         value: 10_000,
     });
 
-    let res = cxt
+    let found_event = cxt
         .api
         .tx()
         .sudo()
         .sudo(call)
         .sign_and_submit_then_watch(&alice)
-        .await
-        .unwrap();
-    let sudid = res.find_event::<sudo::events::Sudid>();
-    assert_matches!(sudid, Ok(Some(_)))
+        .await?
+        .wait_for_finalized_success()
+        .await?
+        .has_event::<sudo::events::Sudid>()?;
+
+    assert!(found_event);
+    Ok(())
 }
 
 #[async_std::test]
-async fn test_sudo_unchecked_weight() {
+async fn test_sudo_unchecked_weight() -> Result<(), subxt::Error> {
     let alice = PairSigner::<DefaultConfig, _>::new(AccountKeyring::Alice.pair());
     let bob = AccountKeyring::Bob.to_account_id().into();
     let cxt = test_context().await;
@@ -63,15 +65,17 @@ async fn test_sudo_unchecked_weight() {
         value: 10_000,
     });
 
-    let res = cxt
+    let found_event = cxt
         .api
         .tx()
         .sudo()
         .sudo_unchecked_weight(call, 0)
         .sign_and_submit_then_watch(&alice)
-        .await
-        .unwrap();
+        .await?
+        .wait_for_finalized_success()
+        .await?
+        .has_event::<sudo::events::Sudid>()?;
 
-    let sudid = res.find_event::<sudo::events::Sudid>();
-    assert_matches!(sudid, Ok(Some(_)))
+    assert!(found_event);
+    Ok(())
 }