Remove default expansion from construct_runtime! (#4937)

This removes the following syntactic sugar from `construct_runtime!`:

- Expansion of `default` to the default set of module parts
- Expansion of `System: system` to the default set of module parts

The macro now requires the user to provide all the module parts of a pallet.

substrate/frame/support/test/tests/construct_runtime_ui/default_module_invalid_arg.rs

@@ -1,14 +0,0 @@
-use frame_support::construct_runtime;
-
-construct_runtime! {
-	pub enum Runtime where
-		Block = Block,
-		NodeBlock = Block,
-		UncheckedExtrinsic = UncheckedExtrinsic
-	{
-		System: system,
-		Balance: balances::{default, Error},
-	}
-}
-
-fn main() {}

substrate/frame/support/test/tests/construct_runtime_ui/default_module_invalid_arg.stderr

@@ -1,5 +0,0 @@
-error: Only the following modules are allowed: `Module`, `Call`, `Storage`, `Event`, `Config`, `Origin`, `Inherent`, `ValidateUnsigned`
-  --> $DIR/default_module_invalid_arg.rs:10:32
-   |
-10 |         Balance: balances::{default, Error},
-   |                                      ^^^^^

substrate/frame/support/test/tests/construct_runtime_ui/double_module_parts.rs

@@ -6,7 +6,7 @@ construct_runtime! {
 		NodeBlock = Block,
 		UncheckedExtrinsic = UncheckedExtrinsic
 	{
-		System: system,
+		System: system::{Module},
 		Balance: balances::{Config, Call, Config<T>, Origin<T>},
 	}
 }

substrate/frame/support/test/tests/construct_runtime_ui/double_module_parts_default.rs

@@ -1,14 +0,0 @@
-use frame_support::construct_runtime;
-
-construct_runtime! {
-	pub enum Runtime where
-		Block = Block,
-		NodeBlock = Block,
-		UncheckedExtrinsic = UncheckedExtrinsic
-	{
-		System: system,
-		Balance: balances::{default, Config},
-	}
-}
-
-fn main() {}

substrate/frame/support/test/tests/construct_runtime_ui/double_module_parts_default.stderr

@@ -1,5 +0,0 @@
-error: `Config` is already included in `default`. Either remove `default` or remove `Config`
-  --> $DIR/double_module_parts_default.rs:10:32
-   |
-10 |         Balance: balances::{default, Config},
-   |                                      ^^^^^^

substrate/frame/support/test/tests/construct_runtime_ui/generics_in_invalid_module.rs

@@ -6,7 +6,7 @@ construct_runtime! {
 		NodeBlock = Block,
 		UncheckedExtrinsic = UncheckedExtrinsic
 	{
-		System: system,
+		System: system::{Module},
 		Balance: balances::<Instance1>::{Call<T>, Origin<T>},
 	}
 }

substrate/frame/support/test/tests/construct_runtime_ui/invalid_module_details_keyword.stderr

@@ -1,4 +1,4 @@
-error: expected `default` or identifier
+error: expected one of: `Module`, `Call`, `Storage`, `Event`, `Config`, `Origin`, `Inherent`, `ValidateUnsigned`
  --> $DIR/invalid_module_details_keyword.rs:9:20
   |
 9 |         system: System::{enum},

substrate/frame/support/test/tests/construct_runtime_ui/invalid_module_entry.rs

@@ -6,7 +6,7 @@ construct_runtime! {
 		NodeBlock = Block,
 		UncheckedExtrinsic = UncheckedExtrinsic
 	{
-		System: system,
+		System: system::{Module},
 		Balance: balances::{Error},
 	}
 }

substrate/frame/support/test/tests/construct_runtime_ui/invalid_module_entry.stderr

@@ -1,4 +1,4 @@
-error: Only the following modules are allowed: `Module`, `Call`, `Storage`, `Event`, `Config`, `Origin`, `Inherent`, `ValidateUnsigned`
+error: expected one of: `Module`, `Call`, `Storage`, `Event`, `Config`, `Origin`, `Inherent`, `ValidateUnsigned`
   --> $DIR/invalid_module_entry.rs:10:23
    |
 10 |         Balance: balances::{Error},

substrate/frame/support/test/tests/construct_runtime_ui/invalid_token_after_module.stderr

@@ -1,4 +1,4 @@
-error: expected `,`
+error: expected `::`
  --> $DIR/invalid_token_after_module.rs:9:18
   |
 9 |         system: System ?

substrate/frame/support/test/tests/construct_runtime_ui/missing_event_generic_on_module_with_instance.rs

@@ -6,7 +6,7 @@ construct_runtime! {
 		NodeBlock = Block,
 		UncheckedExtrinsic = UncheckedExtrinsic
 	{
-		System: system,
+		System: system::{Module},
 		Balance: balances::<Instance1>::{Event},
 	}
 }

substrate/frame/support/test/tests/construct_runtime_ui/missing_origin_generic_on_module_with_instance.rs

@@ -6,7 +6,7 @@ construct_runtime! {
 		NodeBlock = Block,
 		UncheckedExtrinsic = UncheckedExtrinsic
 	{
-		System: system,
+		System: system::{Module},
 		Balance: balances::<Instance1>::{Origin},
 	}
 }

substrate/frame/support/test/tests/construct_runtime_ui/params_in_invalid_module.rs

@@ -6,7 +6,7 @@ construct_runtime! {
 		NodeBlock = Block,
 		UncheckedExtrinsic = UncheckedExtrinsic
 	{
-		System: system,
+		System: system::{Module},
 		Balance: balances::<Instance1>::{Call(toto), Origin<I>},
 	}
 }