pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-11 23:31:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid unintentionally canceling the scheduled crate publishing job (#13088)

Browse Source 
* avoid unintentionally canceling the scheduled crate publishing job

because publish-crates and publish-crates-manual share the resource group
"crates-publishing", any instance of publish-crates-manual cancels a running
instance of publish-crates, as demonstrated by
https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2212179

a workaround for that unintended interaction is to avoid creating instances of
publish-crates-manual and instead require pipelines to be triggered manually by
checking $CI_JOB_MANUAL == "true"

* check manual pipelines by $CI_PIPELINE_SOURCE instead of $CI_JOB_MANUAL

* make crate-publishing pipelines uninterruptible

* use conditional includes to work around interruptible limitations

* organize comments

* remove interruptible from common pipeline

* wip: check include

* wip: check include

* fix include

* fix include

* fix include

* fix yaml

* fix yaml

* remove shared common-pipeline

* wip: retry common-pipeline

* move .default-template to .gitlab-ci.yml

* fix the pipeline

add comments

* fix default-pipeline.yml

* revert publish-crates-manual to when: manual

* move "needs:" back to publish-crates

* avoid manual repetition

* improve previous commit

* try to avoid manual repetition

* fix indentation

* minor adjustments

* move defaults to top of .gitlab-ci.yml

* fix positioning on default in the diff

* comments

* indentation

* Apply suggestions from code review

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
This commit is contained in:
JP
2023-01-10 09:01:44 -03:00
committed by GitHub
parent dcbccbd641
commit 72f086b795
4 changed files with 43 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/scripts/ci/gitlab/crate-publishing-pipeline.yml
+1
View File
@@ -0,0 +1 @@
default: !reference [.crate-publishing-pipeline-definitions, default]
substrate/scripts/ci/gitlab/default-pipeline.yml
+1
View File
@@ -0,0 +1 @@
default: !reference [.default-pipeline-definitions, default]
substrate/scripts/ci/gitlab/pipeline/publish.yml
+2 -1
View File
@@ -214,7 +214,7 @@ update-node-template:
timeout: 9h
# A custom publishing environment is used for us to be able to set up protected secrets
# specifically for it
environment: publish-crates
environment: publish-crates
script:
- rusty-cachier snapshot create
- git clone
@@ -234,5 +234,6 @@ publish-crates:
publish-crates-manual:
extends: .publish-crates-template
rules: !reference [.crate-publishing-pipeline, rules]
when: manual
allow_failure: true