mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-26 21:37:56 +00:00
TelemetryEndpoints must be valid MutliAddr URL (#5069)
* Check for url validity when creating TelemetryEndpoints * Update code that used TelemetryEndpoints::new() * Update commennts that referred to TelemetryEndpoints::new() * Add tests for telemetry * Fix typo and fix code in docs * Return error on failing to override telemetry * Use expect instead of suppressing errors on must-be-valid telemetry endpoints * Update telemetry unit tests to use expect instead of unwrap * Implement custom deserializer for TelemetryEndpoints * Fix typo * Apply suggestions from code review Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
This commit is contained in:
@@ -419,7 +419,7 @@ impl RunCmd {
|
||||
config.telemetry_endpoints = None;
|
||||
} else if !self.telemetry_endpoints.is_empty() {
|
||||
config.telemetry_endpoints = Some(
|
||||
TelemetryEndpoints::new(self.telemetry_endpoints.clone())
|
||||
TelemetryEndpoints::new(self.telemetry_endpoints.clone()).map_err(|e| e.to_string())?
|
||||
);
|
||||
}
|
||||
|
||||
@@ -689,7 +689,8 @@ mod tests {
|
||||
"test-id",
|
||||
|| (),
|
||||
vec!["boo".to_string()],
|
||||
Some(TelemetryEndpoints::new(vec![("foo".to_string(), 42)])),
|
||||
Some(TelemetryEndpoints::new(vec![("wss://foo/bar".to_string(), 42)])
|
||||
.expect("provided url should be valid")),
|
||||
None,
|
||||
None,
|
||||
None::<()>,
|
||||
|
||||
Reference in New Issue
Block a user