BlockId removal: refactor: Finalizer (#12528)

* BlockId removal: refactor: Finalizer

It changes the arguments of methods of `Finalizer` trait from:
block: `BlockId<Block>` to: hash: `&Block::Hash`

This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)

* minor corrections

* failing test corrected

* minor rework
This commit is contained in:
Michal Kucharczyk
2022-10-20 08:44:04 +02:00
committed by GitHub
parent 7aadc2aa3c
commit 749bcd1949
16 changed files with 113 additions and 118 deletions
+3 -3
View File
@@ -190,11 +190,11 @@ impl PeersClient {
pub fn finalize_block(
&self,
id: BlockId<Block>,
hash: &<Block as BlockT>::Hash,
justification: Option<Justification>,
notify: bool,
) -> ClientResult<()> {
self.client.finalize_block(id, justification, notify)
self.client.finalize_block(hash, justification, notify)
}
}
@@ -1113,7 +1113,7 @@ impl JustificationImport<Block> for ForceFinalized {
justification: Justification,
) -> Result<(), Self::Error> {
self.0
.finalize_block(BlockId::Hash(hash), Some(justification), true)
.finalize_block(&hash, Some(justification), true)
.map_err(|_| ConsensusError::InvalidJustification)
}
}