Add child-bounties pallet. (#10309)

* Extract child-bounties as a separate pallet.

* Initial tests added.

* More tests.

* Tests complete. Fixed curator fee issue.

* Fixed comments.

* Added benchmarks for child-bounties pallet.

* Added weights.

* Fixed formatting.

* Fixed comments.

* Re-run benchmarks for bounties pallet.

* Make cargo fmt happy again

* add max encoded len

* use event structs

* fmt

* fix compile

* Addressed review comments.

* Use config type instead of const in benchmarking.

* Addressed more review comments.

* Use ensure_can_withdraw instead of just checking min balance.

* fmt.

* Introduce ChildBountyCuratorDepositBase to avoid zero curator deposits for child bounties.

* Fix unassign curator logic for child-bounties.

* Added more tests for unassign curator.

* Reduce bounty description max length in node runtime.

* Updated weights for child bounties pallet.

* reduce indentation of unassign_curator

* more indentation reduction

* deduplicate slashing arms

* reintroduce ensure check

* add assertion to check that bad unassign origin fails

* formatting

* Updated comments.

Co-authored-by: Ricardo Rius <ricardo@parity.io>
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
This commit is contained in:
Gautam Dhameja
2021-12-07 23:40:47 +01:00
committed by GitHub
parent fe6189d370
commit 752e050cf4
13 changed files with 2896 additions and 78 deletions
+83 -75
View File
@@ -18,24 +18,24 @@
//! Autogenerated weights for pallet_bounties
//!
//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
//! DATE: 2021-08-07, STEPS: `50`, REPEAT: 20, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! DATE: 2021-11-19, STEPS: `50`, REPEAT: 20, LOW RANGE: `[]`, HIGH RANGE: `[]`
//! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("dev"), DB CACHE: 128
// Executed Command:
// target/release/substrate
// ./target/release/substrate
// benchmark
// --chain=dev
// --steps=50
// --repeat=20
// --pallet=pallet_bounties
// --pallet
// pallet_bounties
// --extrinsic=*
// --execution=wasm
// --wasm-execution=compiled
// --heap-pages=4096
// --output=./frame/bounties/src/weights.rs
// --output=./frame/bounties/src/
// --template=./.maintain/frame-weight-template.hbs
#![cfg_attr(rustfmt, rustfmt_skip)]
#![allow(unused_parens)]
#![allow(unused_imports)]
@@ -61,87 +61,91 @@ pub trait WeightInfo {
/// Weights for pallet_bounties using the Substrate node and recommended hardware.
pub struct SubstrateWeight<T>(PhantomData<T>);
impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// Storage: Treasury BountyCount (r:1 w:1)
// Storage: Bounties BountyCount (r:1 w:1)
// Storage: System Account (r:1 w:1)
// Storage: Treasury BountyDescriptions (r:0 w:1)
// Storage: Treasury Bounties (r:0 w:1)
// Storage: Bounties BountyDescriptions (r:0 w:1)
// Storage: Bounties Bounties (r:0 w:1)
fn propose_bounty(d: u32, ) -> Weight {
(44_482_000 as Weight)
(58_161_000 as Weight)
// Standard Error: 0
.saturating_add((1_000 as Weight).saturating_mul(d as Weight))
.saturating_add(T::DbWeight::get().reads(2 as Weight))
.saturating_add(T::DbWeight::get().writes(4 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Treasury BountyApprovals (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: Bounties BountyApprovals (r:1 w:1)
fn approve_bounty() -> Weight {
(11_955_000 as Weight)
(20_000_000 as Weight)
.saturating_add(T::DbWeight::get().reads(2 as Weight))
.saturating_add(T::DbWeight::get().writes(2 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
fn propose_curator() -> Weight {
(9_771_000 as Weight)
(14_000_000 as Weight)
.saturating_add(T::DbWeight::get().reads(1 as Weight))
.saturating_add(T::DbWeight::get().writes(1 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: System Account (r:1 w:1)
fn unassign_curator() -> Weight {
(40_683_000 as Weight)
(62_000_000 as Weight)
.saturating_add(T::DbWeight::get().reads(2 as Weight))
.saturating_add(T::DbWeight::get().writes(2 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: System Account (r:1 w:1)
fn accept_curator() -> Weight {
(36_390_000 as Weight)
(55_000_000 as Weight)
.saturating_add(T::DbWeight::get().reads(2 as Weight))
.saturating_add(T::DbWeight::get().writes(2 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: ChildBounties ParentChildBounties (r:1 w:0)
fn award_bounty() -> Weight {
(25_187_000 as Weight)
.saturating_add(T::DbWeight::get().reads(1 as Weight))
(46_000_000 as Weight)
.saturating_add(T::DbWeight::get().reads(2 as Weight))
.saturating_add(T::DbWeight::get().writes(1 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: System Account (r:3 w:3)
// Storage: Treasury BountyDescriptions (r:0 w:1)
// Storage: ChildBounties ChildrenCuratorFees (r:1 w:1)
// Storage: Bounties BountyDescriptions (r:0 w:1)
fn claim_bounty() -> Weight {
(124_785_000 as Weight)
.saturating_add(T::DbWeight::get().reads(4 as Weight))
.saturating_add(T::DbWeight::get().writes(5 as Weight))
(185_000_000 as Weight)
.saturating_add(T::DbWeight::get().reads(5 as Weight))
.saturating_add(T::DbWeight::get().writes(6 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: ChildBounties ParentChildBounties (r:1 w:0)
// Storage: System Account (r:1 w:1)
// Storage: Treasury BountyDescriptions (r:0 w:1)
// Storage: Bounties BountyDescriptions (r:0 w:1)
fn close_bounty_proposed() -> Weight {
(39_483_000 as Weight)
.saturating_add(T::DbWeight::get().reads(2 as Weight))
(82_000_000 as Weight)
.saturating_add(T::DbWeight::get().reads(3 as Weight))
.saturating_add(T::DbWeight::get().writes(3 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: ChildBounties ParentChildBounties (r:1 w:0)
// Storage: System Account (r:2 w:2)
// Storage: Treasury BountyDescriptions (r:0 w:1)
// Storage: Bounties BountyDescriptions (r:0 w:1)
fn close_bounty_active() -> Weight {
(83_453_000 as Weight)
.saturating_add(T::DbWeight::get().reads(3 as Weight))
(137_000_000 as Weight)
.saturating_add(T::DbWeight::get().reads(4 as Weight))
.saturating_add(T::DbWeight::get().writes(4 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
fn extend_bounty_expiry() -> Weight {
(24_151_000 as Weight)
(33_000_000 as Weight)
.saturating_add(T::DbWeight::get().reads(1 as Weight))
.saturating_add(T::DbWeight::get().writes(1 as Weight))
}
// Storage: Treasury BountyApprovals (r:1 w:1)
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties BountyApprovals (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: System Account (r:2 w:2)
fn spend_funds(b: u32, ) -> Weight {
(0 as Weight)
// Standard Error: 16_000
.saturating_add((58_004_000 as Weight).saturating_mul(b as Weight))
// Standard Error: 191_000
.saturating_add((81_116_000 as Weight).saturating_mul(b as Weight))
.saturating_add(T::DbWeight::get().reads(1 as Weight))
.saturating_add(T::DbWeight::get().reads((3 as Weight).saturating_mul(b as Weight)))
.saturating_add(T::DbWeight::get().writes(1 as Weight))
@@ -151,87 +155,91 @@ impl<T: frame_system::Config> WeightInfo for SubstrateWeight<T> {
// For backwards compatibility and tests
impl WeightInfo for () {
// Storage: Treasury BountyCount (r:1 w:1)
// Storage: Bounties BountyCount (r:1 w:1)
// Storage: System Account (r:1 w:1)
// Storage: Treasury BountyDescriptions (r:0 w:1)
// Storage: Treasury Bounties (r:0 w:1)
// Storage: Bounties BountyDescriptions (r:0 w:1)
// Storage: Bounties Bounties (r:0 w:1)
fn propose_bounty(d: u32, ) -> Weight {
(44_482_000 as Weight)
(58_161_000 as Weight)
// Standard Error: 0
.saturating_add((1_000 as Weight).saturating_mul(d as Weight))
.saturating_add(RocksDbWeight::get().reads(2 as Weight))
.saturating_add(RocksDbWeight::get().writes(4 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Treasury BountyApprovals (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: Bounties BountyApprovals (r:1 w:1)
fn approve_bounty() -> Weight {
(11_955_000 as Weight)
(20_000_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(2 as Weight))
.saturating_add(RocksDbWeight::get().writes(2 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
fn propose_curator() -> Weight {
(9_771_000 as Weight)
(14_000_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(1 as Weight))
.saturating_add(RocksDbWeight::get().writes(1 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: System Account (r:1 w:1)
fn unassign_curator() -> Weight {
(40_683_000 as Weight)
(62_000_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(2 as Weight))
.saturating_add(RocksDbWeight::get().writes(2 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: System Account (r:1 w:1)
fn accept_curator() -> Weight {
(36_390_000 as Weight)
(55_000_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(2 as Weight))
.saturating_add(RocksDbWeight::get().writes(2 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: ChildBounties ParentChildBounties (r:1 w:0)
fn award_bounty() -> Weight {
(25_187_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(1 as Weight))
(46_000_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(2 as Weight))
.saturating_add(RocksDbWeight::get().writes(1 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: System Account (r:3 w:3)
// Storage: Treasury BountyDescriptions (r:0 w:1)
// Storage: ChildBounties ChildrenCuratorFees (r:1 w:1)
// Storage: Bounties BountyDescriptions (r:0 w:1)
fn claim_bounty() -> Weight {
(124_785_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(4 as Weight))
.saturating_add(RocksDbWeight::get().writes(5 as Weight))
(185_000_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(5 as Weight))
.saturating_add(RocksDbWeight::get().writes(6 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: ChildBounties ParentChildBounties (r:1 w:0)
// Storage: System Account (r:1 w:1)
// Storage: Treasury BountyDescriptions (r:0 w:1)
// Storage: Bounties BountyDescriptions (r:0 w:1)
fn close_bounty_proposed() -> Weight {
(39_483_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(2 as Weight))
(82_000_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(3 as Weight))
.saturating_add(RocksDbWeight::get().writes(3 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: ChildBounties ParentChildBounties (r:1 w:0)
// Storage: System Account (r:2 w:2)
// Storage: Treasury BountyDescriptions (r:0 w:1)
// Storage: Bounties BountyDescriptions (r:0 w:1)
fn close_bounty_active() -> Weight {
(83_453_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(3 as Weight))
(137_000_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(4 as Weight))
.saturating_add(RocksDbWeight::get().writes(4 as Weight))
}
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
fn extend_bounty_expiry() -> Weight {
(24_151_000 as Weight)
(33_000_000 as Weight)
.saturating_add(RocksDbWeight::get().reads(1 as Weight))
.saturating_add(RocksDbWeight::get().writes(1 as Weight))
}
// Storage: Treasury BountyApprovals (r:1 w:1)
// Storage: Treasury Bounties (r:1 w:1)
// Storage: Bounties BountyApprovals (r:1 w:1)
// Storage: Bounties Bounties (r:1 w:1)
// Storage: System Account (r:2 w:2)
fn spend_funds(b: u32, ) -> Weight {
(0 as Weight)
// Standard Error: 16_000
.saturating_add((58_004_000 as Weight).saturating_mul(b as Weight))
// Standard Error: 191_000
.saturating_add((81_116_000 as Weight).saturating_mul(b as Weight))
.saturating_add(RocksDbWeight::get().reads(1 as Weight))
.saturating_add(RocksDbWeight::get().reads((3 as Weight).saturating_mul(b as Weight)))
.saturating_add(RocksDbWeight::get().writes(1 as Weight))