Contract storage limit (#3126)

* srml-contracts: Remove hard-coded code hashes from tests.

This makes it easier to update existing and add new test Wasm modules.

* Test maximum contract storage write size.

* Implement storage value limit for contracts.

* Bump node runtime spec version.

substrate/srml/contracts/src/wasm/mod.rs

@@ -215,8 +215,11 @@ mod tests {
 		fn get_storage(&self, key: &StorageKey) -> Option<Vec<u8>> {
 			self.storage.get(key).cloned()
 		}
-		fn set_storage(&mut self, key: StorageKey, value: Option<Vec<u8>>) {
+		fn set_storage(&mut self, key: StorageKey, value: Option<Vec<u8>>)
+			-> Result<(), &'static str>
+		{
 			*self.storage.entry(key).or_insert(Vec::new()) = value.unwrap_or(Vec::new());
+			Ok(())
 		}
 		fn instantiate(
 			&mut self,
@@ -293,6 +296,8 @@ mod tests {
 		}
 
 		fn block_number(&self) -> u64 { 121 }
+
+		fn max_value_size(&self) -> u32 { 16_384 }
 	}
 
 	fn execute<E: Ext>(

substrate/srml/contracts/src/wasm/runtime.rs

@@ -254,6 +254,7 @@ define_env!(Env, <E: Ext>,
 	},
 
 	// Change the value at the given key in the storage or remove the entry.
+	// The value length must not exceed the maximum defined by the Contracts module parameters.
 	//
 	// - key_ptr: pointer into the linear
 	//   memory where the location of the requested value is placed.
@@ -263,6 +264,9 @@ define_env!(Env, <E: Ext>,
 	//   where the value to set is placed. If `value_non_null` is set to 0, then this parameter is ignored.
 	// - value_len: the length of the value. If `value_non_null` is set to 0, then this parameter is ignored.
 	ext_set_storage(ctx, key_ptr: u32, value_non_null: u32, value_ptr: u32, value_len: u32) => {
+		if value_non_null != 0 && ctx.ext.max_value_size() < value_len {
+			return Err(sandbox::HostError);
+		}
 		let mut key: StorageKey = [0; 32];
 		read_sandbox_memory_into_buf(ctx, key_ptr, &mut key)?;
 		let value =
@@ -271,7 +275,7 @@ define_env!(Env, <E: Ext>,
 			} else {
 				None
 			};
-		ctx.ext.set_storage(key, value);
+		ctx.ext.set_storage(key, value).map_err(|_| sandbox::HostError)?;
 
 		Ok(())
 	},