Fix Substrate features (#14660)

* Fix std, runtime-benchmarks and try-runtime features

zepter lint propagate-feature --feature try-runtime --left-side-feature-missing=ignore --workspace --fix --feature-enables-dep="try-runtime:frame-try-runtime"
zepter lint propagate-feature --feature runtime-benchmarks --left-side-feature-missing=ignore --workspace --fix --feature-enables-dep="runtime-benchmarks:frame-benchmarking"
zepter lint propagate-feature --feature std --left-side-feature-missing=ignore --workspace --fix

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add propagate feature CI check

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Test CI by adding an error

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Use --locked

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add help msg

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Revert "Test CI by adding an error"

This reverts commit cf4ff6cc0632269b0a109e547686e5e3314b02de.

* Test CI by adding an error

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* No newline in help msg

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Revert "Test CI by adding an error"

This reverts commit 5daa06ada8e01f5bebafb9d1c76804dd79bc1006.

* Test CI by adding an error

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Revert "Test CI by adding an error"

This reverts commit ca15de5729507a564f140a10ec2e87b19516ec4c.

* Fix msg

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Revert back to master

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Re-do with Zepter v0.7.4

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update Zepter to 0.7.4

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Disable rococo try-runtime check

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <git@kchr.de>

* More review fixes

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Bastian Köcher <git@kchr.de>

substrate/primitives/api/Cargo.toml

@@ -47,6 +47,9 @@ std = [
 	"log/std",
 	"scale-info/std",
 	"sp-metadata-ir?/std",
+	"sp-api-proc-macro/std",
+	"sp-externalities?/std",
+	"sp-test-primitives/std"
 ]
 # Special feature to disable logging completely.
 #

substrate/primitives/arithmetic/Cargo.toml

@@ -39,6 +39,7 @@ std = [
 	"scale-info/std",
 	"serde/std",
 	"sp-std/std",
+	"sp-core/std"
 ]
 # Serde support without relying on std features.
 serde = [

substrate/primitives/consensus/babe/Cargo.toml

@@ -40,7 +40,7 @@ std = [
 	"sp-inherents/std",
 	"sp-runtime/std",
 	"sp-std/std",
-	"sp-timestamp",
+ 	"sp-timestamp/std",
 ]
 
 # Serde support without relying on std features.

substrate/primitives/consensus/beefy/Cargo.toml

@@ -42,6 +42,7 @@ std = [
 	"sp-mmr-primitives/std",
 	"sp-runtime/std",
 	"sp-std/std",
+	"sp-keystore/std"
 ]
 
 # Serde support without relying on std features.

substrate/primitives/consensus/grandpa/Cargo.toml

@@ -37,9 +37,9 @@ std = [
 	"sp-api/std",
 	"sp-application-crypto/std",
 	"sp-core/std",
-	"sp-keystore",
-	"sp-runtime/std",
-	"sp-std/std",
+ 	"sp-keystore/std",
+ 	"sp-runtime/std",
+ 	"sp-std/std"
 ]
 
 # Serde support without relying on std features.

substrate/primitives/core/Cargo.toml

@@ -103,7 +103,6 @@ std = [
 	"secp256k1/global-context",
 	"sp-core-hashing/std",
 	"sp-debug-derive/std",
-	"sp-externalities",
 	"sp-storage/std",
 	"sp-runtime-interface/std",
 	"ss58-registry/std",
@@ -114,6 +113,7 @@ std = [
 	"libsecp256k1/std",
 	"dyn-clonable",
 	"tracing",
+	"sp-externalities/std"
 ]
 
 # Serde support without relying on std features.

substrate/primitives/genesis-builder/Cargo.toml

@@ -24,4 +24,5 @@ std = [
 	"sp-api/std",
 	"sp-std/std",
 	"serde_json/std",
+	"sp-runtime/std"
 ]

substrate/primitives/io/Cargo.toml

@@ -46,7 +46,6 @@ std = [
 	"bytes/std",
 	"sp-externalities/std",
 	"sp-core/std",
-	"sp-keystore",
 	"codec/std",
 	"sp-std/std",
 	"sp-trie/std",
@@ -60,6 +59,7 @@ std = [
 	"log",
 	"ed25519-dalek",
 	"ed25519",
+	"sp-keystore/std"
 ]
 
 with-tracing = [

substrate/primitives/runtime-interface/Cargo.toml

@@ -45,6 +45,10 @@ std = [
 	"codec/std",
 	"sp-externalities/std",
 	"primitive-types/std",
+	"sp-core/std",
+	"sp-io/std",
+	"sp-runtime-interface-test-wasm/std",
+	"sp-state-machine/std"
 ]
 
 # ATTENTION

substrate/primitives/runtime/Cargo.toml

@@ -57,6 +57,9 @@ std = [
 	"sp-io/std",
 	"sp-std/std",
 	"sp-weights/std",
+	"sp-api/std",
+	"sp-state-machine/std",
+	"sp-tracing/std"
 ]
 
 # Serde support without relying on std features.

substrate/primitives/session/Cargo.toml

@@ -32,5 +32,5 @@ std = [
 	"sp-runtime/std",
 	"sp-staking/std",
 	"sp-std/std",
-	"sp-keystore",
+ 	"sp-keystore/std"
 ]

substrate/primitives/staking/Cargo.toml

@@ -32,4 +32,6 @@ std = [
 	"sp-runtime/std",
 	"sp-std/std",
 ]
-runtime-benchmarks = []
+runtime-benchmarks = [
+	"sp-runtime/runtime-benchmarks"
+]

substrate/primitives/state-machine/Cargo.toml

@@ -52,4 +52,5 @@ std = [
 	"trie-db/std",
 	"thiserror",
 	"tracing",
+	"sp-runtime/std"
 ]

substrate/primitives/statement-store/Cargo.toml

@@ -53,6 +53,7 @@ std = [
 	"hkdf",
 	"sha2",
 	"rand",
+	"sp-externalities/std"
 ]
 serde = [
         "scale-info/serde",

substrate/primitives/transaction-storage-proof/Cargo.toml

@@ -28,9 +28,9 @@ std = [
 	"async-trait",
 	"codec/std",
 	"scale-info/std",
-	"sp-core",
 	"sp-inherents/std",
 	"sp-runtime/std",
 	"sp-std/std",
 	"sp-trie/std",
+	"sp-core/std"
 ]

substrate/primitives/trie/Cargo.toml

@@ -61,4 +61,5 @@ std = [
 	"tracing",
 	"trie-db/std",
 	"trie-root/std",
+	"sp-runtime/std"
 ]