[NFTs] Improve offchain signature validation (#13960)

* Improve signature validation

* Rework
This commit is contained in:
Jegor Sidorenko
2023-04-20 15:38:45 +03:00
committed by GitHub
parent 9544ec765d
commit 7a1fc72a4a
3 changed files with 56 additions and 6 deletions
+3 -6
View File
@@ -50,7 +50,7 @@ use frame_support::traits::{
};
use frame_system::Config as SystemConfig;
use sp_runtime::{
traits::{Saturating, StaticLookup, Zero},
traits::{IdentifyAccount, Saturating, StaticLookup, Verify, Zero},
RuntimeDebug,
};
use sp_std::prelude::*;
@@ -69,7 +69,6 @@ pub mod pallet {
use super::*;
use frame_support::{pallet_prelude::*, traits::ExistenceRequirement};
use frame_system::pallet_prelude::*;
use sp_runtime::traits::{IdentifyAccount, Verify};
/// The current storage version.
const STORAGE_VERSION: StorageVersion = StorageVersion::new(1);
@@ -1841,8 +1840,7 @@ pub mod pallet {
signer: T::AccountId,
) -> DispatchResult {
let origin = ensure_signed(origin)?;
let msg = Encode::encode(&mint_data);
ensure!(signature.verify(&*msg, &signer), Error::<T, I>::WrongSignature);
Self::validate_signature(&Encode::encode(&mint_data), &signature, &signer)?;
Self::do_mint_pre_signed(origin, mint_data, signer)
}
@@ -1868,8 +1866,7 @@ pub mod pallet {
signer: T::AccountId,
) -> DispatchResult {
let origin = ensure_signed(origin)?;
let msg = Encode::encode(&data);
ensure!(signature.verify(&*msg, &signer), Error::<T, I>::WrongSignature);
Self::validate_signature(&Encode::encode(&data), &signature, &signer)?;
Self::do_set_attributes_pre_signed(origin, data, signer)
}
}