From 7a602c47abf704679a3efebc3cbfd51dab67adca Mon Sep 17 00:00:00 2001 From: Robert Klotzner Date: Tue, 10 May 2022 14:48:18 +0200 Subject: [PATCH] Double grandpa gossip duration for Kusama and test networks (#5448) * Double grandpa gossip duration. * Make resend period slightly larger. So it won't get triggered by additional grandpa delay. * Bump other values as well. * Don't change gossip duration on Polkadot. (and Westend as it is meant to be a testbed for Polkadot) --- .../node/network/approval-distribution/src/lib.rs | 6 +++--- polkadot/node/service/src/lib.rs | 15 ++++++++++++++- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/polkadot/node/network/approval-distribution/src/lib.rs b/polkadot/node/network/approval-distribution/src/lib.rs index fe73271c5c..c2bbd1b458 100644 --- a/polkadot/node/network/approval-distribution/src/lib.rs +++ b/polkadot/node/network/approval-distribution/src/lib.rs @@ -138,9 +138,9 @@ impl AggressionConfig { impl Default for AggressionConfig { fn default() -> Self { AggressionConfig { - l1_threshold: Some(10), - l2_threshold: Some(25), - resend_unfinalized_period: Some(5), + l1_threshold: Some(13), + l2_threshold: Some(28), + resend_unfinalized_period: Some(8), } } } diff --git a/polkadot/node/service/src/lib.rs b/polkadot/node/service/src/lib.rs index 312d8f760d..ddedcbe6aa 100644 --- a/polkadot/node/service/src/lib.rs +++ b/polkadot/node/service/src/lib.rs @@ -1180,9 +1180,22 @@ where } } + // Reduce grandpa load on Kusama and test networks. This will slow down finality by + // approximately one slot duration, but will reduce load. We would like to see the impact on + // Kusama, see: https://github.com/paritytech/polkadot/issues/5464 + let gossip_duration = if chain_spec.is_versi() || + chain_spec.is_wococo() || + chain_spec.is_rococo() || + chain_spec.is_kusama() + { + Duration::from_millis(2000) + } else { + Duration::from_millis(1000) + }; + let config = grandpa::Config { // FIXME substrate#1578 make this available through chainspec - gossip_duration: Duration::from_millis(1000), + gossip_duration, justification_period: 512, name: Some(name), observer_enabled: false,