From 7c49545315b2b049bc6df5c0d615d777efee8a4a Mon Sep 17 00:00:00 2001 From: Sergei Shulepov Date: Sat, 27 Nov 2021 10:14:00 +0100 Subject: [PATCH] Fix typo: ambigious -> ambiguous (#4380) * Do not log PVF prunning every hour This lowers the level of the PVF pruning. Closes https://github.com/paritytech/polkadot/issues/4361 * Fix typo: ambigious -> ambiguous The correct spelling is ambiguous ([dictionary](https://dictionary.cambridge.org/dictionary/english/ambiguous)) --- polkadot/node/core/candidate-validation/src/lib.rs | 4 ++-- polkadot/node/core/candidate-validation/src/tests.rs | 2 +- polkadot/node/core/pvf/src/error.rs | 2 +- polkadot/node/core/pvf/src/execute/queue.rs | 2 +- polkadot/node/core/pvf/src/host.rs | 12 ++++++------ 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/polkadot/node/core/candidate-validation/src/lib.rs b/polkadot/node/core/candidate-validation/src/lib.rs index c9e78db77c..0b71c77df6 100644 --- a/polkadot/node/core/candidate-validation/src/lib.rs +++ b/polkadot/node/core/candidate-validation/src/lib.rs @@ -455,9 +455,9 @@ async fn validate_candidate_exhaustive( Ok(ValidationResult::Invalid(InvalidCandidate::Timeout)), Err(ValidationError::InvalidCandidate(WasmInvalidCandidate::WorkerReportedError(e))) => Ok(ValidationResult::Invalid(InvalidCandidate::ExecutionError(e))), - Err(ValidationError::InvalidCandidate(WasmInvalidCandidate::AmbigiousWorkerDeath)) => + Err(ValidationError::InvalidCandidate(WasmInvalidCandidate::AmbiguousWorkerDeath)) => Ok(ValidationResult::Invalid(InvalidCandidate::ExecutionError( - "ambigious worker death".to_string(), + "ambiguous worker death".to_string(), ))), Ok(res) => diff --git a/polkadot/node/core/candidate-validation/src/tests.rs b/polkadot/node/core/candidate-validation/src/tests.rs index 30fa96ccc3..a1e4a9d150 100644 --- a/polkadot/node/core/candidate-validation/src/tests.rs +++ b/polkadot/node/core/candidate-validation/src/tests.rs @@ -422,7 +422,7 @@ fn candidate_validation_bad_return_is_invalid() { let v = executor::block_on(validate_candidate_exhaustive( MockValidatorBackend::with_hardcoded_result(Err(ValidationError::InvalidCandidate( - WasmInvalidCandidate::AmbigiousWorkerDeath, + WasmInvalidCandidate::AmbiguousWorkerDeath, ))), validation_data, validation_code, diff --git a/polkadot/node/core/pvf/src/error.rs b/polkadot/node/core/pvf/src/error.rs index 8834d3c517..977f24b148 100644 --- a/polkadot/node/core/pvf/src/error.rs +++ b/polkadot/node/core/pvf/src/error.rs @@ -71,7 +71,7 @@ pub enum InvalidCandidate { /// thrown at it and hopefully the operator notices it by decreased reward performance of the /// validator. On the other hand, if the worker died because of (b) we would have better chances /// to stop the attack. - AmbigiousWorkerDeath, + AmbiguousWorkerDeath, /// PVF execution (compilation is not included) took more time than was allotted. HardTimeout, } diff --git a/polkadot/node/core/pvf/src/execute/queue.rs b/polkadot/node/core/pvf/src/execute/queue.rs index 9376d7d76f..c8d75fb039 100644 --- a/polkadot/node/core/pvf/src/execute/queue.rs +++ b/polkadot/node/core/pvf/src/execute/queue.rs @@ -240,7 +240,7 @@ fn handle_job_finish( Outcome::HardTimeout => (None, Err(ValidationError::InvalidCandidate(InvalidCandidate::HardTimeout))), Outcome::IoErr => - (None, Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbigiousWorkerDeath))), + (None, Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbiguousWorkerDeath))), }; queue.metrics.execute_finished(); diff --git a/polkadot/node/core/pvf/src/host.rs b/polkadot/node/core/pvf/src/host.rs index 48b23547e6..dccb52781a 100644 --- a/polkadot/node/core/pvf/src/host.rs +++ b/polkadot/node/core/pvf/src/host.rs @@ -1039,27 +1039,27 @@ mod tests { ); result_tx_pvf_1_1 - .send(Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbigiousWorkerDeath))) + .send(Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbiguousWorkerDeath))) .unwrap(); assert_matches!( result_rx_pvf_1_1.now_or_never().unwrap().unwrap(), - Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbigiousWorkerDeath)) + Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbiguousWorkerDeath)) ); result_tx_pvf_1_2 - .send(Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbigiousWorkerDeath))) + .send(Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbiguousWorkerDeath))) .unwrap(); assert_matches!( result_rx_pvf_1_2.now_or_never().unwrap().unwrap(), - Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbigiousWorkerDeath)) + Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbiguousWorkerDeath)) ); result_tx_pvf_2 - .send(Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbigiousWorkerDeath))) + .send(Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbiguousWorkerDeath))) .unwrap(); assert_matches!( result_rx_pvf_2.now_or_never().unwrap().unwrap(), - Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbigiousWorkerDeath)) + Err(ValidationError::InvalidCandidate(InvalidCandidate::AmbiguousWorkerDeath)) ); }