depend-o-pocalipse (#9450)

Remove unneeded dependencies and dev-dependencies.
Made self_destruct test not dependent on wasm bin size.  
Updated code related to deprecated warning on tracing-subscriber `scope()` 
( See https://github.com/tokio-rs/tracing/issues/1429 )

substrate/client/db/Cargo.toml

@@ -20,25 +20,22 @@ kvdb-rocksdb = { version = "0.14.0", optional = true }
 kvdb-memorydb = "0.10.0"
 linked-hash-map = "0.5.4"
 hash-db = "0.15.2"
-parity-util-mem = { version = "0.10.0", default-features = false, features = ["std"] }
-codec = { package = "parity-scale-codec", version = "2.0.0", features = ["derive"] }
-blake2-rfc = "0.2.18"
+codec = { package = "parity-scale-codec", version = "2.0.0", features = [
+    "derive",
+] }
 
 sc-client-api = { version = "4.0.0-dev", path = "../api" }
 sp-arithmetic = { version = "4.0.0-dev", path = "../../primitives/arithmetic" }
 sp-core = { version = "4.0.0-dev", path = "../../primitives/core" }
 sp-runtime = { version = "4.0.0-dev", path = "../../primitives/runtime" }
 sp-state-machine = { version = "0.10.0-dev", path = "../../primitives/state-machine" }
-sc-executor = { version = "0.10.0-dev", path = "../executor" }
 sc-state-db = { version = "0.10.0-dev", path = "../state-db" }
 sp-trie = { version = "4.0.0-dev", path = "../../primitives/trie" }
 sp-blockchain = { version = "4.0.0-dev", path = "../../primitives/blockchain" }
 sp-database = { version = "4.0.0-dev", path = "../../primitives/database" }
 parity-db = { version = "0.3.1", optional = true }
-prometheus-endpoint = { package = "substrate-prometheus-endpoint", version = "0.9.0", path = "../../utils/prometheus" }
 
 [dev-dependencies]
-sp-keyring = { version = "4.0.0-dev", path = "../../primitives/keyring" }
 sp-tracing = { version = "4.0.0-dev", path = "../../primitives/tracing" }
 substrate-test-runtime-client = { version = "2.0.0", path = "../../test-utils/runtime/client" }
 quickcheck = "1.0.3"

substrate/client/db/src/upgrade.rs

@@ -67,15 +67,19 @@ impl From<io::Error> for UpgradeError {
 impl fmt::Display for UpgradeError {
 	fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
 		match self {
-			UpgradeError::UnknownDatabaseVersion =>
-				write!(f, "Database version cannot be read from exisiting db_version file"),
+			UpgradeError::UnknownDatabaseVersion => {
+				write!(f, "Database version cannot be read from exisiting db_version file")
+			},
 			UpgradeError::MissingDatabaseVersionFile => write!(f, "Missing database version file"),
-			UpgradeError::UnsupportedVersion(version) =>
-				write!(f, "Database version no longer supported: {}", version),
-			UpgradeError::FutureDatabaseVersion(version) =>
-				write!(f, "Database version comes from future version of the client: {}", version),
-			UpgradeError::DecodingJustificationBlock =>
-				write!(f, "Decodoning justification block failed"),
+			UpgradeError::UnsupportedVersion(version) => {
+				write!(f, "Database version no longer supported: {}", version)
+			},
+			UpgradeError::FutureDatabaseVersion(version) => {
+				write!(f, "Database version comes from future version of the client: {}", version)
+			},
+			UpgradeError::DecodingJustificationBlock => {
+				write!(f, "Decodoning justification block failed")
+			},
 			UpgradeError::Io(err) => write!(f, "Io error: {}", err),
 		}
 	}

substrate/client/db/src/utils.rs

@@ -249,8 +249,9 @@ impl fmt::Display for OpenDbError {
 		match self {
 			OpenDbError::Internal(e) => write!(f, "{}", e.to_string()),
 			OpenDbError::DoesNotExist => write!(f, "Database does not exist at given location"),
-			OpenDbError::NotEnabled(feat) =>
-				write!(f, "`{}` feature not enabled, database can not be opened", feat),
+			OpenDbError::NotEnabled(feat) => {
+				write!(f, "`{}` feature not enabled, database can not be opened", feat)
+			},
 		}
 	}
 }