Make using insecure connections opt-in (#1309)

* add insecure url checks

* rename variables

* add feature flags to expose Url properly

* fix test compile error

* fix feature errors

* remove comment

* add url crate and use it for url parsing

* fix compile errors

* satisfy the holy clippy

* fix typos and host loopback

* macro attribute, provide validation function in utils

* fix expected output of ui tests

* remove the success case for --allow-insecure because we cannot establish ws:// connection at the moment.
This commit is contained in:
Tadeo Hepperle
2024-01-09 18:18:23 +01:00
committed by GitHub
parent 5b35a9f849
commit 7f714cbcb9
22 changed files with 562 additions and 413 deletions
@@ -1,4 +1,4 @@
error: One of 'runtime_metadata_path' or 'runtime_metadata_url' must be provided
error: One of 'runtime_metadata_path' or 'runtime_metadata_insecure_url' must be provided
--> src/incorrect/need_url_or_path.rs:1:1
|
1 | #[subxt::subxt()]
@@ -1,6 +1,6 @@
#[subxt::subxt(
runtime_metadata_path = "../../../../artifacts/polkadot_metadata_tiny.scale",
runtime_metadata_url = "wss://rpc.polkadot.io:443"
runtime_metadata_insecure_url = "wss://rpc.polkadot.io:443"
)]
pub mod node_runtime {}
@@ -1,9 +1,9 @@
error: Only one of 'runtime_metadata_path' or 'runtime_metadata_url' can be provided
error: Only one of 'runtime_metadata_path' or 'runtime_metadata_insecure_url' can be provided
--> src/incorrect/url_and_path_provided.rs:1:1
|
1 | / #[subxt::subxt(
2 | | runtime_metadata_path = "../../../../artifacts/polkadot_metadata_tiny.scale",
3 | | runtime_metadata_url = "wss://rpc.polkadot.io:443"
3 | | runtime_metadata_insecure_url = "wss://rpc.polkadot.io:443"
4 | | )]
| |__^
|