check line-width of only newly added lines (#2522)

* strictly require <= 120 characters
This commit is contained in:
gabriel klawitter
2019-05-13 17:51:09 +02:00
committed by GitHub
parent 3b0eca992c
commit 7fb3dc5f68
2 changed files with 62 additions and 1 deletions
+49
View File
@@ -0,0 +1,49 @@
#!/bin/sh
#
# check if line width of rust source files is not beyond x characters
#
BASE_BRANCH="origin/master"
LINE_WIDTH="121"
GOOD_LINE_WIDTH="101"
git diff --name-only ${BASE_BRANCH}...${CI_COMMIT_SHA} \*.rs | ( while read file
do
if git diff ${BASE_BRANCH}...${CI_COMMIT_SHA} ${file} | grep -q "^+.\{${LINE_WIDTH}\}"
then
if [ -z "${FAIL}" ]
then
echo "| warning!"
echo "| Lines should not be longer than 120 characters."
echo "| "
echo "| see more https://wiki.parity.io/Substrate-Style-Guide"
echo "|"
FAIL="true"
fi
echo "| file: ${file}"
git diff ${BASE_BRANCH}...${CI_COMMIT_SHA} ${file} \
| grep -n "^+.\{${LINE_WIDTH}\}"
echo "|"
else
if git diff ${BASE_BRANCH}...${CI_COMMIT_SHA} ${file} | grep -q "^+.\{${GOOD_LINE_WIDTH}\}"
then
if [ -z "${FAIL}" ]
then
echo "| warning!"
echo "| Lines should be longer than 100 characters only in exceptional circumstances!"
echo "| "
echo "| see more https://wiki.parity.io/Substrate-Style-Guide"
echo "|"
fi
echo "| file: ${file}"
git diff ${BASE_BRANCH}...${CI_COMMIT_SHA} ${file} \
| grep -n "^+.\{${LINE_WIDTH}\}"
echo "|"
fi
fi
done
test -z "${FAIL}"
)