pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-05-30 04:41:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make sure system tests are checking for the correct result (#491)

Browse Source
This commit is contained in:
Bastian Köcher
2021-06-13 11:23:13 +01:00
committed by GitHub
parent 2dc281b482
commit 80b739d886
1 changed files with 92 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cumulus/pallets/parachain-system/src/validate_block/tests.rs
+92 -52
View File
@@ -14,6 +14,7 @@
// You should have received a copy of the GNU General Public License // You should have received a copy of the GNU General Public License
// along with Cumulus. If not, see <http://www.gnu.org/licenses/>. // along with Cumulus. If not, see <http://www.gnu.org/licenses/>.
use codec::{Decode, Encode};
use cumulus_primitives_core::{ParachainBlockData, PersistedValidationData}; use cumulus_primitives_core::{ParachainBlockData, PersistedValidationData};
use cumulus_test_client::{ use cumulus_test_client::{
runtime::{Block, Hash, Header, UncheckedExtrinsic, WASM_BINARY}, runtime::{Block, Hash, Header, UncheckedExtrinsic, WASM_BINARY},
@@ -33,8 +34,7 @@ use sp_runtime::{
generic::BlockId, generic::BlockId,
traits::{Block as BlockT, Header as HeaderT}, traits::{Block as BlockT, Header as HeaderT},
}; };
use std::{env, process::Command};
use codec::{Decode, Encode};
fn call_validate_block( fn call_validate_block(
parent_head: Header, parent_head: Header,
@@ -187,74 +187,114 @@ fn validate_block_with_extra_extrinsics() {
} }
#[test] #[test]
#[should_panic(expected = "Calls `validate_block`: Other(\"Trap: Trap { kind: Unreachable }\")")]
fn validate_block_invalid_parent_hash() { fn validate_block_invalid_parent_hash() {
let _ = env_logger::try_init(); let _ = env_logger::try_init();
let (client, longest_chain) = create_test_client(); if env::var("RUN_TEST").is_ok() {
let parent_head = longest_chain.best_chain().expect("Best block exists"); let (client, longest_chain) = create_test_client();
let TestBlockData { let parent_head = longest_chain.best_chain().expect("Best block exists");
block, let TestBlockData {
witness, block,
validation_data, witness,
} = build_block_with_witness(&client, vec![], parent_head.clone(), Default::default()); validation_data,
let (mut header, extrinsics) = block.deconstruct(); } = build_block_with_witness(&client, vec![], parent_head.clone(), Default::default());
header.set_parent_hash(Hash::from_low_u64_be(1)); let (mut header, extrinsics) = block.deconstruct();
header.set_parent_hash(Hash::from_low_u64_be(1));
let block_data = ParachainBlockData::new(header, extrinsics, witness); let block_data = ParachainBlockData::new(header, extrinsics, witness);
call_validate_block( call_validate_block(
parent_head, parent_head,
block_data, block_data,
validation_data.relay_parent_storage_root, validation_data.relay_parent_storage_root,
) )
.expect("Calls `validate_block`"); .unwrap_err();
} else {
let output = Command::new(env::current_exe().unwrap())
.args(&["validate_block_invalid_parent_hash", "--", "--nocapture"])
.env("RUN_TEST", "1")
.output()
.expect("Runs the test");
assert!(output.status.success());
assert!(dbg!(String::from_utf8(output.stderr).unwrap()).contains("Invalid parent hash"));
}
} }
#[test] #[test]
#[should_panic(expected = "Calls `validate_block`: Other(\"Trap: Trap { kind: Unreachable }\")")]
fn validate_block_fails_on_invalid_validation_data() { fn validate_block_fails_on_invalid_validation_data() {
let _ = env_logger::try_init(); let _ = env_logger::try_init();
let (client, longest_chain) = create_test_client(); if env::var("RUN_TEST").is_ok() {
let parent_head = longest_chain.best_chain().expect("Best block exists"); let (client, longest_chain) = create_test_client();
let TestBlockData { block, witness, .. } = let parent_head = longest_chain.best_chain().expect("Best block exists");
build_block_with_witness(&client, vec![], parent_head.clone(), Default::default()); let TestBlockData { block, witness, .. } =
let (header, extrinsics) = block.deconstruct(); build_block_with_witness(&client, vec![], parent_head.clone(), Default::default());
let (header, extrinsics) = block.deconstruct();
let block_data = ParachainBlockData::new(header, extrinsics, witness); let block_data = ParachainBlockData::new(header, extrinsics, witness);
call_validate_block(parent_head, block_data, Hash::random()).expect("Calls `validate_block`"); call_validate_block(parent_head, block_data, Hash::random()).unwrap_err();
} else {
let output = Command::new(env::current_exe().unwrap())
.args(&[
"validate_block_fails_on_invalid_validation_data",
"--",
"--nocapture",
])
.env("RUN_TEST", "1")
.output()
.expect("Runs the test");
assert!(output.status.success());
assert!(dbg!(String::from_utf8(output.stderr).unwrap())
.contains("Relay parent storage root doesn't match"));
}
} }
#[test] #[test]
#[should_panic(expected = "Calls `validate_block`: Other(\"Trap: Trap { kind: Unreachable }\")")]
fn check_inherent_fails_on_validate_block_as_expected() { fn check_inherent_fails_on_validate_block_as_expected() {
let _ = env_logger::try_init(); let _ = env_logger::try_init();
let (client, longest_chain) = create_test_client(); if env::var("RUN_TEST").is_ok() {
let parent_head = longest_chain.best_chain().expect("Best block exists"); let (client, longest_chain) = create_test_client();
let parent_head = longest_chain.best_chain().expect("Best block exists");
let TestBlockData { let TestBlockData {
block, block,
witness, witness,
validation_data, validation_data,
} = build_block_with_witness( } = build_block_with_witness(
&client, &client,
vec![], vec![],
parent_head.clone(), parent_head.clone(),
RelayStateSproofBuilder { RelayStateSproofBuilder {
current_slot: 1337.into(), current_slot: 1337.into(),
..Default::default() ..Default::default()
}, },
); );
let (header, extrinsics) = block.deconstruct(); let (header, extrinsics) = block.deconstruct();
let block_data = ParachainBlockData::new(header.clone(), extrinsics, witness); let block_data = ParachainBlockData::new(header.clone(), extrinsics, witness);
let res_header = call_validate_block( call_validate_block(
parent_head, parent_head,
block_data, block_data,
validation_data.relay_parent_storage_root, validation_data.relay_parent_storage_root,
) )
.expect("Calls `validate_block`"); .unwrap_err();
assert_eq!(header, res_header); } else {
let output = Command::new(env::current_exe().unwrap())
.args(&[
"check_inherent_fails_on_validate_block_as_expected",
"--",
"--nocapture",
])
.env("RUN_TEST", "1")
.output()
.expect("Runs the test");
assert!(output.status.success());
assert!(
dbg!(String::from_utf8(output.stderr).unwrap()).contains("Checking inherents failed")
);
}
} }