Merge v0.50.x to master (#2127)

* v0.50.0: Integrate frame-decode, redo storage APIs and break up Error. (#2100)

* WIP integrating new frame-decode and working out new storage APIS

* WIP: first pass adding new storage things to subxt-core

* Second pass over Address type and start impl in Subxt

* WIP new storage APIs

* WIP New storage APIs roughly completed, lots of errors still

* Remove PlainorMap enum; plain and map values now use same struct to simplify usage

* Begin 'fixing' errors

* WIP splitting errors and tidying payload/address traits

* Get subxt-core compiling

* Small fixes in subxt-core and remove metadata mod

* subxt-core: cargo check --all-targets passes

* Fix test

* WIP starting to update subxt from subxt-core changes

* WIP splitting up subxt errors into smaller variants

* WIP errors: add DispatchError errors

* Port new Storage APIs to subxt-core

* cargo check -p subxt passes

* Quick-fix errors in subxt-cli (explore subcommand)

* fmt

* Finish fixing codegen up and start fixing examples

* get Subxt examples compiling and bytes_at for constants

* Add some arcs to limit lifetimes in subxt/subxt-core storage APIs

* A little Arcing to allow more method chaining in Storage APIs, aligning with Subxt

* Update codegen test

* cargo check --all-targets passing

* cargo check --features 'unstable-light-client' passing

* clippy

* Remove unused dep in subxt

* use published frame-decode

* fix wasm-example

* Add new tx extension to fix daily tests

* Remove unused subxt_core::dynamic::DecodedValue type

* Update book to match changes

* Update docs to fix more broken bits

* Add missing docs

* fmt

* allow larger result errs for now

* Add missing alloc imports in subxt-core

* Fix doc tests and fix bug getting constant info

* Fix V14 -> Metadata transform for storage & constants

* Fix parachain example

* Fix FFI example

* BlockLength decodes t ostruct, not u128

* use fetch/iter shorthands rather than entry in most storage tests

* Fix some integration tests

* Fix Runtime codegen tests

* Expose the dynamic custom_value selecter and use in a UI test

* Update codegen metadata

* Tidy CLI storage query and support (str,str) as a storage address

* Add (str,str) as valid constant address too

* Show string tuple in constants example

* Via the magic of traits, avoid needing any clones of queries/addresses and accept references to them

* clippy

* [v0.50] update scale-info-legacy and frame-decode to latest (#2119)

* bump scale-info-legacy and frame-decode to latest

* Remove something we don't need in this PR

* Fully remove unused for now dep

* [v0.50] Convert historic metadata to subxt::Metadata (#2120)

* First pass converting historic metadatas to our subxt::Metadata type

* use published frame-decode

* fmt and rename legacy metadata macro

* Enable legacy feature where needed in subxt_metadata so it compiles on its own

* Use cargo hack more in CI and fix subxt-metadata features

* Add tests for metadata conversion (need to optimise; some too expensive right now

* Address performance and equality issues in metadata conversion testing

* fmt

* fmt all

* clippy

* Fix a doc link

* Test codegen and fixes to make it work

* Remove local frame-decode patch

* bump frame-decode to latest

* [v0.50.0] Allow visiting extrinsic fields in subxt_historic (#2124)

* Allow visiting extrinsic fields

* fmt

* Don't use local scale-decode dep

* Clippy and tidy

* Extend 'subxt codegen' CLI to work with legacy metadatas

* Simplify historic extrinsics example now that AccountId32s have paths/names

* clippy

* clippy

* clippy..

* Allow visiting storage values, too, and clean up extrinsic visiting a little by narrowing lifetime

* Try to fix flaky test

* Add custom value decode to extrinsics example

* Remove useless else branch ra thought I needed

* Simplify examples

* Prep to release v0.0.5 (#2126)

testing/integration-tests/src/full_client/frame/contracts.rs

@@ -75,7 +75,8 @@ impl ContractsTestContext {
 
         let code_stored = events
             .find_first::<events::CodeStored>()?
-            .ok_or_else(|| Error::Other("Failed to find a CodeStored event".into()))?;
+            .ok_or_else(|| Error::other_str("Failed to find a CodeStored event"))?;
+
         Ok(code_stored.code_hash)
     }
 
@@ -109,13 +110,13 @@ impl ContractsTestContext {
 
         let code_stored = events
             .find_first::<events::CodeStored>()?
-            .ok_or_else(|| Error::Other("Failed to find a CodeStored event".into()))?;
+            .ok_or_else(|| Error::other_str("Failed to find a CodeStored event"))?;
         let instantiated = events
             .find_first::<events::Instantiated>()?
-            .ok_or_else(|| Error::Other("Failed to find a Instantiated event".into()))?;
+            .ok_or_else(|| Error::other_str("Failed to find a Instantiated event"))?;
         let _extrinsic_success = events
             .find_first::<system::events::ExtrinsicSuccess>()?
-            .ok_or_else(|| Error::Other("Failed to find a ExtrinsicSuccess event".into()))?;
+            .ok_or_else(|| Error::other_str("Failed to find a ExtrinsicSuccess event"))?;
 
         tracing::info!("  Code hash: {:?}", code_stored.code_hash);
         tracing::info!("  Contract address: {:?}", instantiated.contract);
@@ -156,7 +157,7 @@ impl ContractsTestContext {
         tracing::info!("Instantiate result: {:?}", result);
         let instantiated = result
             .find_first::<events::Instantiated>()?
-            .ok_or_else(|| Error::Other("Failed to find a Instantiated event".into()))?;
+            .ok_or_else(|| Error::other_str("Failed to find a Instantiated event"))?;
 
         Ok(instantiated.contract)
     }
@@ -218,37 +219,26 @@ async fn tx_call() {
     let cxt = ContractsTestContext::init().await;
     let (_, contract) = cxt.instantiate_with_code().await.unwrap();
 
-    let info_addr = node_runtime::storage()
-        .contracts()
-        .contract_info_of(contract.clone());
+    let storage_at = cxt.client().storage().at_latest().await.unwrap();
 
-    let contract_info = cxt
-        .client()
-        .storage()
-        .at_latest()
+    let contract_info_addr = node_runtime::storage().contracts().contract_info_of();
+
+    let contract_info = storage_at
+        .fetch(&contract_info_addr, (contract.clone(),))
         .await
-        .unwrap()
-        .fetch(&info_addr)
-        .await;
+        .unwrap();
 
     assert!(
-        contract_info.is_ok(),
+        contract_info.decode().is_ok(),
         "Contract info is not ok, is: {contract_info:?}"
     );
 
-    let info_addr_iter = node_runtime::storage().contracts().contract_info_of_iter();
+    let mut iter = storage_at.iter(contract_info_addr, ()).await.unwrap();
 
-    let keys_and_values = cxt
-        .client()
-        .storage()
-        .at_latest()
-        .await
-        .unwrap()
-        .iter(info_addr_iter)
-        .await
-        .unwrap()
-        .collect::<Vec<_>>()
-        .await;
+    let mut keys_and_values = Vec::new();
+    while let Some(kv) = iter.next().await {
+        keys_and_values.push(kv);
+    }
 
     assert_eq!(keys_and_values.len(), 1);
     println!("keys+values post: {keys_and_values:?}");