From 833478f262943d0490f44dec9938abaee7dd4aec Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bastian=20K=C3=B6cher?= <git@kchr.de>
Date: Wed, 6 Dec 2023 23:16:56 +0100
Subject: [PATCH] Relax approval requirements on CI files (#2564)

- Remove the old Cumulus checks as these files do not exist anymore
- Relax requirements on CI files to also give two core devs the right to
change these files
- Relax requirements on the review bot configuration itself as well.
---
 .github/review-bot.yml | 47 +++++++++++-------------------------------
 1 file changed, 12 insertions(+), 35 deletions(-)

diff --git a/.github/review-bot.yml b/.github/review-bot.yml
index a515594960..aa4ab8a69e 100644
--- a/.github/review-bot.yml
+++ b/.github/review-bot.yml
@@ -1,5 +1,6 @@
 rules:
   - name: CI files
+    countAuthor: true
     condition:
       include:
         - ^\.gitlab-ci\.yml
@@ -8,24 +9,26 @@ rules:
         - ^\.gitlab/.*
         - ^\.config/nextest.toml
         - ^\.cargo/.*
-      exclude: 
+      exclude:
         - ^\.gitlab/pipeline/zombienet.*
-    minApprovals: 2
-    type: basic
-    teams:
-      - ci
-      - release-engineering
+    type: "or"
+    reviewers:
+      - minApprovals: 2
+        teams:
+          - ci
+      - minApprovals: 2
+        teams:
+          - core-devs
 
   - name: Audit rules
     type: basic
     condition:
       include:
-        - ^polkadot/runtime\/(kusama|polkadot|common)\/.*
+        - ^polkadot/runtime/common/.*
         - ^polkadot/primitives/src\/.+\.rs$
         - ^substrate/primitives/.*
         - ^substrate/frame/.*
       exclude:
-        - ^polkadot/runtime\/(kusama|polkadot)\/src\/weights\/.+\.rs$
         - ^substrate\/frame\/.+\.md$
     minApprovals: 1
     allowedToSkipRule:
@@ -41,13 +44,8 @@ rules:
         - .*
       # excluding files from 'Runtime files' and 'CI files' rules
       exclude:
-        - ^polkadot/runtime/(kusama|polkadot)/src/[^/]+\.rs$
-        - ^cumulus/parachains/runtimes/assets/(asset-hub-kusama|asset-hub-polkadot)/src/[^/]+\.rs$
-        - ^cumulus/parachains/runtimes/bridge-hubs/(bridge-hub-kusama|bridge-hub-polkadot)/src/[^/]+\.rs$
-        - ^cumulus/parachains/runtimes/collectives/collectives-polkadot/src/[^/]+\.rs$
         - ^cumulus/parachains/common/src/[^/]+\.rs$
         - ^substrate/frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*|aura/.*))
-        - ^polkadot/runtime/(kusama|polkadot)/src/[^/]+\.rs$
         - ^\.gitlab-ci\.yml
         - ^docker/.*
         - ^\.github/.*
@@ -59,24 +57,6 @@ rules:
     teams:
       - core-devs
 
-  # cumulus
-  - name: Runtime files cumulus
-    countAuthor: true
-    condition:
-      include:
-        - ^cumulus/parachains/runtimes/assets/(asset-hub-kusama|asset-hub-polkadot)/src/[^/]+\.rs$
-        - ^cumulus/parachains/runtimes/bridge-hubs/(bridge-hub-kusama|bridge-hub-polkadot)/src/[^/]+\.rs$
-        - ^cumulus/parachains/runtimes/collectives/collectives-polkadot/src/[^/]+\.rs$
-        - ^cumulus/parachains/common/src/[^/]+\.rs$
-    type: and-distinct
-    reviewers:
-      - minApprovals: 1
-        teams:
-          - locks-review
-      - minApprovals: 1
-        teams:
-          - polkadot-review
-
   # if there are any changes in the bridges subtree (in case of backport changes back to bridges repo)
   - name: Bridges subtree files
     type: basic
@@ -88,7 +68,6 @@ rules:
       - bridges-core
 
   # substrate
-
   - name: FRAME coders substrate
     condition:
       include:
@@ -104,6 +83,7 @@ rules:
 
   # Protection of THIS file
   - name: Review Bot
+    countAuthor: true
     condition:
       include:
         - review-bot\.yml
@@ -115,9 +95,6 @@ rules:
       - minApprovals: 1
         teams:
           - locks-review
-      - minApprovals: 1
-        teams:
-          - ci
 
 preventReviewRequests:
   teams: