pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-05-31 13:21:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Warn if participated in the losing side of a dispute (#7404)

Browse Source 
* Warn if participated in the losing side of a dispute

* Update naming

* Additionally filter by candidate hash

* Debug zombienet tests

* Update 0002-parachains-disputes.zndsl

* Debug zombienet

* Update node/core/dispute-coordinator/src/initialized.rs

Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>

* Add checking to zombienet tests

---------

Co-authored-by: Andrei Sandu <54316454+sandreim@users.noreply.github.com>
This commit is contained in:
Andrei Eres
2023-06-23 13:45:48 +02:00
committed by GitHub
parent ae2e669a6a
commit 866aa1e8d4
3 changed files with 36 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
polkadot/node/core/dispute-coordinator/src/initialized.rs
+30
View File
@@ -1003,6 +1003,16 @@ impl Initialized {
gum::trace!(target: LOG_TARGET, ?candidate_hash, ?session, "Loaded votes");
let controlled_indices = env.controlled_indices();
let own_statements = statements
.iter()
.filter(|(statement, validator_index)| {
controlled_indices.contains(validator_index) &&
*statement.candidate_hash() == candidate_hash
})
.cloned()
.collect::<Vec<_>>();
let import_result = {
let intermediate_result = old_state.import_statements(&env, statements, now);
@@ -1307,6 +1317,16 @@ impl Initialized {
session,
"Dispute on candidate concluded with 'valid' result",
);
for (statement, validator_index) in own_statements.iter() {
if statement.statement().indicates_invalidity() {
gum::warn!(
target: LOG_TARGET,
?candidate_hash,
?validator_index,
"Voted against a candidate that was concluded valid.",
);
}
}
self.metrics.on_concluded_valid();
}
if import_result.is_freshly_concluded_against() {
@@ -1316,6 +1336,16 @@ impl Initialized {
session,
"Dispute on candidate concluded with 'invalid' result",
);
for (statement, validator_index) in own_statements.iter() {
if statement.statement().indicates_validity() {
gum::warn!(
target: LOG_TARGET,
?candidate_hash,
?validator_index,
"Voted for a candidate that was concluded invalid.",
);
}
}
self.metrics.on_concluded_invalid();
}
polkadot/zombienet_tests/functional/0002-parachains-disputes.zndsl
+3
View File
@@ -53,3 +53,6 @@ ferdie: reports polkadot_parachain_disputes_finality_lag is 0
eve: reports polkadot_parachain_disputes_finality_lag is 0
one: reports polkadot_parachain_disputes_finality_lag is 0
two: reports polkadot_parachain_disputes_finality_lag is 0
# Check participating in the losing side of a dispute logged
alice: log line contains "Voted against a candidate that was concluded valid." within 180 seconds
polkadot/zombienet_tests/functional/0003-parachains-garbage-candidate.zndsl
+3
View File
@@ -39,3 +39,6 @@ honest-validator-2: reports parachain_candidate_disputes_total is at least 2 wit
# Disputes should always end as "invalid"
honest-validator-0: reports parachain_candidate_dispute_concluded{validity="invalid"} is at least 2 within 15 seconds
honest-validator-1: reports parachain_candidate_dispute_concluded{validity="valid"} is 0 within 15 seconds
# Check participating in the losing side of a dispute logged
malus-validator: log line contains "Voted for a candidate that was concluded invalid." within 180 seconds