[big refactor] Remove crate aliasing. (#4395)

* Rename: Phase 1.

* Unify codec.

* Fixing: Phase 2

* Fixing: Phase 3.

* Fixing: Phase 4.

* Fixing: Phase 5.

* Fixing: Phase 6.

* Fixing: Phase 7.

* Fixing: Phase 8. Tests

* Fixing: Phase 9. Tests!!!

* Fixing: Phase 10. Moar tests!

* Finally done!

* More fixes.

* Rename primitives:: to sp_core::

* Apply renames in finality-grandpa.

* Fix benches.

* Fix benches 2.

* Revert node-template.

* Fix frame-system in our modules.

substrate/frame/support/procedural/src/construct_runtime/mod.rs

@@ -79,7 +79,7 @@ fn construct_runtime_parsed(definition: RuntimeDefinition) -> Result<TokenStream
 		&scrate,
 		DeclOuterKind::Origin,
 	)?;
-	let all_modules = decl_all_modules(&name, all_but_system_modules);
+	let all_modules = decl_all_modules(&name, &system_module, all_but_system_modules);
 
 	let dispatch = decl_outer_dispatch(&name, modules.iter(), &scrate);
 	let metadata = decl_runtime_metadata(&name, modules.iter(), &scrate);
@@ -308,6 +308,7 @@ fn decl_outer_event_or_origin<'a>(
 
 fn decl_all_modules<'a>(
 	runtime: &'a Ident,
+	system_name: &'a Ident,
 	module_declarations: impl Iterator<Item = &'a ModuleDeclaration>,
 ) -> TokenStream2 {
 	let mut types = TokenStream2::new();
@@ -335,7 +336,7 @@ fn decl_all_modules<'a>(
 	);
 
 	quote!(
-		pub type System = system::Module<#runtime>;
+		pub type System = #system_name::Module<#runtime>;
 		#types
 		type AllModules = ( #all_modules );
 	)

substrate/frame/support/procedural/src/construct_runtime/parse.rs

@@ -243,7 +243,7 @@ impl ModuleDeclaration {
 			.collect();
 		res.extend(
 			["Event", "Config"]
-				.into_iter()
+				.iter()
 				.map(|name| ModulePart::with_generics(name, span)),
 		);
 		res
@@ -345,7 +345,7 @@ impl ModulePart {
 
 	pub fn is_included_in_default(&self) -> bool {
 		["Module", "Call", "Storage", "Event", "Config"]
-			.into_iter()
+			.iter()
 			.any(|name| self.name == name)
 	}