scale-type-resolver integration (#1460)

* start migrating, broken

* first iteration of updating

* fmt and clippy

* add Composite<u32> decoding via scale value patch

* bump scale type gen versions

* fix decoding with new scale decode

* fix js-sys versions

* add nit comments

subxt/src/tx/mod.rs

@@ -28,6 +28,6 @@ pub use self::{
         PartialExtrinsic, SubmittableExtrinsic, TransactionInvalid, TransactionUnknown, TxClient,
         ValidationResult,
     },
-    tx_payload::{dynamic, BoxedPayload, DynamicPayload, Payload, TxPayload},
+    tx_payload::{dynamic, DynamicPayload, Payload, TxPayload},
     tx_progress::{TxInBlock, TxProgress, TxStatus},
 };

subxt/src/tx/tx_payload.rs

@@ -14,7 +14,7 @@ use codec::Encode;
 use derivative::Derivative;
 use scale_encode::EncodeAsFields;
 use scale_value::{Composite, ValueDef, Variant};
-use std::{borrow::Cow, sync::Arc};
+use std::borrow::Cow;
 
 /// This represents a transaction payload that can be submitted
 /// to a node.
@@ -65,10 +65,6 @@ pub struct Payload<CallData> {
     validation_hash: Option<[u8; 32]>,
 }
 
-/// A boxed transaction payload.
-// Dev Note: Arc used to enable easy cloning (given that we can't have dyn Clone).
-pub type BoxedPayload = Payload<Arc<dyn EncodeAsFields + Send + Sync + 'static>>;
-
 /// The type of a payload typically used for dynamic transaction payloads.
 pub type DynamicPayload = Payload<Composite<()>>;
 
@@ -104,19 +100,6 @@ impl<CallData> Payload<CallData> {
         }
     }
 
-    /// Box the payload.
-    pub fn boxed(self) -> BoxedPayload
-    where
-        CallData: EncodeAsFields + Send + Sync + 'static,
-    {
-        BoxedPayload {
-            pallet_name: self.pallet_name,
-            call_name: self.call_name,
-            call_data: Arc::new(self.call_data),
-            validation_hash: self.validation_hash,
-        }
-    }
-
     /// Do not validate this call prior to submitting it.
     pub fn unvalidated(self) -> Self {
         Self {
@@ -174,7 +157,7 @@ impl<CallData: EncodeAsFields> TxPayload for Payload<CallData> {
         let mut fields = call
             .fields
             .iter()
-            .map(|f| scale_encode::Field::new(f.ty.id, f.name.as_deref()));
+            .map(|f| scale_encode::Field::new(&f.ty.id, f.name.as_deref()));
 
         self.call_data
             .encode_as_fields_to(&mut fields, metadata.types(), out)?;