pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-05-30 15:11:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

sanity check on validity-votes length (#354)

Browse Source
This commit is contained in:
Robert Habermeier
2019-08-06 15:37:38 +02:00
committed by Gavin Wood
parent 14cf3142d3
commit 8c4d882407
1 changed files with 16 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
polkadot/runtime/src/parachains.rs
+15 -2
View File
@@ -737,12 +737,20 @@ impl<T: Trait> Module<T> {
let mut encoded_implicit = None;
let mut encoded_explicit = None;
for ((auth_index, _), validity_attestation) in candidate.validator_indices
let mut expected_votes_len = 0;
for (vote_index, (auth_index, _)) in candidate.validator_indices
.iter()
.enumerate()
.filter(|(_, bit)| *bit)
.zip(candidate.validity_votes.iter())
.enumerate()
{
let validity_attestation = match candidate.validity_votes.get(vote_index) {
None => return Err("Not enough validity votes"),
Some(v) => {
expected_votes_len = vote_index + 1;
v
}
};
if validator_group.iter().find(|&(idx, _)| *idx == auth_index).is_none() {
return Err("Attesting validator not on this chain's validation duty.");
@@ -774,6 +782,11 @@ impl<T: Trait> Module<T> {
"Candidate validity attestation signature is bad."
);
}
ensure!(
candidate.validity_votes.len() == expected_votes_len,
"Extra untagged validity votes along with candidate"
);
}
Ok(())