pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-16 12:01:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused FullCandidateReceipt (#3641)

Browse Source 
Currently redesigning candidate data structures, noticed that this one
seems dead.

Co-authored-by: eskimor <eskimor@no-such-url.com>
This commit is contained in:
eskimor
2024-03-11 15:11:55 +01:00
committed by GitHub
parent a6713c55fd
commit 8dc6048d5e
3 changed files with 2 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files
polkadot/roadmap/implementers-guide/src/types/README.md
-11
View File
@@ -55,17 +55,6 @@ digraph {
CandidateCommitmentsHash [label = "Hash", shape="doublecircle", fill="gray90"]
CandidateCommitmentsHash -> CandidateCommitments:name
FullCandidateReceipt [label = <
<table>
<tr><td border="0" colspan="2" port="name">FullCandidateReceipt&lt;H = Hash, N = BlockNumber&gt;</td></tr>
<tr><td>inner</td><td port="inner">CandidateReceipt&lt;H&gt;</td></tr>
<tr><td>validation_data</td><td port="validation_data">ValidationData&lt;N&gt;</td></tr>
</table>
>]
FullCandidateReceipt:inner -> CandidateReceipt:name
FullCandidateReceipt:validation_data -> ValidationData:name
CommittedCandidateReceipt [label = <
<table>
<tr><td border="0" colspan="2" port="name">CommittedCandidateReceipt&lt;H = Hash&gt;</td></tr>
polkadot/roadmap/implementers-guide/src/types/candidate.md
+2 -24
View File
@@ -20,12 +20,8 @@ struct ParaId(u32);
## Candidate Receipt
Much info in a [`FullCandidateReceipt`](#full-candidate-receipt) is duplicated from the relay-chain state. When the
corresponding relay-chain state is considered widely available, the Candidate Receipt should be favored over the
`FullCandidateReceipt`.
Examples of situations where the state is readily available includes within the scope of work done by subsystems working
on a given relay-parent, or within the logic of the runtime importing a backed candidate.
Compact representation of the result of a validation. This is what validators
receive from collators, together with the PoV.
```rust
/// A candidate-receipt.
@@ -37,24 +33,6 @@ struct CandidateReceipt {
}
```
## Full Candidate Receipt
This is the full receipt type. The `PersistedValidationData` are technically redundant with the `inner.relay_parent`,
which uniquely describes the block in the blockchain from whose state these values are derived. The
[`CandidateReceipt`](#candidate-receipt) variant is often used instead for this reason.
However, the Full Candidate Receipt type is useful as a means of avoiding the implicit dependency on availability of old
blockchain state. In situations such as availability and approval, having the full description of the candidate within a
self-contained struct is convenient.
```rust
/// All data pertaining to the execution of a para candidate.
struct FullCandidateReceipt {
inner: CandidateReceipt,
validation_data: PeristedValidationData,
}
```
## Committed Candidate Receipt
This is a variant of the candidate receipt which includes the commitments of the candidate receipt alongside the