mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-07-21 06:15:41 +00:00
Issue 4804: Notify chain selection of concluded disputes directly (#6512)
* Setting up new ChainSelectionMessage * Partial first pass * Got dispute conclusion data to provisioner * Finished first draft for 4804 code * A bit of polish and code comments * cargo fmt * Implementers guide and code comments * More formatting, and naming issues * Wrote test for ChainSelection side of change * Added dispute coordinator side test * FMT * Addressing Marcin's comments * fmt * Addressing further Marcin comment * Removing unnecessary test line * Rough draft addressing Robert changes * Clean up and test modification * Majorly refactored scraper change * Minor fixes for ChainSelection * Polish and fmt * Condensing inclusions per candidate logic * Addressing Tsveto's comments * Addressing Robert's Comments * Altered inclusions struct to use nested BTreeMaps * Naming fix * Fixing inclusions struct comments * Update node/core/dispute-coordinator/src/scraping/mod.rs Add comment to split_off() use Co-authored-by: Marcin S. <marcin@bytedude.com> * Optimizing removal at block height for inclusions * fmt * Using copy trait Co-authored-by: Marcin S. <marcin@bytedude.com>
This commit is contained in:
@@ -9,7 +9,11 @@ In particular the dispute-coordinator is responsible for:
|
||||
|
||||
- Ensuring that the node is able to raise a dispute in case an invalid candidate
|
||||
is found during approval checking.
|
||||
- Ensuring approval votes will be recorded.
|
||||
- Ensuring that backing and approval votes will be recorded on chain. With these
|
||||
votes on chain we can be certain that appropriate targets for slashing will be
|
||||
available for concluded disputes. Also, scraping these votes during a dispute
|
||||
is necessary for critical spam prevention measures.
|
||||
- Ensuring backing votes will never get overridden by explicit votes.
|
||||
- Coordinating actual participation in a dispute, ensuring that the node
|
||||
participates in any justified dispute in a way that ensures resolution of
|
||||
disputes on the network even in the case of many disputes raised (flood/DoS
|
||||
@@ -17,15 +21,13 @@ In particular the dispute-coordinator is responsible for:
|
||||
- Ensuring disputes resolve, even for candidates on abandoned forks as much as
|
||||
reasonably possible, to rule out "free tries" and thus guarantee our gambler's
|
||||
ruin property.
|
||||
- Provide an API for chain selection, so we can prevent finalization of any
|
||||
- Providing an API for chain selection, so we can prevent finalization of any
|
||||
chain which has included candidates for which a dispute is either ongoing or
|
||||
concluded invalid and avoid building on chains with an included invalid
|
||||
candidate.
|
||||
- Provide an API for retrieving (resolved) disputes, including all votes, both
|
||||
- Providing an API for retrieving (resolved) disputes, including all votes, both
|
||||
implicit (approval, backing) and explicit dispute votes. So validators can get
|
||||
rewarded/slashed accordingly.
|
||||
- Ensure backing votes are recorded and will never get overridden by explicit
|
||||
votes.
|
||||
|
||||
## Ensuring That Disputes Can Be Raised
|
||||
|
||||
|
||||
Reference in New Issue
Block a user