mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-29 10:17:57 +00:00
approval votes checking logs (#3233)
* approval-voting: logs for invalid votes * proper errors for assignment checks * proper errors for approval checks
This commit is contained in:
@@ -397,8 +397,9 @@ fn rejects_bad_assignment() {
|
||||
assert!(res.1.iter().any(|action| matches!(action, Action::WriteCandidateEntry(..))));
|
||||
|
||||
// unknown hash
|
||||
let unknown_hash = Hash::repeat_byte(0x02);
|
||||
let assignment = IndirectAssignmentCert {
|
||||
block_hash: Hash::repeat_byte(0x02),
|
||||
block_hash: unknown_hash,
|
||||
validator: ValidatorIndex(0),
|
||||
cert: garbage_assignment_cert(
|
||||
AssignmentCertKind::RelayVRFModulo {
|
||||
@@ -412,7 +413,7 @@ fn rejects_bad_assignment() {
|
||||
assignment,
|
||||
candidate_index,
|
||||
).unwrap();
|
||||
assert_eq!(res.0, AssignmentCheckResult::Bad);
|
||||
assert_eq!(res.0, AssignmentCheckResult::Bad(AssignmentCheckError::UnknownBlock(unknown_hash)));
|
||||
|
||||
let mut state = State {
|
||||
assignment_criteria: Box::new(MockAssignmentCriteria::check_only(|| {
|
||||
@@ -427,7 +428,7 @@ fn rejects_bad_assignment() {
|
||||
assignment_good,
|
||||
candidate_index,
|
||||
).unwrap();
|
||||
assert_eq!(res.0, AssignmentCheckResult::Bad);
|
||||
assert_eq!(res.0, AssignmentCheckResult::Bad(AssignmentCheckError::InvalidCert(ValidatorIndex(0))));
|
||||
}
|
||||
|
||||
#[test]
|
||||
@@ -495,7 +496,7 @@ fn rejects_assignment_with_unknown_candidate() {
|
||||
assignment.clone(),
|
||||
candidate_index,
|
||||
).unwrap();
|
||||
assert_eq!(res.0, AssignmentCheckResult::Bad);
|
||||
assert_eq!(res.0, AssignmentCheckResult::Bad(AssignmentCheckError::InvalidCandidateIndex(candidate_index)));
|
||||
}
|
||||
|
||||
#[test]
|
||||
@@ -579,7 +580,7 @@ fn rejects_approval_before_assignment() {
|
||||
|r| r
|
||||
).unwrap();
|
||||
|
||||
assert_eq!(res, ApprovalCheckResult::Bad);
|
||||
assert_eq!(res, ApprovalCheckResult::Bad(ApprovalCheckError::NoAssignment(ValidatorIndex(0))));
|
||||
assert!(actions.is_empty());
|
||||
}
|
||||
|
||||
@@ -611,7 +612,7 @@ fn rejects_approval_if_no_candidate_entry() {
|
||||
|r| r
|
||||
).unwrap();
|
||||
|
||||
assert_eq!(res, ApprovalCheckResult::Bad);
|
||||
assert_eq!(res, ApprovalCheckResult::Bad(ApprovalCheckError::InvalidCandidate(0, candidate_hash)));
|
||||
assert!(actions.is_empty());
|
||||
}
|
||||
|
||||
@@ -649,7 +650,7 @@ fn rejects_approval_if_no_block_entry() {
|
||||
|r| r
|
||||
).unwrap();
|
||||
|
||||
assert_eq!(res, ApprovalCheckResult::Bad);
|
||||
assert_eq!(res, ApprovalCheckResult::Bad(ApprovalCheckError::UnknownBlock(block_hash)));
|
||||
assert!(actions.is_empty());
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user