pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-05-30 10:31:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

A simple check to reject obviously wrong validation code binaries (#1989)

Browse Source 
* A simple check to reject obviously wrong validation code binaries

* Use wasm-magic constants in the tests.

* tabs not spaces

* move WASM_MAGIC into lib.rs
This commit is contained in:
Sergei Shulepov
2020-11-19 20:22:17 +01:00
committed by GitHub
parent 759ff2bb6e
commit 94670d8082
3 changed files with 21 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
polkadot/runtime/common/src/paras_registrar.rs
+13 -9
View File
@@ -17,8 +17,8 @@
//! Module to handle parathread/parachain registration and related fund management.
//! In essence this is a simple wrapper around `paras`.
use crate::WASM_MAGIC;
use sp_std::{prelude::*, result};
use frame_support::{
decl_storage, decl_module, decl_error, ensure,
dispatch::DispatchResult,
@@ -86,6 +86,8 @@ decl_error! {
HeadDataTooLarge,
/// Parathreads registration is disabled.
ParathreadsRegistrationDisabled,
/// The validation code provided doesn't start with the Wasm file magic string.
DefinitelyNotWasm,
}
}
@@ -96,7 +98,7 @@ decl_module! {
/// Register a parathread with given code for immediate use.
///
/// Must be sent from a Signed origin that is able to have `ParathreadDeposit` reserved.
/// `gensis_head` and `validation_code` are used to initalize the parathread's state.
/// `genesis_head` and `validation_code` are used to initalize the parathread's state.
#[weight = 0]
fn register_parathread(
origin,
@@ -107,6 +109,7 @@ decl_module! {
let who = ensure_signed(origin)?;
ensure!(ParathreadsRegistrationEnabled::get(), Error::<T>::ParathreadsRegistrationDisabled);
ensure!(validation_code.0.starts_with(WASM_MAGIC), Error::<T>::DefinitelyNotWasm);
ensure!(!Paras::contains_key(id), Error::<T>::ParaAlreadyExists);
@@ -217,6 +220,7 @@ impl<T: Trait> Module<T> {
validation_code: ValidationCode,
) -> DispatchResult {
ensure!(!Paras::contains_key(id), Error::<T>::ParaAlreadyExists);
ensure!(validation_code.0.starts_with(WASM_MAGIC), Error::<T>::DefinitelyNotWasm);
let outgoing = <paras::Module<T>>::outgoing_paras();
@@ -609,7 +613,7 @@ mod tests {
assert_ok!(Registrar::register_parachain(
2u32.into(),
vec![3; 3].into(),
vec![3; 3].into(),
WASM_MAGIC.to_vec().into(),
));
let orig_bal = Balances::free_balance(&3u64);
@@ -619,7 +623,7 @@ mod tests {
Origin::signed(3u64),
8u32.into(),
vec![3; 3].into(),
vec![3; 3].into(),
WASM_MAGIC.to_vec().into(),
));
// deposit should be taken (reserved)
@@ -658,13 +662,13 @@ mod tests {
Origin::signed(1),
8u32.into(),
vec![1; 3].into(),
vec![1; 3].into(),
WASM_MAGIC.to_vec().into(),
));
assert_ok!(Registrar::register_parachain(
2u32.into(),
vec![1; 3].into(),
vec![1; 3].into(),
WASM_MAGIC.to_vec().into(),
));
run_to_block(9);
@@ -692,7 +696,7 @@ mod tests {
assert_ok!(Registrar::register_parachain(
1u32.into(),
vec![1; 3].into(),
vec![1; 3].into(),
WASM_MAGIC.to_vec().into(),
));
run_to_block(4);
@@ -703,7 +707,7 @@ mod tests {
assert!(Registrar::register_parachain(
1u32.into(),
vec![1; 3].into(),
vec![1; 3].into(),
WASM_MAGIC.to_vec().into(),
).is_err());
run_to_block(6);
@@ -711,7 +715,7 @@ mod tests {
assert_ok!(Registrar::register_parachain(
1u32.into(),
vec![1; 3].into(),
vec![1; 3].into(),
WASM_MAGIC.to_vec().into(),
));
});
}