removes use of sc_client::Client from sc-rpc (#5063)

* removes use of sc_client::Client from sc-rpc

* remove Client impl from sc-finality-benches

* remove client impl from sc-finality-grandpa

* read_proof accepts iterator

* remove generic Executor param from ExecutorProvider

* fix long ass line

* code style changes

* merge with master

Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com>

substrate/client/src/light/call_executor.rs

@@ -40,7 +40,7 @@ use sp_blockchain::{Error as ClientError, Result as ClientResult};
 use sc_client_api::{
 	backend::RemoteBackend,
 	light::RemoteCallRequest,
-	call_executor::CallExecutor
+	call_executor::CallExecutor,
 };
 use sc_executor::{RuntimeVersion, NativeVersion};
 
@@ -288,6 +288,7 @@ mod tests {
 	use sp_core::H256;
 	use sc_client_api::backend::{Backend, NewBlockState};
 	use crate::in_mem::Backend as InMemBackend;
+	use sc_client_api::ProofProvider;
 	use sp_runtime::traits::BlakeTwo256;
 
 	struct DummyCallExecutor;

substrate/client/src/light/fetcher.rs

@@ -349,6 +349,7 @@ pub mod tests {
 	use sp_runtime::{generic::BlockId, traits::BlakeTwo256};
 	use sp_state_machine::Backend;
 	use super::*;
+	use sc_client_api::{StorageProvider, ProofProvider};
 
 	const CHILD_INFO_1: ChildInfo<'static> = ChildInfo::new_default(b"unique_id_1");
 
@@ -378,7 +379,7 @@ pub mod tests {
 			.and_then(|v| Decode::decode(&mut &v.0[..]).ok()).unwrap();
 		let remote_read_proof = remote_client.read_proof(
 			&remote_block_id,
-			&[well_known_keys::HEAP_PAGES],
+			&mut std::iter::once(well_known_keys::HEAP_PAGES),
 		).unwrap();
 
 		// check remote read proof locally
@@ -426,7 +427,7 @@ pub mod tests {
 			&remote_block_id,
 			b":child_storage:default:child1",
 			CHILD_INFO_1,
-			&[b"key1"],
+			&mut std::iter::once("key1".as_bytes()),
 		).unwrap();
 
 		// check locally