Add a new host function for reporting fatal errors; make WASM backtraces readable when printing out errors (#10741)

* Add a new host function for reporting fatal errors

* Fix one of the wasmtime executor tests

* Have `#[runtime_interface(wasm_only)]` actually mean WASM-only, and not no_std-only

* Print out errors through `Display` instead of `Debug`

* Switch one more trait to require `Error` for its error instead of only `Debug`

* Align to review comments

substrate/utils/frame/benchmarking-cli/src/command.rs

@@ -165,7 +165,7 @@ impl BenchmarkCmd {
 			sp_core::testing::TaskExecutor::new(),
 		)
 		.execute(strategy.into())
-		.map_err(|e| format!("Error getting benchmark list: {:?}", e))?;
+		.map_err(|e| format!("Error getting benchmark list: {}", e))?;
 
 		let (list, storage_info) =
 			<(Vec<BenchmarkList>, Vec<StorageInfo>) as Decode>::decode(&mut &result[..])
@@ -265,7 +265,7 @@ impl BenchmarkCmd {
 					)
 					.execute(strategy.into())
 					.map_err(|e| {
-						format!("Error executing and verifying runtime benchmark: {:?}", e)
+						format!("Error executing and verifying runtime benchmark: {}", e)
 					})?;
 				}
 				// Do one loop of DB tracking.
@@ -290,7 +290,7 @@ impl BenchmarkCmd {
 						sp_core::testing::TaskExecutor::new(),
 					)
 					.execute(strategy.into())
-					.map_err(|e| format!("Error executing runtime benchmark: {:?}", e))?;
+					.map_err(|e| format!("Error executing runtime benchmark: {}", e))?;
 
 					let batch =
 						<std::result::Result<Vec<BenchmarkBatch>, String> as Decode>::decode(
@@ -322,7 +322,7 @@ impl BenchmarkCmd {
 						sp_core::testing::TaskExecutor::new(),
 					)
 					.execute(strategy.into())
-					.map_err(|e| format!("Error executing runtime benchmark: {:?}", e))?;
+					.map_err(|e| format!("Error executing runtime benchmark: {}", e))?;
 
 					let batch =
 						<std::result::Result<Vec<BenchmarkBatch>, String> as Decode>::decode(

substrate/utils/frame/rpc/system/src/lib.rs

@@ -106,7 +106,7 @@ where
 			let nonce = api.account_nonce(&at, account.clone()).map_err(|e| RpcError {
 				code: ErrorCode::ServerError(Error::RuntimeError.into()),
 				message: "Unable to query nonce.".into(),
-				data: Some(format!("{:?}", e).into()),
+				data: Some(e.to_string().into()),
 			})?;
 
 			Ok(adjust_nonce(&*self.pool, account, nonce))
@@ -141,7 +141,7 @@ where
 			let result = api.apply_extrinsic(&at, uxt).map_err(|e| RpcError {
 				code: ErrorCode::ServerError(Error::RuntimeError.into()),
 				message: "Unable to dry run extrinsic.".into(),
-				data: Some(format!("{:?}", e).into()),
+				data: Some(e.to_string().into()),
 			})?;
 
 			Ok(Encode::encode(&result).into())

substrate/utils/frame/try-runtime/cli/src/lib.rs

@@ -707,7 +707,7 @@ pub(crate) fn state_machine_call<Block: BlockT, D: NativeExecutionDispatch + 'st
 		sp_core::testing::TaskExecutor::new(),
 	)
 	.execute(execution.into())
-	.map_err(|e| format!("failed to execute 'TryRuntime_on_runtime_upgrade': {:?}", e))
+	.map_err(|e| format!("failed to execute 'TryRuntime_on_runtime_upgrade': {}", e))
 	.map_err::<sc_cli::Error, _>(Into::into)?;
 
 	Ok((changes, encoded_results))
@@ -748,7 +748,7 @@ pub(crate) fn state_machine_call_with_proof<Block: BlockT, D: NativeExecutionDis
 		sp_core::testing::TaskExecutor::new(),
 	)
 	.execute(execution.into())
-	.map_err(|e| format!("failed to execute {}: {:?}", method, e))
+	.map_err(|e| format!("failed to execute {}: {}", method, e))
 	.map_err::<sc_cli::Error, _>(Into::into)?;
 
 	let proof = proving_backend.extract_proof();