Remove bridges subtree

bridges/modules/grandpa/src/benchmarking.rs

@@ -1,142 +0,0 @@
-// Copyright (C) Parity Technologies (UK) Ltd.
-// This file is part of Parity Bridges Common.
-
-// Parity Bridges Common is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-
-// Parity Bridges Common is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-
-// You should have received a copy of the GNU General Public License
-// along with Parity Bridges Common.  If not, see <http://www.gnu.org/licenses/>.
-
-//! Benchmarks for the GRANDPA Pallet.
-//!
-//! The main dispatchable for the GRANDPA pallet is `submit_finality_proof_ex`. Our benchmarks
-//! are based around `submit_finality_proof`, though - from weight PoV they are the same calls.
-//! There are to main factors which affect finality proof verification:
-//!
-//! 1. The number of `votes-ancestries` in the justification
-//! 2. The number of `pre-commits` in the justification
-//!
-//! Vote ancestries are the headers between (`finality_target`, `head_of_chain`], where
-//! `header_of_chain` is a descendant of `finality_target`.
-//!
-//! Pre-commits are messages which are signed by validators at the head of the chain they think is
-//! the best.
-//!
-//! Consider the following:
-//!
-//!   / B <- C'
-//! A <- B <- C
-//!
-//! The common ancestor of both forks is block A, so this is what GRANDPA will finalize. In order to
-//! verify this we will have vote ancestries of `[B, C, B', C']` and pre-commits `[C, C']`.
-//!
-//! Note that the worst case scenario here would be a justification where each validator has it's
-//! own fork which is `SESSION_LENGTH` blocks long.
-
-use crate::*;
-
-use bp_header_chain::justification::required_justification_precommits;
-use bp_runtime::BasicOperatingMode;
-use bp_test_utils::{
-	accounts, make_justification_for_header, JustificationGeneratorParams, TEST_GRANDPA_ROUND,
-	TEST_GRANDPA_SET_ID,
-};
-use frame_benchmarking::{benchmarks_instance_pallet, whitelisted_caller};
-use frame_system::RawOrigin;
-use sp_consensus_grandpa::AuthorityId;
-use sp_runtime::traits::{One, Zero};
-use sp_std::vec::Vec;
-
-/// The maximum number of vote ancestries to include in a justification.
-///
-/// In practice this would be limited by the session length (number of blocks a single authority set
-/// can produce) of a given chain.
-const MAX_VOTE_ANCESTRIES: u32 = 1000;
-
-// `1..MAX_VOTE_ANCESTRIES` is too large && benchmarks are running for almost 40m (steps=50,
-// repeat=20) on a decent laptop, which is too much. Since we're building linear function here,
-// let's just select some limited subrange for benchmarking.
-const MAX_VOTE_ANCESTRIES_RANGE_BEGIN: u32 = MAX_VOTE_ANCESTRIES / 20;
-const MAX_VOTE_ANCESTRIES_RANGE_END: u32 =
-	MAX_VOTE_ANCESTRIES_RANGE_BEGIN + MAX_VOTE_ANCESTRIES_RANGE_BEGIN;
-
-// the same with validators - if there are too much validators, let's run benchmarks on subrange
-fn precommits_range_end<T: Config<I>, I: 'static>() -> u32 {
-	let max_bridged_authorities = T::BridgedChain::MAX_AUTHORITIES_COUNT;
-	if max_bridged_authorities > 128 {
-		sp_std::cmp::max(128, max_bridged_authorities / 5)
-	} else {
-		max_bridged_authorities
-	};
-	required_justification_precommits(max_bridged_authorities)
-}
-
-/// Prepare header and its justification to submit using `submit_finality_proof`.
-fn prepare_benchmark_data<T: Config<I>, I: 'static>(
-	precommits: u32,
-	ancestors: u32,
-) -> (BridgedHeader<T, I>, GrandpaJustification<BridgedHeader<T, I>>) {
-	// going from precommits to total authorities count
-	let total_authorities_count = (3 * precommits - 1) / 2;
-
-	let authority_list = accounts(total_authorities_count as u16)
-		.iter()
-		.map(|id| (AuthorityId::from(*id), 1))
-		.collect::<Vec<_>>();
-
-	let genesis_header: BridgedHeader<T, I> = bp_test_utils::test_header(Zero::zero());
-	let genesis_hash = genesis_header.hash();
-	let init_data = InitializationData {
-		header: Box::new(genesis_header),
-		authority_list,
-		set_id: TEST_GRANDPA_SET_ID,
-		operating_mode: BasicOperatingMode::Normal,
-	};
-
-	bootstrap_bridge::<T, I>(init_data);
-	assert!(<ImportedHeaders<T, I>>::contains_key(genesis_hash));
-
-	let header: BridgedHeader<T, I> = bp_test_utils::test_header(One::one());
-	let params = JustificationGeneratorParams {
-		header: header.clone(),
-		round: TEST_GRANDPA_ROUND,
-		set_id: TEST_GRANDPA_SET_ID,
-		authorities: accounts(precommits as u16).iter().map(|k| (*k, 1)).collect::<Vec<_>>(),
-		ancestors,
-		forks: 1,
-	};
-	let justification = make_justification_for_header(params);
-	(header, justification)
-}
-
-benchmarks_instance_pallet! {
-	// This is the "gold standard" benchmark for this extrinsic, and it's what should be used to
-	// annotate the weight in the pallet.
-	submit_finality_proof {
-		let p in 1 .. precommits_range_end::<T, I>();
-		let v in MAX_VOTE_ANCESTRIES_RANGE_BEGIN..MAX_VOTE_ANCESTRIES_RANGE_END;
-		let caller: T::AccountId = whitelisted_caller();
-		let (header, justification) = prepare_benchmark_data::<T, I>(p, v);
-	}: submit_finality_proof(RawOrigin::Signed(caller), Box::new(header), justification)
-	verify {
-		let genesis_header: BridgedHeader<T, I> = bp_test_utils::test_header(Zero::zero());
-		let header: BridgedHeader<T, I> = bp_test_utils::test_header(One::one());
-		let expected_hash = header.hash();
-
-		// check that the header#1 has been inserted
-		assert_eq!(<BestFinalized<T, I>>::get().unwrap().1, expected_hash);
-		assert!(<ImportedHeaders<T, I>>::contains_key(expected_hash));
-
-		// check that the header#0 has been pruned
-		assert!(!<ImportedHeaders<T, I>>::contains_key(genesis_header.hash()));
-	}
-
-	impl_benchmark_test_suite!(Pallet, crate::mock::new_test_ext(), crate::mock::TestRuntime)
-}

bridges/modules/grandpa/src/call_ext.rs

@@ -1,426 +0,0 @@
-// Copyright (C) Parity Technologies (UK) Ltd.
-// This file is part of Parity Bridges Common.
-
-// Parity Bridges Common is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-
-// Parity Bridges Common is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-
-// You should have received a copy of the GNU General Public License
-// along with Parity Bridges Common.  If not, see <http://www.gnu.org/licenses/>.
-
-use crate::{
-	weights::WeightInfo, BridgedBlockNumber, BridgedHeader, Config, CurrentAuthoritySet, Error,
-	Pallet,
-};
-use bp_header_chain::{
-	justification::GrandpaJustification, max_expected_submit_finality_proof_arguments_size,
-	ChainWithGrandpa, GrandpaConsensusLogReader,
-};
-use bp_runtime::{BlockNumberOf, OwnedBridgeModule};
-use codec::Encode;
-use frame_support::{dispatch::CallableCallFor, traits::IsSubType, weights::Weight};
-use sp_consensus_grandpa::SetId;
-use sp_runtime::{
-	traits::{Header, Zero},
-	transaction_validity::{InvalidTransaction, TransactionValidity, ValidTransaction},
-	RuntimeDebug, SaturatedConversion,
-};
-
-/// Info about a `SubmitParachainHeads` call which tries to update a single parachain.
-#[derive(Copy, Clone, PartialEq, RuntimeDebug)]
-pub struct SubmitFinalityProofInfo<N> {
-	/// Number of the finality target.
-	pub block_number: N,
-	/// An identifier of the validators set that has signed the submitted justification.
-	/// It might be `None` if deprecated version of the `submit_finality_proof` is used.
-	pub current_set_id: Option<SetId>,
-	/// Extra weight that we assume is included in the call.
-	///
-	/// We have some assumptions about headers and justifications of the bridged chain.
-	/// We know that if our assumptions are correct, then the call must not have the
-	/// weight above some limit. The fee paid for weight above that limit, is never refunded.
-	pub extra_weight: Weight,
-	/// Extra size (in bytes) that we assume are included in the call.
-	///
-	/// We have some assumptions about headers and justifications of the bridged chain.
-	/// We know that if our assumptions are correct, then the call must not have the
-	/// weight above some limit. The fee paid for bytes above that limit, is never refunded.
-	pub extra_size: u32,
-}
-
-impl<N> SubmitFinalityProofInfo<N> {
-	/// Returns `true` if call size/weight is below our estimations for regular calls.
-	pub fn fits_limits(&self) -> bool {
-		self.extra_weight.is_zero() && self.extra_size.is_zero()
-	}
-}
-
-/// Helper struct that provides methods for working with the `SubmitFinalityProof` call.
-pub struct SubmitFinalityProofHelper<T: Config<I>, I: 'static> {
-	_phantom_data: sp_std::marker::PhantomData<(T, I)>,
-}
-
-impl<T: Config<I>, I: 'static> SubmitFinalityProofHelper<T, I> {
-	/// Check that the GRANDPA head provided by the `SubmitFinalityProof` is better than the best
-	/// one we know. Additionally, checks if `current_set_id` matches the current authority set
-	/// id, if specified.
-	pub fn check_obsolete(
-		finality_target: BlockNumberOf<T::BridgedChain>,
-		current_set_id: Option<SetId>,
-	) -> Result<(), Error<T, I>> {
-		let best_finalized = crate::BestFinalized::<T, I>::get().ok_or_else(|| {
-			log::trace!(
-				target: crate::LOG_TARGET,
-				"Cannot finalize header {:?} because pallet is not yet initialized",
-				finality_target,
-			);
-			<Error<T, I>>::NotInitialized
-		})?;
-
-		if best_finalized.number() >= finality_target {
-			log::trace!(
-				target: crate::LOG_TARGET,
-				"Cannot finalize obsolete header: bundled {:?}, best {:?}",
-				finality_target,
-				best_finalized,
-			);
-
-			return Err(Error::<T, I>::OldHeader)
-		}
-
-		if let Some(current_set_id) = current_set_id {
-			let actual_set_id = <CurrentAuthoritySet<T, I>>::get().set_id;
-			if current_set_id != actual_set_id {
-				log::trace!(
-					target: crate::LOG_TARGET,
-					"Cannot finalize header signed by unknown authority set: bundled {:?}, best {:?}",
-					current_set_id,
-					actual_set_id,
-				);
-
-				return Err(Error::<T, I>::InvalidAuthoritySetId)
-			}
-		}
-
-		Ok(())
-	}
-
-	/// Check if the `SubmitFinalityProof` was successfully executed.
-	pub fn was_successful(finality_target: BlockNumberOf<T::BridgedChain>) -> bool {
-		match crate::BestFinalized::<T, I>::get() {
-			Some(best_finalized) => best_finalized.number() == finality_target,
-			None => false,
-		}
-	}
-}
-
-/// Trait representing a call that is a sub type of this pallet's call.
-pub trait CallSubType<T: Config<I, RuntimeCall = Self>, I: 'static>:
-	IsSubType<CallableCallFor<Pallet<T, I>, T>>
-{
-	/// Extract finality proof info from a runtime call.
-	fn submit_finality_proof_info(
-		&self,
-	) -> Option<SubmitFinalityProofInfo<BridgedBlockNumber<T, I>>> {
-		if let Some(crate::Call::<T, I>::submit_finality_proof { finality_target, justification }) =
-			self.is_sub_type()
-		{
-			return Some(submit_finality_proof_info_from_args::<T, I>(
-				finality_target,
-				justification,
-				None,
-			))
-		} else if let Some(crate::Call::<T, I>::submit_finality_proof_ex {
-			finality_target,
-			justification,
-			current_set_id,
-		}) = self.is_sub_type()
-		{
-			return Some(submit_finality_proof_info_from_args::<T, I>(
-				finality_target,
-				justification,
-				Some(*current_set_id),
-			))
-		}
-
-		None
-	}
-
-	/// Validate Grandpa headers in order to avoid "mining" transactions that provide outdated
-	/// bridged chain headers. Without this validation, even honest relayers may lose their funds
-	/// if there are multiple relays running and submitting the same information.
-	fn check_obsolete_submit_finality_proof(&self) -> TransactionValidity
-	where
-		Self: Sized,
-	{
-		let finality_target = match self.submit_finality_proof_info() {
-			Some(finality_proof) => finality_proof,
-			_ => return Ok(ValidTransaction::default()),
-		};
-
-		if Pallet::<T, I>::ensure_not_halted().is_err() {
-			return InvalidTransaction::Call.into()
-		}
-
-		match SubmitFinalityProofHelper::<T, I>::check_obsolete(
-			finality_target.block_number,
-			finality_target.current_set_id,
-		) {
-			Ok(_) => Ok(ValidTransaction::default()),
-			Err(Error::<T, I>::OldHeader) => InvalidTransaction::Stale.into(),
-			Err(_) => InvalidTransaction::Call.into(),
-		}
-	}
-}
-
-impl<T: Config<I>, I: 'static> CallSubType<T, I> for T::RuntimeCall where
-	T::RuntimeCall: IsSubType<CallableCallFor<Pallet<T, I>, T>>
-{
-}
-
-/// Extract finality proof info from the submitted header and justification.
-pub(crate) fn submit_finality_proof_info_from_args<T: Config<I>, I: 'static>(
-	finality_target: &BridgedHeader<T, I>,
-	justification: &GrandpaJustification<BridgedHeader<T, I>>,
-	current_set_id: Option<SetId>,
-) -> SubmitFinalityProofInfo<BridgedBlockNumber<T, I>> {
-	let block_number = *finality_target.number();
-
-	// the `submit_finality_proof` call will reject justifications with invalid, duplicate,
-	// unknown and extra signatures. It'll also reject justifications with less than necessary
-	// signatures. So we do not care about extra weight because of additional signatures here.
-	let precommits_len = justification.commit.precommits.len().saturated_into();
-	let required_precommits = precommits_len;
-
-	// We do care about extra weight because of more-than-expected headers in the votes
-	// ancestries. But we have problems computing extra weight for additional headers (weight of
-	// additional header is too small, so that our benchmarks aren't detecting that). So if there
-	// are more than expected headers in votes ancestries, we will treat the whole call weight
-	// as an extra weight.
-	let votes_ancestries_len = justification.votes_ancestries.len().saturated_into();
-	let extra_weight =
-		if votes_ancestries_len > T::BridgedChain::REASONABLE_HEADERS_IN_JUSTIFICATION_ANCESTRY {
-			T::WeightInfo::submit_finality_proof(precommits_len, votes_ancestries_len)
-		} else {
-			Weight::zero()
-		};
-
-	// check if the `finality_target` is a mandatory header. If so, we are ready to refund larger
-	// size
-	let is_mandatory_finality_target =
-		GrandpaConsensusLogReader::<BridgedBlockNumber<T, I>>::find_scheduled_change(
-			finality_target.digest(),
-		)
-		.is_some();
-
-	// we can estimate extra call size easily, without any additional significant overhead
-	let actual_call_size: u32 = finality_target
-		.encoded_size()
-		.saturating_add(justification.encoded_size())
-		.saturated_into();
-	let max_expected_call_size = max_expected_submit_finality_proof_arguments_size::<T::BridgedChain>(
-		is_mandatory_finality_target,
-		required_precommits,
-	);
-	let extra_size = actual_call_size.saturating_sub(max_expected_call_size);
-
-	SubmitFinalityProofInfo { block_number, current_set_id, extra_weight, extra_size }
-}
-
-#[cfg(test)]
-mod tests {
-	use crate::{
-		call_ext::CallSubType,
-		mock::{run_test, test_header, RuntimeCall, TestBridgedChain, TestNumber, TestRuntime},
-		BestFinalized, Config, CurrentAuthoritySet, PalletOperatingMode, StoredAuthoritySet,
-		SubmitFinalityProofInfo, WeightInfo,
-	};
-	use bp_header_chain::ChainWithGrandpa;
-	use bp_runtime::{BasicOperatingMode, HeaderId};
-	use bp_test_utils::{
-		make_default_justification, make_justification_for_header, JustificationGeneratorParams,
-		TEST_GRANDPA_SET_ID,
-	};
-	use frame_support::weights::Weight;
-	use sp_runtime::{testing::DigestItem, traits::Header as _, SaturatedConversion};
-
-	fn validate_block_submit(num: TestNumber) -> bool {
-		let bridge_grandpa_call = crate::Call::<TestRuntime, ()>::submit_finality_proof_ex {
-			finality_target: Box::new(test_header(num)),
-			justification: make_default_justification(&test_header(num)),
-			// not initialized => zero
-			current_set_id: 0,
-		};
-		RuntimeCall::check_obsolete_submit_finality_proof(&RuntimeCall::Grandpa(
-			bridge_grandpa_call,
-		))
-		.is_ok()
-	}
-
-	fn sync_to_header_10() {
-		let header10_hash = sp_core::H256::default();
-		BestFinalized::<TestRuntime, ()>::put(HeaderId(10, header10_hash));
-	}
-
-	#[test]
-	fn extension_rejects_obsolete_header() {
-		run_test(|| {
-			// when current best finalized is #10 and we're trying to import header#5 => tx is
-			// rejected
-			sync_to_header_10();
-			assert!(!validate_block_submit(5));
-		});
-	}
-
-	#[test]
-	fn extension_rejects_same_header() {
-		run_test(|| {
-			// when current best finalized is #10 and we're trying to import header#10 => tx is
-			// rejected
-			sync_to_header_10();
-			assert!(!validate_block_submit(10));
-		});
-	}
-
-	#[test]
-	fn extension_rejects_new_header_if_pallet_is_halted() {
-		run_test(|| {
-			// when pallet is halted => tx is rejected
-			sync_to_header_10();
-			PalletOperatingMode::<TestRuntime, ()>::put(BasicOperatingMode::Halted);
-
-			assert!(!validate_block_submit(15));
-		});
-	}
-
-	#[test]
-	fn extension_rejects_new_header_if_set_id_is_invalid() {
-		run_test(|| {
-			// when set id is different from the passed one => tx is rejected
-			sync_to_header_10();
-			let next_set = StoredAuthoritySet::<TestRuntime, ()>::try_new(vec![], 0x42).unwrap();
-			CurrentAuthoritySet::<TestRuntime, ()>::put(next_set);
-
-			assert!(!validate_block_submit(15));
-		});
-	}
-
-	#[test]
-	fn extension_accepts_new_header() {
-		run_test(|| {
-			// when current best finalized is #10 and we're trying to import header#15 => tx is
-			// accepted
-			sync_to_header_10();
-			assert!(validate_block_submit(15));
-		});
-	}
-
-	#[test]
-	fn submit_finality_proof_info_is_parsed() {
-		// when `submit_finality_proof` is used, `current_set_id` is set to `None`
-		let deprecated_call =
-			RuntimeCall::Grandpa(crate::Call::<TestRuntime, ()>::submit_finality_proof {
-				finality_target: Box::new(test_header(42)),
-				justification: make_default_justification(&test_header(42)),
-			});
-		assert_eq!(
-			deprecated_call.submit_finality_proof_info(),
-			Some(SubmitFinalityProofInfo {
-				block_number: 42,
-				current_set_id: None,
-				extra_weight: Weight::zero(),
-				extra_size: 0,
-			})
-		);
-
-		// when `submit_finality_proof_ex` is used, `current_set_id` is set to `Some`
-		let deprecated_call =
-			RuntimeCall::Grandpa(crate::Call::<TestRuntime, ()>::submit_finality_proof_ex {
-				finality_target: Box::new(test_header(42)),
-				justification: make_default_justification(&test_header(42)),
-				current_set_id: 777,
-			});
-		assert_eq!(
-			deprecated_call.submit_finality_proof_info(),
-			Some(SubmitFinalityProofInfo {
-				block_number: 42,
-				current_set_id: Some(777),
-				extra_weight: Weight::zero(),
-				extra_size: 0,
-			})
-		);
-	}
-
-	#[test]
-	fn extension_returns_correct_extra_size_if_call_arguments_are_too_large() {
-		// when call arguments are below our limit => no refund
-		let small_finality_target = test_header(1);
-		let justification_params = JustificationGeneratorParams {
-			header: small_finality_target.clone(),
-			..Default::default()
-		};
-		let small_justification = make_justification_for_header(justification_params);
-		let small_call = RuntimeCall::Grandpa(crate::Call::submit_finality_proof_ex {
-			finality_target: Box::new(small_finality_target),
-			justification: small_justification,
-			current_set_id: TEST_GRANDPA_SET_ID,
-		});
-		assert_eq!(small_call.submit_finality_proof_info().unwrap().extra_size, 0);
-
-		// when call arguments are too large => partial refund
-		let mut large_finality_target = test_header(1);
-		large_finality_target
-			.digest_mut()
-			.push(DigestItem::Other(vec![42u8; 1024 * 1024]));
-		let justification_params = JustificationGeneratorParams {
-			header: large_finality_target.clone(),
-			..Default::default()
-		};
-		let large_justification = make_justification_for_header(justification_params);
-		let large_call = RuntimeCall::Grandpa(crate::Call::submit_finality_proof_ex {
-			finality_target: Box::new(large_finality_target),
-			justification: large_justification,
-			current_set_id: TEST_GRANDPA_SET_ID,
-		});
-		assert_ne!(large_call.submit_finality_proof_info().unwrap().extra_size, 0);
-	}
-
-	#[test]
-	fn extension_returns_correct_extra_weight_if_there_are_too_many_headers_in_votes_ancestry() {
-		let finality_target = test_header(1);
-		let mut justification_params = JustificationGeneratorParams {
-			header: finality_target.clone(),
-			ancestors: TestBridgedChain::REASONABLE_HEADERS_IN_JUSTIFICATION_ANCESTRY,
-			..Default::default()
-		};
-
-		// when there are `REASONABLE_HEADERS_IN_JUSTIFICATION_ANCESTRY` headers => no refund
-		let justification = make_justification_for_header(justification_params.clone());
-		let call = RuntimeCall::Grandpa(crate::Call::submit_finality_proof_ex {
-			finality_target: Box::new(finality_target.clone()),
-			justification,
-			current_set_id: TEST_GRANDPA_SET_ID,
-		});
-		assert_eq!(call.submit_finality_proof_info().unwrap().extra_weight, Weight::zero());
-
-		// when there are `REASONABLE_HEADERS_IN_JUSTIFICATION_ANCESTRY + 1` headers => full refund
-		justification_params.ancestors += 1;
-		let justification = make_justification_for_header(justification_params);
-		let call_weight = <TestRuntime as Config>::WeightInfo::submit_finality_proof(
-			justification.commit.precommits.len().saturated_into(),
-			justification.votes_ancestries.len().saturated_into(),
-		);
-		let call = RuntimeCall::Grandpa(crate::Call::submit_finality_proof_ex {
-			finality_target: Box::new(finality_target),
-			justification,
-			current_set_id: TEST_GRANDPA_SET_ID,
-		});
-		assert_eq!(call.submit_finality_proof_info().unwrap().extra_weight, call_weight);
-	}
-}

bridges/modules/grandpa/src/mock.rs

@@ -1,112 +0,0 @@
-// Copyright (C) Parity Technologies (UK) Ltd.
-// This file is part of Parity Bridges Common.
-
-// Parity Bridges Common is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-
-// Parity Bridges Common is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-
-// You should have received a copy of the GNU General Public License
-// along with Parity Bridges Common.  If not, see <http://www.gnu.org/licenses/>.
-
-// From construct_runtime macro
-#![allow(clippy::from_over_into)]
-
-use bp_header_chain::ChainWithGrandpa;
-use bp_runtime::{Chain, ChainId};
-use frame_support::{
-	construct_runtime, derive_impl, parameter_types, traits::Hooks, weights::Weight,
-};
-use sp_core::sr25519::Signature;
-
-pub type AccountId = u64;
-pub type TestHeader = sp_runtime::testing::Header;
-pub type TestNumber = u64;
-
-type Block = frame_system::mocking::MockBlock<TestRuntime>;
-
-pub const MAX_BRIDGED_AUTHORITIES: u32 = 5;
-
-use crate as grandpa;
-
-construct_runtime! {
-	pub enum TestRuntime
-	{
-		System: frame_system::{Pallet, Call, Config<T>, Storage, Event<T>},
-		Grandpa: grandpa::{Pallet, Call, Event<T>},
-	}
-}
-
-#[derive_impl(frame_system::config_preludes::TestDefaultConfig)]
-impl frame_system::Config for TestRuntime {
-	type Block = Block;
-}
-
-parameter_types! {
-	pub const MaxFreeMandatoryHeadersPerBlock: u32 = 2;
-	pub const HeadersToKeep: u32 = 5;
-}
-
-impl grandpa::Config for TestRuntime {
-	type RuntimeEvent = RuntimeEvent;
-	type BridgedChain = TestBridgedChain;
-	type MaxFreeMandatoryHeadersPerBlock = MaxFreeMandatoryHeadersPerBlock;
-	type HeadersToKeep = HeadersToKeep;
-	type WeightInfo = ();
-}
-
-#[derive(Debug)]
-pub struct TestBridgedChain;
-
-impl Chain for TestBridgedChain {
-	const ID: ChainId = *b"tbch";
-
-	type BlockNumber = frame_system::pallet_prelude::BlockNumberFor<TestRuntime>;
-	type Hash = <TestRuntime as frame_system::Config>::Hash;
-	type Hasher = <TestRuntime as frame_system::Config>::Hashing;
-	type Header = TestHeader;
-
-	type AccountId = AccountId;
-	type Balance = u64;
-	type Nonce = u64;
-	type Signature = Signature;
-
-	fn max_extrinsic_size() -> u32 {
-		unreachable!()
-	}
-	fn max_extrinsic_weight() -> Weight {
-		unreachable!()
-	}
-}
-
-impl ChainWithGrandpa for TestBridgedChain {
-	const WITH_CHAIN_GRANDPA_PALLET_NAME: &'static str = "";
-	const MAX_AUTHORITIES_COUNT: u32 = MAX_BRIDGED_AUTHORITIES;
-	const REASONABLE_HEADERS_IN_JUSTIFICATION_ANCESTRY: u32 = 8;
-	const MAX_MANDATORY_HEADER_SIZE: u32 = 256;
-	const AVERAGE_HEADER_SIZE: u32 = 64;
-}
-
-/// Return test externalities to use in tests.
-pub fn new_test_ext() -> sp_io::TestExternalities {
-	sp_io::TestExternalities::new(Default::default())
-}
-
-/// Return test within default test externalities context.
-pub fn run_test<T>(test: impl FnOnce() -> T) -> T {
-	new_test_ext().execute_with(|| {
-		let _ = Grandpa::on_initialize(0);
-		test()
-	})
-}
-
-/// Return test header with given number.
-pub fn test_header(num: TestNumber) -> TestHeader {
-	// We wrap the call to avoid explicit type annotations in our tests
-	bp_test_utils::test_header(num)
-}

bridges/modules/grandpa/src/storage_types.rs

@@ -1,136 +0,0 @@
-// Copyright (C) Parity Technologies (UK) Ltd.
-// This file is part of Parity Bridges Common.
-
-// Parity Bridges Common is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-
-// Parity Bridges Common is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-
-// You should have received a copy of the GNU General Public License
-// along with Parity Bridges Common.  If not, see <http://www.gnu.org/licenses/>.
-
-//! Wrappers for public types that are implementing `MaxEncodedLen`
-
-use crate::{Config, Error};
-
-use bp_header_chain::{AuthoritySet, ChainWithGrandpa};
-use codec::{Decode, Encode, MaxEncodedLen};
-use frame_support::{traits::Get, BoundedVec, CloneNoBound, RuntimeDebugNoBound};
-use scale_info::TypeInfo;
-use sp_consensus_grandpa::{AuthorityId, AuthorityList, AuthorityWeight, SetId};
-use sp_std::marker::PhantomData;
-
-/// A bounded list of Grandpa authorities with associated weights.
-pub type StoredAuthorityList<MaxBridgedAuthorities> =
-	BoundedVec<(AuthorityId, AuthorityWeight), MaxBridgedAuthorities>;
-
-/// Adapter for using `T::BridgedChain::MAX_BRIDGED_AUTHORITIES` in `BoundedVec`.
-pub struct StoredAuthorityListLimit<T, I>(PhantomData<(T, I)>);
-
-impl<T: Config<I>, I: 'static> Get<u32> for StoredAuthorityListLimit<T, I> {
-	fn get() -> u32 {
-		T::BridgedChain::MAX_AUTHORITIES_COUNT
-	}
-}
-
-/// A bounded GRANDPA Authority List and ID.
-#[derive(CloneNoBound, Decode, Encode, Eq, TypeInfo, MaxEncodedLen, RuntimeDebugNoBound)]
-#[scale_info(skip_type_params(T, I))]
-pub struct StoredAuthoritySet<T: Config<I>, I: 'static> {
-	/// List of GRANDPA authorities for the current round.
-	pub authorities: StoredAuthorityList<StoredAuthorityListLimit<T, I>>,
-	/// Monotonic identifier of the current GRANDPA authority set.
-	pub set_id: SetId,
-}
-
-impl<T: Config<I>, I: 'static> StoredAuthoritySet<T, I> {
-	/// Try to create a new bounded GRANDPA Authority Set from unbounded list.
-	///
-	/// Returns error if number of authorities in the provided list is too large.
-	pub fn try_new(authorities: AuthorityList, set_id: SetId) -> Result<Self, Error<T, I>> {
-		Ok(Self {
-			authorities: TryFrom::try_from(authorities)
-				.map_err(|_| Error::TooManyAuthoritiesInSet)?,
-			set_id,
-		})
-	}
-
-	/// Returns number of bytes that may be subtracted from the PoV component of
-	/// `submit_finality_proof` call, because the actual authorities set is smaller than the maximal
-	/// configured.
-	///
-	/// Maximal authorities set size is configured by the `MaxBridgedAuthorities` constant from
-	/// the pallet configuration. The PoV of the call includes the size of maximal authorities
-	/// count. If the actual size is smaller, we may subtract extra bytes from this component.
-	pub fn unused_proof_size(&self) -> u64 {
-		// we can only safely estimate bytes that are occupied by the authority data itself. We have
-		// no means here to compute PoV bytes, occupied by extra trie nodes or extra bytes in the
-		// whole set encoding
-		let single_authority_max_encoded_len =
-			<(AuthorityId, AuthorityWeight)>::max_encoded_len() as u64;
-		let extra_authorities =
-			T::BridgedChain::MAX_AUTHORITIES_COUNT.saturating_sub(self.authorities.len() as _);
-		single_authority_max_encoded_len.saturating_mul(extra_authorities as u64)
-	}
-}
-
-impl<T: Config<I>, I: 'static> PartialEq for StoredAuthoritySet<T, I> {
-	fn eq(&self, other: &Self) -> bool {
-		self.set_id == other.set_id && self.authorities == other.authorities
-	}
-}
-
-impl<T: Config<I>, I: 'static> Default for StoredAuthoritySet<T, I> {
-	fn default() -> Self {
-		StoredAuthoritySet { authorities: BoundedVec::default(), set_id: 0 }
-	}
-}
-
-impl<T: Config<I>, I: 'static> From<StoredAuthoritySet<T, I>> for AuthoritySet {
-	fn from(t: StoredAuthoritySet<T, I>) -> Self {
-		AuthoritySet { authorities: t.authorities.into(), set_id: t.set_id }
-	}
-}
-
-#[cfg(test)]
-mod tests {
-	use crate::mock::{TestRuntime, MAX_BRIDGED_AUTHORITIES};
-	use bp_test_utils::authority_list;
-
-	type StoredAuthoritySet = super::StoredAuthoritySet<TestRuntime, ()>;
-
-	#[test]
-	fn unused_proof_size_works() {
-		let authority_entry = authority_list().pop().unwrap();
-
-		// when we have exactly `MaxBridgedAuthorities` authorities
-		assert_eq!(
-			StoredAuthoritySet::try_new(
-				vec![authority_entry.clone(); MAX_BRIDGED_AUTHORITIES as usize],
-				0,
-			)
-			.unwrap()
-			.unused_proof_size(),
-			0,
-		);
-
-		// when we have less than `MaxBridgedAuthorities` authorities
-		assert_eq!(
-			StoredAuthoritySet::try_new(
-				vec![authority_entry; MAX_BRIDGED_AUTHORITIES as usize - 1],
-				0,
-			)
-			.unwrap()
-			.unused_proof_size(),
-			40,
-		);
-
-		// and we can't have more than `MaxBridgedAuthorities` authorities in the bounded vec, so
-		// no test for this case
-	}
-}

bridges/modules/grandpa/src/weights.rs

@@ -1,167 +0,0 @@
-// Copyright (C) Parity Technologies (UK) Ltd.
-// This file is part of Parity Bridges Common.
-
-// Parity Bridges Common is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-
-// Parity Bridges Common is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-
-// You should have received a copy of the GNU General Public License
-// along with Parity Bridges Common.  If not, see <http://www.gnu.org/licenses/>.
-
-//! Autogenerated weights for pallet_bridge_grandpa
-//!
-//! THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI VERSION 4.0.0-dev
-//! DATE: 2023-03-02, STEPS: `50`, REPEAT: `20`, LOW RANGE: `[]`, HIGH RANGE: `[]`
-//! WORST CASE MAP SIZE: `1000000`
-//! HOSTNAME: `covid`, CPU: `11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz`
-//! EXECUTION: Some(Wasm), WASM-EXECUTION: Compiled, CHAIN: Some("dev"), DB CACHE: 1024
-
-// Executed Command:
-// target/release/unknown-bridge-node
-// benchmark
-// pallet
-// --chain=dev
-// --steps=50
-// --repeat=20
-// --pallet=pallet_bridge_grandpa
-// --extrinsic=*
-// --execution=wasm
-// --wasm-execution=Compiled
-// --heap-pages=4096
-// --output=./modules/grandpa/src/weights.rs
-// --template=./.maintain/bridge-weight-template.hbs
-
-#![allow(clippy::all)]
-#![allow(unused_parens)]
-#![allow(unused_imports)]
-#![allow(missing_docs)]
-
-use frame_support::{
-	traits::Get,
-	weights::{constants::RocksDbWeight, Weight},
-};
-use sp_std::marker::PhantomData;
-
-/// Weight functions needed for pallet_bridge_grandpa.
-pub trait WeightInfo {
-	fn submit_finality_proof(p: u32, v: u32) -> Weight;
-}
-
-/// Weights for `pallet_bridge_grandpa` that are generated using one of the Bridge testnets.
-///
-/// Those weights are test only and must never be used in production.
-pub struct BridgeWeight<T>(PhantomData<T>);
-impl<T: frame_system::Config> WeightInfo for BridgeWeight<T> {
-	/// Storage: BridgeUnknownGrandpa PalletOperatingMode (r:1 w:0)
-	///
-	/// Proof: BridgeUnknownGrandpa PalletOperatingMode (max_values: Some(1), max_size: Some(1),
-	/// added: 496, mode: MaxEncodedLen)
-	///
-	/// Storage: BridgeUnknownGrandpa RequestCount (r:1 w:1)
-	///
-	/// Proof: BridgeUnknownGrandpa RequestCount (max_values: Some(1), max_size: Some(4), added:
-	/// 499, mode: MaxEncodedLen)
-	///
-	/// Storage: BridgeUnknownGrandpa BestFinalized (r:1 w:1)
-	///
-	/// Proof: BridgeUnknownGrandpa BestFinalized (max_values: Some(1), max_size: Some(36), added:
-	/// 531, mode: MaxEncodedLen)
-	///
-	/// Storage: BridgeUnknownGrandpa CurrentAuthoritySet (r:1 w:0)
-	///
-	/// Proof: BridgeUnknownGrandpa CurrentAuthoritySet (max_values: Some(1), max_size: Some(209),
-	/// added: 704, mode: MaxEncodedLen)
-	///
-	/// Storage: BridgeUnknownGrandpa ImportedHashesPointer (r:1 w:1)
-	///
-	/// Proof: BridgeUnknownGrandpa ImportedHashesPointer (max_values: Some(1), max_size: Some(4),
-	/// added: 499, mode: MaxEncodedLen)
-	///
-	/// Storage: BridgeUnknownGrandpa ImportedHashes (r:1 w:1)
-	///
-	/// Proof: BridgeUnknownGrandpa ImportedHashes (max_values: Some(14400), max_size: Some(36),
-	/// added: 2016, mode: MaxEncodedLen)
-	///
-	/// Storage: BridgeUnknownGrandpa ImportedHeaders (r:0 w:2)
-	///
-	/// Proof: BridgeUnknownGrandpa ImportedHeaders (max_values: Some(14400), max_size: Some(68),
-	/// added: 2048, mode: MaxEncodedLen)
-	///
-	/// The range of component `p` is `[1, 4]`.
-	///
-	/// The range of component `v` is `[50, 100]`.
-	fn submit_finality_proof(p: u32, v: u32) -> Weight {
-		// Proof Size summary in bytes:
-		//  Measured:  `394 + p * (60 ±0)`
-		//  Estimated: `4745`
-		// Minimum execution time: 228_072 nanoseconds.
-		Weight::from_parts(57_853_228, 4745)
-			// Standard Error: 149_421
-			.saturating_add(Weight::from_parts(36_708_702, 0).saturating_mul(p.into()))
-			// Standard Error: 10_625
-			.saturating_add(Weight::from_parts(1_469_032, 0).saturating_mul(v.into()))
-			.saturating_add(T::DbWeight::get().reads(6_u64))
-			.saturating_add(T::DbWeight::get().writes(6_u64))
-	}
-}
-
-// For backwards compatibility and tests
-impl WeightInfo for () {
-	/// Storage: BridgeUnknownGrandpa PalletOperatingMode (r:1 w:0)
-	///
-	/// Proof: BridgeUnknownGrandpa PalletOperatingMode (max_values: Some(1), max_size: Some(1),
-	/// added: 496, mode: MaxEncodedLen)
-	///
-	/// Storage: BridgeUnknownGrandpa RequestCount (r:1 w:1)
-	///
-	/// Proof: BridgeUnknownGrandpa RequestCount (max_values: Some(1), max_size: Some(4), added:
-	/// 499, mode: MaxEncodedLen)
-	///
-	/// Storage: BridgeUnknownGrandpa BestFinalized (r:1 w:1)
-	///
-	/// Proof: BridgeUnknownGrandpa BestFinalized (max_values: Some(1), max_size: Some(36), added:
-	/// 531, mode: MaxEncodedLen)
-	///
-	/// Storage: BridgeUnknownGrandpa CurrentAuthoritySet (r:1 w:0)
-	///
-	/// Proof: BridgeUnknownGrandpa CurrentAuthoritySet (max_values: Some(1), max_size: Some(209),
-	/// added: 704, mode: MaxEncodedLen)
-	///
-	/// Storage: BridgeUnknownGrandpa ImportedHashesPointer (r:1 w:1)
-	///
-	/// Proof: BridgeUnknownGrandpa ImportedHashesPointer (max_values: Some(1), max_size: Some(4),
-	/// added: 499, mode: MaxEncodedLen)
-	///
-	/// Storage: BridgeUnknownGrandpa ImportedHashes (r:1 w:1)
-	///
-	/// Proof: BridgeUnknownGrandpa ImportedHashes (max_values: Some(14400), max_size: Some(36),
-	/// added: 2016, mode: MaxEncodedLen)
-	///
-	/// Storage: BridgeUnknownGrandpa ImportedHeaders (r:0 w:2)
-	///
-	/// Proof: BridgeUnknownGrandpa ImportedHeaders (max_values: Some(14400), max_size: Some(68),
-	/// added: 2048, mode: MaxEncodedLen)
-	///
-	/// The range of component `p` is `[1, 4]`.
-	///
-	/// The range of component `v` is `[50, 100]`.
-	fn submit_finality_proof(p: u32, v: u32) -> Weight {
-		// Proof Size summary in bytes:
-		//  Measured:  `394 + p * (60 ±0)`
-		//  Estimated: `4745`
-		// Minimum execution time: 228_072 nanoseconds.
-		Weight::from_parts(57_853_228, 4745)
-			// Standard Error: 149_421
-			.saturating_add(Weight::from_parts(36_708_702, 0).saturating_mul(p.into()))
-			// Standard Error: 10_625
-			.saturating_add(Weight::from_parts(1_469_032, 0).saturating_mul(v.into()))
-			.saturating_add(RocksDbWeight::get().reads(6_u64))
-			.saturating_add(RocksDbWeight::get().writes(6_u64))
-	}
-}