pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-17 06:41:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

service: fix RPC unsafe exposed address detection (#6070)

Browse Source
This commit is contained in:
André Silva
2020-05-19 02:16:48 +01:00
committed by GitHub
parent 1d8ddd7a98
commit 9a4e23d594
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/client/service/src/lib.rs
+4 -4
View File
@@ -553,8 +553,8 @@ fn start_rpc_servers<H: FnMut(sc_rpc::DenyUnsafe) -> sc_rpc_server::RpcHandler<s
}) })
} }
fn deny_unsafe(addr: &Option<SocketAddr>, methods: &RpcMethods) -> sc_rpc::DenyUnsafe { fn deny_unsafe(addr: &SocketAddr, methods: &RpcMethods) -> sc_rpc::DenyUnsafe {
let is_exposed_addr = addr.map(|x| x.ip().is_loopback()).unwrap_or(false); let is_exposed_addr = !addr.ip().is_loopback();
match (is_exposed_addr, methods) { match (is_exposed_addr, methods) {
| (_, RpcMethods::Unsafe) | (_, RpcMethods::Unsafe)
| (false, RpcMethods::Auto) => sc_rpc::DenyUnsafe::No, | (false, RpcMethods::Auto) => sc_rpc::DenyUnsafe::No,
@@ -568,7 +568,7 @@ fn start_rpc_servers<H: FnMut(sc_rpc::DenyUnsafe) -> sc_rpc_server::RpcHandler<s
|address| sc_rpc_server::start_http( |address| sc_rpc_server::start_http(
address, address,
config.rpc_cors.as_ref(), config.rpc_cors.as_ref(),
gen_handler(deny_unsafe(&config.rpc_http, &config.rpc_methods)), gen_handler(deny_unsafe(&address, &config.rpc_methods)),
), ),
)?.map(|s| waiting::HttpServer(Some(s))), )?.map(|s| waiting::HttpServer(Some(s))),
maybe_start_server( maybe_start_server(
@@ -577,7 +577,7 @@ fn start_rpc_servers<H: FnMut(sc_rpc::DenyUnsafe) -> sc_rpc_server::RpcHandler<s
address, address,
config.rpc_ws_max_connections, config.rpc_ws_max_connections,
config.rpc_cors.as_ref(), config.rpc_cors.as_ref(),
gen_handler(deny_unsafe(&config.rpc_ws, &config.rpc_methods)), gen_handler(deny_unsafe(&address, &config.rpc_methods)),
), ),
)?.map(|s| waiting::WsServer(Some(s))), )?.map(|s| waiting::WsServer(Some(s))),
))) )))