PoV Reclaim (Clawback) Node Side (#1462)

This PR provides the infrastructure for the pov-reclaim mechanism
discussed in #209. The goal is to provide the current proof size to the
runtime so it can be used to reclaim storage weight.

## New Host Function
- A new host function is provided
[here](https://github.com/skunert/polkadot-sdk/blob/5b317fda3be205f4136f10d4490387ccd4f9765d/cumulus/primitives/pov-reclaim/src/lib.rs#L23).
It returns the size of the current proof size to the runtime. If
recording is not enabled, it returns 0.

## Implementation Overview
- Implement option to enable proof recording during import in the
client. This is currently enabled for `polkadot-parachain`,
`parachain-template` and the cumulus test node.
- Make the proof recorder ready for no-std. It was previously only
enabled for std environments, but we need to record the proof size in
`validate_block` too.
- Provide a recorder implementation that only the records the size of
incoming nodes and does not store the nodes itself.
- Fix benchmarks that were broken by async backing changes
- Provide new externalities extension that is registered by default if
proof recording is enabled.
- I think we should discuss the naming, pov-reclaim was more intuitive
to me, but we could also go with clawback like in the issue.

## Impact of proof recording during import
With proof recording: 6.3058 Kelem/s
Without proof recording: 6.3427 Kelem/s

The measured impact on the importing performance is quite low on my
machine using the block import benchmark. With proof recording I am
seeing a performance hit of 0.585%.

---------

Co-authored-by: command-bot <>
Co-authored-by: Davide Galassi <davxy@datawok.net>
Co-authored-by: Bastian Köcher <git@kchr.de>
This commit is contained in:
Sebastian Kunert
2023-11-30 15:56:34 +01:00
committed by GitHub
parent 64361ac19a
commit 9a650c46fd
34 changed files with 895 additions and 237 deletions
Generated
+19
View File
@@ -3495,6 +3495,7 @@ dependencies = [
"cumulus-client-network",
"cumulus-client-pov-recovery",
"cumulus-primitives-core",
"cumulus-primitives-proof-size-hostfunction",
"cumulus-relay-chain-inprocess-interface",
"cumulus-relay-chain-interface",
"cumulus-relay-chain-minimal-node",
@@ -3564,6 +3565,7 @@ dependencies = [
"cumulus-pallet-parachain-system-proc-macro",
"cumulus-primitives-core",
"cumulus-primitives-parachain-inherent",
"cumulus-primitives-proof-size-hostfunction",
"cumulus-test-client",
"cumulus-test-relay-sproof-builder",
"environmental",
@@ -3595,6 +3597,7 @@ dependencies = [
"sp-version",
"staging-xcm",
"trie-db",
"trie-standardmap",
]
[[package]]
@@ -3743,6 +3746,18 @@ dependencies = [
"tracing",
]
[[package]]
name = "cumulus-primitives-proof-size-hostfunction"
version = "0.1.0"
dependencies = [
"sp-core",
"sp-externalities 0.19.0",
"sp-io",
"sp-runtime-interface 17.0.0",
"sp-state-machine",
"sp-trie",
]
[[package]]
name = "cumulus-primitives-timestamp"
version = "0.1.0"
@@ -3903,6 +3918,7 @@ version = "0.1.0"
dependencies = [
"cumulus-primitives-core",
"cumulus-primitives-parachain-inherent",
"cumulus-primitives-proof-size-hostfunction",
"cumulus-test-relay-sproof-builder",
"cumulus-test-runtime",
"cumulus-test-service",
@@ -14766,6 +14782,7 @@ dependencies = [
"sp-inherents",
"sp-runtime",
"sp-state-machine",
"sp-trie",
"substrate-test-runtime-client",
]
@@ -17612,6 +17629,7 @@ name = "sp-runtime-interface-proc-macro"
version = "11.0.0"
dependencies = [
"Inflector",
"expander 2.0.0",
"proc-macro-crate",
"proc-macro2",
"quote",
@@ -17864,6 +17882,7 @@ dependencies = [
"scale-info",
"schnellru",
"sp-core",
"sp-externalities 0.19.0",
"sp-runtime",
"sp-std 8.0.0",
"thiserror",