PoV Reclaim (Clawback) Node Side (#1462)

This PR provides the infrastructure for the pov-reclaim mechanism
discussed in #209. The goal is to provide the current proof size to the
runtime so it can be used to reclaim storage weight.

## New Host Function
- A new host function is provided
[here](https://github.com/skunert/polkadot-sdk/blob/5b317fda3be205f4136f10d4490387ccd4f9765d/cumulus/primitives/pov-reclaim/src/lib.rs#L23).
It returns the size of the current proof size to the runtime. If
recording is not enabled, it returns 0.

## Implementation Overview
- Implement option to enable proof recording during import in the
client. This is currently enabled for `polkadot-parachain`,
`parachain-template` and the cumulus test node.
- Make the proof recorder ready for no-std. It was previously only
enabled for std environments, but we need to record the proof size in
`validate_block` too.
- Provide a recorder implementation that only the records the size of
incoming nodes and does not store the nodes itself.
- Fix benchmarks that were broken by async backing changes
- Provide new externalities extension that is registered by default if
proof recording is enabled.
- I think we should discuss the naming, pov-reclaim was more intuitive
to me, but we could also go with clawback like in the issue.

## Impact of proof recording during import
With proof recording: 6.3058 Kelem/s
Without proof recording: 6.3427 Kelem/s

The measured impact on the importing performance is quite low on my
machine using the block import benchmark. With proof recording I am
seeing a performance hit of 0.585%.

---------

Co-authored-by: command-bot <>
Co-authored-by: Davide Galassi <davxy@datawok.net>
Co-authored-by: Bastian Köcher <git@kchr.de>
This commit is contained in:
Sebastian Kunert
2023-11-30 15:56:34 +01:00
committed by GitHub
parent 64361ac19a
commit 9a650c46fd
34 changed files with 895 additions and 237 deletions
@@ -27,7 +27,7 @@ use core::time::Duration;
use cumulus_primitives_core::ParaId;
use sc_block_builder::BlockBuilderBuilder;
use sp_keyring::Sr25519Keyring::Alice;
use sp_keyring::Sr25519Keyring::{Alice, Bob, Charlie, Ferdie};
use cumulus_test_service::bench_utils as utils;
@@ -38,17 +38,29 @@ fn benchmark_block_import(c: &mut Criterion) {
let para_id = ParaId::from(100);
let tokio_handle = runtime.handle();
let alice = runtime.block_on(
cumulus_test_service::TestNodeBuilder::new(para_id, tokio_handle.clone(), Alice).build(),
);
let client = alice.client;
let mut group = c.benchmark_group("Block import");
group.sample_size(20);
group.measurement_time(Duration::from_secs(120));
let mut initialize_glutton_pallet = true;
for (compute_ratio, storage_ratio) in &[(One::one(), Zero::zero()), (One::one(), One::one())] {
for (compute_ratio, storage_ratio, proof_on_import, keyring_identity) in &[
(One::one(), Zero::zero(), true, Alice),
(One::one(), One::one(), true, Bob),
(One::one(), Zero::zero(), false, Charlie),
(One::one(), One::one(), false, Ferdie),
] {
let node = runtime.block_on(
cumulus_test_service::TestNodeBuilder::new(
para_id,
tokio_handle.clone(),
*keyring_identity,
)
.import_proof_recording(*proof_on_import)
.build(),
);
let client = node.client;
let backend = node.backend;
let mut group = c.benchmark_group("Block import");
group.sample_size(20);
group.measurement_time(Duration::from_secs(120));
let block = utils::set_glutton_parameters(
&client,
initialize_glutton_pallet,
@@ -82,7 +94,10 @@ fn benchmark_block_import(c: &mut Criterion) {
),
|b| {
b.iter_batched(
|| benchmark_block.block.clone(),
|| {
backend.reset_trie_cache();
benchmark_block.block.clone()
},
|block| {
client.runtime_api().execute_block(parent_hash, block).unwrap();
},