Manual Seal (#4143)

* instant/manual seal

unbounded queues are evil

Apply suggestions from code review

Co-Authored-By: Robert Habermeier <rphmeier@gmail.com>

add fork tests, docs, remove todos

moar docs

Update client/consensus/manual-seal/src/rpc.rs

Co-Authored-By: Robert Habermeier <rphmeier@gmail.com>

remove unbound generic, parameter, docs, deps, code style changes

Apply suggestions from code review

Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

code style chnges

remove unused deps, remove dep renames, check if block is empty before importing, use ? for error propagation

fix tests

log errors for instant seal

use debug

code style changes, updated copyright dates

use txpool::Pool instead of BasicPool, code style changes

fixed tests

* fix tests

* requested changes from review

* check inherents len

* rebase

substrate/client/consensus/manual-seal/src/finalize_block.rs

@@ -0,0 +1,64 @@
+// Copyright 2019 Parity Technologies (UK) Ltd.
+// This file is part of Substrate.
+
+// Substrate is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+
+// Substrate is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License
+// along with Substrate.  If not, see <http://www.gnu.org/licenses/>.
+
+//! Block finalization utilities
+
+use crate::rpc;
+use sp_runtime::{
+	Justification,
+	traits::Block as BlockT,
+	generic::BlockId,
+};
+use std::sync::Arc;
+use sc_client_api::backend::Backend as ClientBackend;
+
+/// params for block finalization.
+pub struct FinalizeBlockParams<B: BlockT, CB> {
+	/// hash of the block
+	pub hash: <B as BlockT>::Hash,
+	/// sender to report errors/success to the rpc.
+	pub sender: rpc::Sender<()>,
+	/// finalization justification
+	pub justification: Option<Justification>,
+	/// client backend
+	pub backend: Arc<CB>,
+}
+
+/// finalizes a block in the backend with the given params.
+pub async fn finalize_block<B, CB>(params: FinalizeBlockParams<B, CB>)
+	where
+		B: BlockT,
+		CB: ClientBackend<B>,
+{
+	let FinalizeBlockParams {
+		hash,
+		mut sender,
+		justification,
+		backend: back_end,
+		..
+	} = params;
+
+	match back_end.finalize_block(BlockId::Hash(hash), justification) {
+		Err(e) => {
+			log::warn!("Failed to finalize block {:?}", e);
+			rpc::send_result(&mut sender, Err(e.into()))
+		}
+		Ok(()) => {
+			log::info!("Successfully finalized block: {}", hash);
+			rpc::send_result(&mut sender, Ok(()))
+		}
+	}
+}