mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-05-30 23:21:02 +00:00
Tests for BridgeHub(s) <> remote GRANDPA chain (#2692)
So far the `bridge-hub-test-utils` contained a tests set for testing BridgeHub runtime that is bridging with the remote **parachain**. But we have https://github.com/paritytech/polkadot-sdk/pull/2540 coming, which would add Rococo <> Bulletin chain bridge (where Bulletin = standalone chain that is using GRANDPA finality). Then it'll be expanded to Polkadot BH as well. So this PR adds the same set of tests to the `bridge-hub-test-utils`, but for the case when remote chain is the chain with GRANDPA finality. There's a lot of changes in this PR - I'll describe some: - I've added `BasicParachainRuntime` trait to decrease number of lines we need to add to `where` clause. Could revert, but imo it is useful; - `cumulus/parachains/runtimes/bridge-hubs/test-utils/src/test_data` is a submodule for generating test data for the test sets. `from_parachain.rs` is used in tests for the case when remote chain is a parachain, `from_grandpa_chain.rs` - for the bridges with remote GRANDPA chains. `mod.rs` has some code, shared by both types of tests; - `cumulus/parachains/runtimes/bridge-hubs/test-utils/src/test_data` is a submodule with all test cases. The `mod.rs` has tests, suitable for all cases. There's also `wth_parachain.rs` and `with_grandpa_chain.rs` with the same meaning as above; - I've merged the "core" code of two previous tests - `relayed_incoming_message_works` and `complex_relay_extrinsic_works` into one single `relayed_incoming_message_works` test. So now we are always constructing extrinsics and are dispatching them using executive module (meaning all signed extensions are also tested). New test set is used here: https://github.com/paritytech/polkadot-sdk/pull/2540. Once this PR is merged, I'll merge that other PR with master to remove duplicate changes. I'm also planning to cleanup generic constraints + remove some unnecessary assumptions about used chains in a follow-up PRs. But for now I think this PR has enough changes, so don't want to complicate it even more. --- Breaking changes for the code that have used those tests before: - the `construct_and_apply_extrinsic` callback now accepts the `RuntimeCall` instead of the `pallet_utility::Call`; - the `construct_and_apply_extrinsic` now may be called multiple times for the single test, so make sure the `frame_system::CheckNonce` is correctly constructed; - all previous tests have been moved from `bridge_hub_test_utils::test_cases` to `bridge_hub_test_utils::test_cases::from_parachain` module; - there are several changes in test arguments - please refer to https://github.com/paritytech/polkadot-sdk/compare/sv-tests-for-bridge-with-remote-grandpa-chain?expand=1#diff-79a28d4d3e1749050341c2424f00c4c139825b1a20937767f83e58b95166735c for details.
This commit is contained in:
committed by
GitHub
parent
3c5fcbe637
commit
9ecb2d3391
@@ -114,14 +114,34 @@ impl<Runtime: frame_system::Config + pallet_balances::Config + pallet_session::C
|
||||
}
|
||||
}
|
||||
|
||||
// Basic builder based on balances, collators and pallet_sessopm
|
||||
pub struct ExtBuilder<
|
||||
Runtime: frame_system::Config
|
||||
/// A set of traits for a minimal parachain runtime, that may be used in conjunction with the
|
||||
/// `ExtBuilder` and the `RuntimeHelper`.
|
||||
pub trait BasicParachainRuntime:
|
||||
frame_system::Config
|
||||
+ pallet_balances::Config
|
||||
+ pallet_session::Config
|
||||
+ pallet_xcm::Config
|
||||
+ parachain_info::Config
|
||||
+ pallet_collator_selection::Config
|
||||
+ cumulus_pallet_parachain_system::Config
|
||||
{
|
||||
}
|
||||
|
||||
impl<T> BasicParachainRuntime for T
|
||||
where
|
||||
T: frame_system::Config
|
||||
+ pallet_balances::Config
|
||||
+ pallet_session::Config
|
||||
+ pallet_xcm::Config
|
||||
+ parachain_info::Config,
|
||||
> {
|
||||
+ parachain_info::Config
|
||||
+ pallet_collator_selection::Config
|
||||
+ cumulus_pallet_parachain_system::Config,
|
||||
ValidatorIdOf<T>: From<AccountIdOf<T>>,
|
||||
{
|
||||
}
|
||||
|
||||
/// Basic builder based on balances, collators and pallet_session.
|
||||
pub struct ExtBuilder<Runtime: BasicParachainRuntime> {
|
||||
// endowed accounts with balances
|
||||
balances: Vec<(AccountIdOf<Runtime>, BalanceOf<Runtime>)>,
|
||||
// collators to test block prod
|
||||
@@ -135,14 +155,7 @@ pub struct ExtBuilder<
|
||||
_runtime: PhantomData<Runtime>,
|
||||
}
|
||||
|
||||
impl<
|
||||
Runtime: frame_system::Config
|
||||
+ pallet_balances::Config
|
||||
+ pallet_session::Config
|
||||
+ pallet_xcm::Config
|
||||
+ parachain_info::Config,
|
||||
> Default for ExtBuilder<Runtime>
|
||||
{
|
||||
impl<Runtime: BasicParachainRuntime> Default for ExtBuilder<Runtime> {
|
||||
fn default() -> ExtBuilder<Runtime> {
|
||||
ExtBuilder {
|
||||
balances: vec![],
|
||||
@@ -155,14 +168,7 @@ impl<
|
||||
}
|
||||
}
|
||||
|
||||
impl<
|
||||
Runtime: frame_system::Config
|
||||
+ pallet_balances::Config
|
||||
+ pallet_session::Config
|
||||
+ pallet_xcm::Config
|
||||
+ parachain_info::Config,
|
||||
> ExtBuilder<Runtime>
|
||||
{
|
||||
impl<Runtime: BasicParachainRuntime> ExtBuilder<Runtime> {
|
||||
pub fn with_balances(
|
||||
mut self,
|
||||
balances: Vec<(AccountIdOf<Runtime>, BalanceOf<Runtime>)>,
|
||||
@@ -198,12 +204,7 @@ impl<
|
||||
self
|
||||
}
|
||||
|
||||
pub fn build(self) -> sp_io::TestExternalities
|
||||
where
|
||||
Runtime:
|
||||
pallet_collator_selection::Config + pallet_balances::Config + pallet_session::Config,
|
||||
ValidatorIdOf<Runtime>: From<AccountIdOf<Runtime>>,
|
||||
{
|
||||
pub fn build(self) -> sp_io::TestExternalities {
|
||||
let mut t = frame_system::GenesisConfig::<Runtime>::default().build_storage().unwrap();
|
||||
|
||||
pallet_xcm::GenesisConfig::<Runtime> {
|
||||
|
||||
Reference in New Issue
Block a user