pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-04-26 16:57:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't close inbound notifications substreams immediately (#6781)

Browse Source 
* Don't close inbound notifications substreams immediately

* Fix not closing in return to node A closing
This commit is contained in:
Pierre Krieger
2020-07-31 16:42:53 +02:00
committed by GitHub
parent 9ca2300b05
commit a1786a92ec
3 changed files with 46 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/client/network/src/lib.rs
+3 -2
View File
@@ -197,13 +197,14 @@
//! handshake message can be of length 0, in which case the sender has to send a single `0`.
//! - The receiver then either immediately closes the substream, or answers with its own
//! LEB128-prefixed protocol-specific handshake response. The message can be of length 0, in which
//! case a single `0` has to be sent back. The receiver is then encouraged to close its sending
//! side.
//! case a single `0` has to be sent back.
//! - Once the handshake has completed, the notifications protocol is unidirectional. Only the
//! node which initiated the substream can push notifications. If the remote wants to send
//! notifications as well, it has to open its own undirectional substream.
//! - Each notification must be prefixed with an LEB128-encoded length. The encoding of the
//! messages is specific to each protocol.
//! - Either party can signal that it doesn't want a notifications substream anymore by closing
//! its writing side. The other party should respond by closing its own writing side soon after.
//!
//! The API of `sc-network` allows one to register user-defined notification protocols.
//! `sc-network` automatically tries to open a substream towards each node for which the legacy