Changed how relay loops are started (#840)

* slightly changed relay loop initialization

* git mv

* clippy

* more clippy

* loop_run -> run_loop

* review and clippy

* clippy

bridges/relays/bin-substrate/src/finality_pipeline.rs

@@ -98,7 +98,8 @@ pub async fn run<SourceChain, TargetChain, P>(
 	source_client: Client<SourceChain>,
 	target_client: Client<TargetChain>,
 	metrics_params: Option<relay_utils::metrics::MetricsParams>,
-) where
+) -> Result<(), String>
+where
 	P: SubstrateFinalitySyncPipeline<
 		Hash = HashOf<SourceChain>,
 		Number = BlockNumberOf<SourceChain>,
@@ -127,5 +128,5 @@ pub async fn run<SourceChain, TargetChain, P>(
 		metrics_params,
 		futures::future::pending(),
 	)
-	.await;
+	.await
 }

bridges/relays/bin-substrate/src/rialto_millau/millau_headers_to_rialto.rs

@@ -58,12 +58,12 @@ pub async fn run(
 	rialto_client: RialtoClient,
 	rialto_sign: RialtoSigningParams,
 	metrics_params: Option<relay_utils::metrics::MetricsParams>,
-) {
+) -> Result<(), String> {
 	crate::finality_pipeline::run(
 		MillauFinalityToRialto::new(rialto_client.clone(), rialto_sign),
 		millau_client,
 		rialto_client,
 		metrics_params,
 	)
-	.await;
+	.await
 }

bridges/relays/bin-substrate/src/rialto_millau/millau_messages_to_rialto.rs

@@ -132,7 +132,7 @@ pub async fn run(
 	rialto_sign: RialtoSigningParams,
 	lane_id: LaneId,
 	metrics_params: Option<MetricsParams>,
-) {
+) -> Result<(), String> {
 	let stall_timeout = Duration::from_secs(5 * 60);
 	let relayer_id_at_millau = millau_sign.signer.public().as_array_ref().clone().into();
 
@@ -186,5 +186,5 @@ pub async fn run(
 		metrics_params,
 		futures::future::pending(),
 	)
-	.await;
+	.await
 }

bridges/relays/bin-substrate/src/rialto_millau/mod.rs

@@ -151,7 +151,7 @@ async fn run_relay_headers(command: cli::RelayHeaders) -> Result<(), String> {
 			let millau_client = millau.into_client().await?;
 			let rialto_client = rialto.into_client().await?;
 			let rialto_sign = rialto_sign.parse()?;
-			millau_headers_to_rialto::run(millau_client, rialto_client, rialto_sign, prometheus_params.into()).await;
+			millau_headers_to_rialto::run(millau_client, rialto_client, rialto_sign, prometheus_params.into()).await
 		}
 		cli::RelayHeaders::RialtoToMillau {
 			rialto,
@@ -162,7 +162,7 @@ async fn run_relay_headers(command: cli::RelayHeaders) -> Result<(), String> {
 			let rialto_client = rialto.into_client().await?;
 			let millau_client = millau.into_client().await?;
 			let millau_sign = millau_sign.parse()?;
-			rialto_headers_to_millau::run(rialto_client, millau_client, millau_sign, prometheus_params.into()).await;
+			rialto_headers_to_millau::run(rialto_client, millau_client, millau_sign, prometheus_params.into()).await
 		}
 		cli::RelayHeaders::WestendToMillau {
 			westend,
@@ -173,10 +173,9 @@ async fn run_relay_headers(command: cli::RelayHeaders) -> Result<(), String> {
 			let westend_client = westend.into_client().await?;
 			let millau_client = millau.into_client().await?;
 			let millau_sign = millau_sign.parse()?;
-			westend_headers_to_millau::run(westend_client, millau_client, millau_sign, prometheus_params.into()).await;
+			westend_headers_to_millau::run(westend_client, millau_client, millau_sign, prometheus_params.into()).await
 		}
 	}
-	Ok(())
 }
 
 async fn run_relay_messages(command: cli::RelayMessages) -> Result<(), String> {
@@ -202,7 +201,7 @@ async fn run_relay_messages(command: cli::RelayMessages) -> Result<(), String> {
 				lane.into(),
 				prometheus_params.into(),
 			)
-			.await;
+			.await
 		}
 		cli::RelayMessages::RialtoToMillau {
 			rialto,
@@ -225,10 +224,9 @@ async fn run_relay_messages(command: cli::RelayMessages) -> Result<(), String> {
 				lane.into(),
 				prometheus_params.into(),
 			)
-			.await;
+			.await
 		}
 	}
-	Ok(())
 }
 
 async fn run_send_message(command: cli::SendMessage) -> Result<(), String> {

bridges/relays/bin-substrate/src/rialto_millau/rialto_headers_to_millau.rs

@@ -61,12 +61,12 @@ pub async fn run(
 	millau_client: MillauClient,
 	millau_sign: MillauSigningParams,
 	metrics_params: Option<relay_utils::metrics::MetricsParams>,
-) {
+) -> Result<(), String> {
 	crate::finality_pipeline::run(
 		RialtoFinalityToMillau::new(millau_client.clone(), millau_sign),
 		rialto_client,
 		millau_client,
 		metrics_params,
 	)
-	.await;
+	.await
 }

bridges/relays/bin-substrate/src/rialto_millau/rialto_messages_to_millau.rs

@@ -132,7 +132,7 @@ pub async fn run(
 	millau_sign: MillauSigningParams,
 	lane_id: LaneId,
 	metrics_params: Option<MetricsParams>,
-) {
+) -> Result<(), String> {
 	let stall_timeout = Duration::from_secs(5 * 60);
 	let relayer_id_at_rialto = rialto_sign.signer.public().as_array_ref().clone().into();
 
@@ -185,5 +185,5 @@ pub async fn run(
 		metrics_params,
 		futures::future::pending(),
 	)
-	.await;
+	.await
 }

bridges/relays/bin-substrate/src/rialto_millau/westend_headers_to_millau.rs

@@ -61,12 +61,12 @@ pub async fn run(
 	millau_client: MillauClient,
 	millau_sign: MillauSigningParams,
 	metrics_params: Option<relay_utils::metrics::MetricsParams>,
-) {
+) -> Result<(), String> {
 	crate::finality_pipeline::run(
 		WestendFinalityToMillau::new(millau_client.clone(), millau_sign),
 		westend_client,
 		millau_client,
 		metrics_params,
 	)
-	.await;
+	.await
 }