pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-07-21 03:55:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

pallet-ranked-collective: Ensure to cleanup state in remove_member (#2591)

Browse Source 
This ensures that we cleanup the state of `who` in `remove_member`.

---------

Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
This commit is contained in:
Bastian Köcher
2023-12-04 19:43:27 +01:00
committed by GitHub
parent e6b9da132d
commit a1b2ecb902
3 changed files with 53 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/frame/ranked-collective/src/lib.rs
+15 -10
View File
@@ -663,16 +663,21 @@ pub mod pallet {
}
fn remove_from_rank(who: &T::AccountId, rank: Rank) -> DispatchResult {
let last_index = MemberCount::<T, I>::get(rank).saturating_sub(1);
let index = IdToIndex::<T, I>::get(rank, &who).ok_or(Error::<T, I>::Corruption)?;
if index != last_index {
let last =
IndexToId::<T, I>::get(rank, last_index).ok_or(Error::<T, I>::Corruption)?;
IdToIndex::<T, I>::insert(rank, &last, index);
IndexToId::<T, I>::insert(rank, index, &last);
}
MemberCount::<T, I>::mutate(rank, |r| r.saturating_dec());
Ok(())
MemberCount::<T, I>::try_mutate(rank, |last_index| {
last_index.saturating_dec();
let index = IdToIndex::<T, I>::get(rank, &who).ok_or(Error::<T, I>::Corruption)?;
if index != *last_index {
let last = IndexToId::<T, I>::get(rank, *last_index)
.ok_or(Error::<T, I>::Corruption)?;
IdToIndex::<T, I>::insert(rank, &last, index);
IndexToId::<T, I>::insert(rank, index, &last);
}
IdToIndex::<T, I>::remove(rank, who);
IndexToId::<T, I>::remove(rank, last_index);
Ok(())
})
}
/// Adds a member into the ranked collective at level 0.