From a5d94a4b8b87a6357fa22d0629bcf2adeb977184 Mon Sep 17 00:00:00 2001 From: Alexandru Vasile <60601340+lexnv@users.noreply.github.com> Date: Mon, 6 May 2024 11:11:39 +0300 Subject: [PATCH] metadata: Fix cargo clippy (#1574) * metadata: Fix cargo clippy Signed-off-by: Alexandru Vasile * subxt/backend: Fix clone clippy Signed-off-by: Alexandru Vasile * tests: Use clone into Signed-off-by: Alexandru Vasile --------- Signed-off-by: Alexandru Vasile --- metadata/src/from_into/v14.rs | 2 +- subxt/src/backend/unstable/follow_stream_driver.rs | 5 +++-- testing/ui-tests/src/utils/metadata_test_runner.rs | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/metadata/src/from_into/v14.rs b/metadata/src/from_into/v14.rs index 989542ab56..5c00d24e7c 100644 --- a/metadata/src/from_into/v14.rs +++ b/metadata/src/from_into/v14.rs @@ -344,7 +344,7 @@ fn generate_outer_enums( let Some(last) = call_path.last_mut() else { return Err(TryFromError::InvalidTypePath("RuntimeCall".into())); }; - *last = "RuntimeError".to_owned(); + "RuntimeError".clone_into(last); generate_outer_error_enum_type(metadata, call_path) }; diff --git a/subxt/src/backend/unstable/follow_stream_driver.rs b/subxt/src/backend/unstable/follow_stream_driver.rs index e85336c314..61aca96dc9 100644 --- a/subxt/src/backend/unstable/follow_stream_driver.rs +++ b/subxt/src/backend/unstable/follow_stream_driver.rs @@ -267,8 +267,9 @@ impl Shared { shared.seen_runtime_events.clear(); - init_message.finalized_block_hashes = - finalized_ev.finalized_block_hashes.clone(); + init_message + .finalized_block_hashes + .clone_from(&finalized_ev.finalized_block_hashes); if let Some(runtime_ev) = newest_runtime { init_message.finalized_block_runtime = Some(runtime_ev); diff --git a/testing/ui-tests/src/utils/metadata_test_runner.rs b/testing/ui-tests/src/utils/metadata_test_runner.rs index df87ef3836..a900873f3e 100644 --- a/testing/ui-tests/src/utils/metadata_test_runner.rs +++ b/testing/ui-tests/src/utils/metadata_test_runner.rs @@ -70,7 +70,7 @@ impl MetadataTestRunnerCaseBuilder { /// Set the test name. pub fn name(mut self, name: impl AsRef) -> Self { - self.name = name.as_ref().to_owned(); + name.as_ref().clone_into(&mut self.name); self }