pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-05-01 11:17:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Disable CORS when running in --dev (#2291)

Browse Source 
* Disable cors in dev mode,

* Whitelist substrate-ui.

* Fix build.

* Update docs.
This commit is contained in:
Tomasz Drwięga
2019-04-16 12:57:51 +02:00
committed by Bastian Köcher
parent 47c1b4b26e
commit a6cbc965a0
2 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/core/cli/src/lib.rs
+12 -5
View File
@@ -475,11 +475,18 @@ where
config.rpc_ws = Some(
parse_address(&format!("{}:{}", ws_interface, 9944), cli.ws_port)?
);
config.rpc_cors = cli.rpc_cors.unwrap_or_else(|| Some(vec![
"http://localhost:*".into(),
"https://localhost:*".into(),
"https://polkadot.js.org".into()
]));
let is_dev = cli.shared_params.dev;
config.rpc_cors = cli.rpc_cors.unwrap_or_else(|| if is_dev {
log::warn!("Running in --dev mode, RPC CORS has been disabled.");
None
} else {
Some(vec![
"http://localhost:*".into(),
"https://localhost:*".into(),
"https://polkadot.js.org".into(),
"https://substrate-ui.parity.io".into(),
])
});
// Override telemetry
if cli.no_telemetry {
substrate/core/cli/src/params.rs
+2 -1
View File
@@ -332,7 +332,8 @@ pub struct RunCmd {
/// Specify browser Origins allowed to access the HTTP & WS RPC servers.
/// It's a comma-separated list of origins (protocol://domain or special `null` value).
/// Value of `all` will disable origin validation.
/// Default is to allow localhost and https://polkadot.js.org origin.
/// Default is to allow localhost, https://polkadot.js.org and https://substrate-ui.parity.io origins.
/// When running in --dev mode the default is to allow all origins.
#[structopt(long = "rpc-cors", value_name = "ORIGINS", parse(try_from_str = "parse_cors"))]
pub rpc_cors: Option<Option<Vec<String>>>,