pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-05-31 12:11:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Approve multiple candidates with a single signature (#1191)

Browse Source 
Initial implementation for the plan discussed here: https://github.com/paritytech/polkadot-sdk/issues/701
Built on top of https://github.com/paritytech/polkadot-sdk/pull/1178
v0: https://github.com/paritytech/polkadot/pull/7554,

## Overall idea

When approval-voting checks a candidate and is ready to advertise the
approval, defer it in a per-relay chain block until we either have
MAX_APPROVAL_COALESCE_COUNT candidates to sign or a candidate has stayed
MAX_APPROVALS_COALESCE_TICKS in the queue, in both cases we sign what
candidates we have available.

This should allow us to reduce the number of approvals messages we have
to create/send/verify. The parameters are configurable, so we should
find some values that balance:

- Security of the network: Delaying broadcasting of an approval
shouldn't but the finality at risk and to make sure that never happens
we won't delay sending a vote if we are past 2/3 from the no-show time.
- Scalability of the network: MAX_APPROVAL_COALESCE_COUNT = 1 &
MAX_APPROVALS_COALESCE_TICKS =0, is what we have now and we know from
the measurements we did on versi, it bottlenecks
approval-distribution/approval-voting when increase significantly the
number of validators and parachains
- Block storage: In case of disputes we have to import this votes on
chain and that increase the necessary storage with
MAX_APPROVAL_COALESCE_COUNT * CandidateHash per vote. Given that
disputes are not the normal way of the network functioning and we will
limit MAX_APPROVAL_COALESCE_COUNT in the single digits numbers, this
should be good enough. Alternatively, we could try to create a better
way to store this on-chain through indirection, if that's needed.

## Other fixes:
- Fixed the fact that we were sending random assignments to
non-validators, that was wrong because those won't do anything with it
and they won't gossip it either because they do not have a grid topology
set, so we would waste the random assignments.
- Added metrics to be able to debug potential no-shows and
mis-processing of approvals/assignments.

## TODO:
- [x] Get feedback, that this is moving in the right direction. @ordian
@sandreim @eskimor @burdges, let me know what you think.
- [x] More and more testing.
- [x]  Test in versi.
- [x] Make MAX_APPROVAL_COALESCE_COUNT &
MAX_APPROVAL_COALESCE_WAIT_MILLIS a parachain host configuration.
- [x] Make sure the backwards compatibility works correctly
- [x] Make sure this direction is compatible with other streams of work:
https://github.com/paritytech/polkadot-sdk/issues/635 &
https://github.com/paritytech/polkadot-sdk/issues/742
- [x] Final versi burn-in before merging

---------

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
This commit is contained in:
Alexandru Gheorghe
2023-12-13 08:43:15 +02:00
committed by GitHub
parent d18a682bf7
commit a84dd0dba5
82 changed files with 5883 additions and 1483 deletions
Download Patch File Download Diff File Expand all files Collapse all files
polkadot/runtime/parachains/src/disputes/tests.rs
+84 -42
View File
@@ -1500,7 +1500,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_1,
&signed_1
&signed_1,
true,
)
.is_ok());
assert!(check_signature(
@@ -1508,7 +1509,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_1,
&signed_1
&signed_1,
true
)
.is_err());
assert!(check_signature(
@@ -1516,7 +1518,8 @@ fn test_check_signature() {
wrong_candidate_hash,
session,
&statement_1,
&signed_1
&signed_1,
true,
)
.is_err());
assert!(check_signature(
@@ -1524,7 +1527,8 @@ fn test_check_signature() {
candidate_hash,
wrong_session,
&statement_1,
&signed_1
&signed_1,
true
)
.is_err());
assert!(check_signature(
@@ -1532,7 +1536,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_2,
&signed_1
&signed_1,
true,
)
.is_err());
assert!(check_signature(
@@ -1540,7 +1545,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_3,
&signed_1
&signed_1,
true
)
.is_err());
assert!(check_signature(
@@ -1548,7 +1554,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_4,
&signed_1
&signed_1,
true
)
.is_err());
assert!(check_signature(
@@ -1556,7 +1563,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_5,
&signed_1
&signed_1,
true,
)
.is_err());
@@ -1565,7 +1573,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_2,
&signed_2
&signed_2,
true,
)
.is_ok());
assert!(check_signature(
@@ -1573,7 +1582,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_2,
&signed_2
&signed_2,
true,
)
.is_err());
assert!(check_signature(
@@ -1581,7 +1591,8 @@ fn test_check_signature() {
wrong_candidate_hash,
session,
&statement_2,
&signed_2
&signed_2,
true,
)
.is_err());
assert!(check_signature(
@@ -1589,7 +1600,8 @@ fn test_check_signature() {
candidate_hash,
wrong_session,
&statement_2,
&signed_2
&signed_2,
true
)
.is_err());
assert!(check_signature(
@@ -1597,7 +1609,8 @@ fn test_check_signature() {
candidate_hash,
session,
&wrong_statement_2,
&signed_2
&signed_2,
true,
)
.is_err());
assert!(check_signature(
@@ -1605,7 +1618,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_1,
&signed_2
&signed_2,
true,
)
.is_err());
assert!(check_signature(
@@ -1613,7 +1627,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_3,
&signed_2
&signed_2,
true,
)
.is_err());
assert!(check_signature(
@@ -1621,7 +1636,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_4,
&signed_2
&signed_2,
true,
)
.is_err());
assert!(check_signature(
@@ -1629,7 +1645,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_5,
&signed_2
&signed_2,
true,
)
.is_err());
@@ -1638,7 +1655,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_3,
&signed_3
&signed_3,
true,
)
.is_ok());
assert!(check_signature(
@@ -1646,7 +1664,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_3,
&signed_3
&signed_3,
true,
)
.is_err());
assert!(check_signature(
@@ -1654,7 +1673,8 @@ fn test_check_signature() {
wrong_candidate_hash,
session,
&statement_3,
&signed_3
&signed_3,
true,
)
.is_err());
assert!(check_signature(
@@ -1662,7 +1682,8 @@ fn test_check_signature() {
candidate_hash,
wrong_session,
&statement_3,
&signed_3
&signed_3,
true,
)
.is_err());
assert!(check_signature(
@@ -1670,7 +1691,8 @@ fn test_check_signature() {
candidate_hash,
session,
&wrong_statement_3,
&signed_3
&signed_3,
true,
)
.is_err());
assert!(check_signature(
@@ -1678,7 +1700,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_1,
&signed_3
&signed_3,
true,
)
.is_err());
assert!(check_signature(
@@ -1686,7 +1709,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_2,
&signed_3
&signed_3,
true
)
.is_err());
assert!(check_signature(
@@ -1694,7 +1718,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_4,
&signed_3
&signed_3,
true,
)
.is_err());
assert!(check_signature(
@@ -1702,7 +1727,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_5,
&signed_3
&signed_3,
true,
)
.is_err());
@@ -1711,7 +1737,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_4,
&signed_4
&signed_4,
true,
)
.is_ok());
assert!(check_signature(
@@ -1719,7 +1746,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_4,
&signed_4
&signed_4,
true,
)
.is_err());
assert!(check_signature(
@@ -1727,7 +1755,8 @@ fn test_check_signature() {
wrong_candidate_hash,
session,
&statement_4,
&signed_4
&signed_4,
true,
)
.is_err());
assert!(check_signature(
@@ -1735,7 +1764,8 @@ fn test_check_signature() {
candidate_hash,
wrong_session,
&statement_4,
&signed_4
&signed_4,
true,
)
.is_err());
assert!(check_signature(
@@ -1743,7 +1773,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_1,
&signed_4
&signed_4,
true,
)
.is_err());
assert!(check_signature(
@@ -1751,7 +1782,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_2,
&signed_4
&signed_4,
true,
)
.is_err());
assert!(check_signature(
@@ -1759,7 +1791,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_3,
&signed_4
&signed_4,
true,
)
.is_err());
assert!(check_signature(
@@ -1767,7 +1800,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_5,
&signed_4
&signed_4,
true,
)
.is_err());
@@ -1776,7 +1810,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_5,
&signed_5
&signed_5,
true,
)
.is_ok());
assert!(check_signature(
@@ -1784,7 +1819,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_5,
&signed_5
&signed_5,
true,
)
.is_err());
assert!(check_signature(
@@ -1792,7 +1828,8 @@ fn test_check_signature() {
wrong_candidate_hash,
session,
&statement_5,
&signed_5
&signed_5,
true,
)
.is_err());
assert!(check_signature(
@@ -1800,7 +1837,8 @@ fn test_check_signature() {
candidate_hash,
wrong_session,
&statement_5,
&signed_5
&signed_5,
true,
)
.is_err());
assert!(check_signature(
@@ -1808,7 +1846,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_1,
&signed_5
&signed_5,
true,
)
.is_err());
assert!(check_signature(
@@ -1816,7 +1855,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_2,
&signed_5
&signed_5,
true,
)
.is_err());
assert!(check_signature(
@@ -1824,7 +1864,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_3,
&signed_5
&signed_5,
true,
)
.is_err());
assert!(check_signature(
@@ -1832,7 +1873,8 @@ fn test_check_signature() {
candidate_hash,
session,
&statement_4,
&signed_5
&signed_5,
true,
)
.is_err());
}