From ab0f67f5e7f0fcfb15b18ea853a6f66ad5e75dbb Mon Sep 17 00:00:00 2001
From: Alexandru Vasile <alexandru.vasile@parity.io>
Date: Fri, 26 Jan 2024 15:05:37 +0200
Subject: [PATCH] lightclient: Add generic platform for AddedChain

Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
---
 lightclient/src/background.rs            |  4 ++--
 lightclient/src/client.rs                |  6 +++---
 subxt/src/client/light_client/builder.rs | 17 +++++++----------
 subxt/src/client/light_client/mod.rs     |  2 +-
 4 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/lightclient/src/background.rs b/lightclient/src/background.rs
index 1e34596d9e..66cbcbc1c5 100644
--- a/lightclient/src/background.rs
+++ b/lightclient/src/background.rs
@@ -314,10 +314,10 @@ impl<TPlatform: PlatformRef, TChain> BackgroundTask<TPlatform, TChain> {
     /// Perform the main background task:
     /// - receiving requests from subxt RPC method / subscriptions
     /// - provides the results from the light client back to users.
-    pub async fn start_task(
+    pub async fn start_task<TPlat: smoldot_light::platform::PlatformRef>(
         &mut self,
         from_subxt: mpsc::UnboundedReceiver<FromSubxt>,
-        from_node: Vec<AddedChain>,
+        from_node: Vec<AddedChain<TPlat>>,
     ) {
         let from_subxt_event = tokio_stream::wrappers::UnboundedReceiverStream::new(from_subxt);
 
diff --git a/lightclient/src/client.rs b/lightclient/src/client.rs
index 0269986384..db515c774d 100644
--- a/lightclient/src/client.rs
+++ b/lightclient/src/client.rs
@@ -123,7 +123,7 @@ impl LightClientRpc {
     /// https://docs.rs/wasm-bindgen-futures/latest/wasm_bindgen_futures/fn.future_to_promise.html.
     pub fn new_from_client<TPlat>(
         client: smoldot_light::Client<TPlat>,
-        chains: impl IntoIterator<Item = AddedChain>,
+        chains: impl IntoIterator<Item = AddedChain<TPlat>>,
     ) -> RawLightClientRpc
     where
         TPlat: smoldot_light::platform::PlatformRef + Clone,
@@ -202,9 +202,9 @@ impl LightClientRpc {
 }
 
 /// The added chain of the light-client.
-pub struct AddedChain {
+pub struct AddedChain<TPlat: smoldot_light::platform::PlatformRef> {
     /// The id of the chain.
     pub chain_id: smoldot_light::ChainId,
     /// Producer of RPC responses for the chain.
-    pub rpc_responses: smoldot_light::JsonRpcResponses,
+    pub rpc_responses: smoldot_light::JsonRpcResponses<TPlat>,
 }
diff --git a/subxt/src/client/light_client/builder.rs b/subxt/src/client/light_client/builder.rs
index 2733fd4bb4..8553cedea4 100644
--- a/subxt/src/client/light_client/builder.rs
+++ b/subxt/src/client/light_client/builder.rs
@@ -186,19 +186,19 @@ impl<T: Config> LightClientBuilder<T> {
 }
 
 /// Raw builder for [`RawLightClient`].
-pub struct RawLightClientBuilder {
-    chains: Vec<AddedChain>,
+pub struct RawLightClientBuilder<TPlatform: smoldot::PlatformRef> {
+    chains: Vec<AddedChain<TPlatform>>,
 }
 
-impl Default for RawLightClientBuilder {
+impl<TPlatform: smoldot::PlatformRef> Default for RawLightClientBuilder<TPlatform> {
     fn default() -> Self {
         Self { chains: Vec::new() }
     }
 }
 
-impl RawLightClientBuilder {
+impl<TPlatform: smoldot::PlatformRef> RawLightClientBuilder<TPlatform> {
     /// Create a new [`RawLightClientBuilder`].
-    pub fn new() -> RawLightClientBuilder {
+    pub fn new() -> RawLightClientBuilder<TPlatform> {
         RawLightClientBuilder::default()
     }
 
@@ -206,7 +206,7 @@ impl RawLightClientBuilder {
     pub fn add_chain(
         mut self,
         chain_id: smoldot::ChainId,
-        rpc_responses: smoldot::JsonRpcResponses,
+        rpc_responses: smoldot::JsonRpcResponses<TPlatform>,
     ) -> Self {
         self.chains.push(AddedChain {
             chain_id,
@@ -219,10 +219,7 @@ impl RawLightClientBuilder {
     ///
     /// The provided `chain_id` is the chain with which the current instance of light client will interact.
     /// To target a different chain call the [`LightClient::target_chain`] method.
-    pub async fn build<TPlatform: smoldot::PlatformRef>(
-        self,
-        client: smoldot::Client<TPlatform>,
-    ) -> Result<RawLightClient, Error> {
+    pub async fn build(self, client: smoldot::Client<TPlatform>) -> Result<RawLightClient, Error> {
         // The raw subxt light client that spawns the smoldot background task.
         let raw_rpc: subxt_lightclient::RawLightClientRpc =
             subxt_lightclient::LightClientRpc::new_from_client(client, self.chains.into_iter());
diff --git a/subxt/src/client/light_client/mod.rs b/subxt/src/client/light_client/mod.rs
index a4b116652e..76264e93f0 100644
--- a/subxt/src/client/light_client/mod.rs
+++ b/subxt/src/client/light_client/mod.rs
@@ -75,7 +75,7 @@ impl RawLightClient {
     /// # Note
     ///
     /// If you are unsure, please use [`LightClient::builder`] instead.
-    pub fn builder() -> RawLightClientBuilder {
+    pub fn builder<TPlatform: smoldot::PlatformRef>() -> RawLightClientBuilder<TPlatform> {
         RawLightClientBuilder::default()
     }