pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-07-25 00:05:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Maintain TotalIssurance integrity in case of sudo set_balance (#2871)

Browse Source 
* Maintain TotalInsurance integrity in case of sudo set_balance

* Fix set_balance docs

* Update impl_version
This commit is contained in:
Wei Tang
2019-06-15 10:26:22 +02:00
committed by Gavin Wood
parent 549b4e9fb1
commit ad0011a1bd
2 changed files with 27 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/node/runtime/src/lib.rs
+1 -1
View File
@@ -59,7 +59,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
impl_name: create_runtime_str!("substrate-node"), impl_name: create_runtime_str!("substrate-node"),
authoring_version: 10, authoring_version: 10,
spec_version: 94, spec_version: 94,
impl_version: 94, impl_version: 95,
apis: RUNTIME_API_VERSIONS, apis: RUNTIME_API_VERSIONS,
}; };
substrate/srml/balances/src/lib.rs
+26 -8
View File
@@ -142,11 +142,15 @@
//! ## Genesis config //! ## Genesis config
//! //!
//! The Balances module depends on the [`GenesisConfig`](./struct.GenesisConfig.html). //! The Balances module depends on the [`GenesisConfig`](./struct.GenesisConfig.html).
//!
//! ## Assumptions
//!
//! * Total issued balanced of all accounts should be less than `Trait::Balance::max_value()`.
#![cfg_attr(not(feature = "std"), no_std)] #![cfg_attr(not(feature = "std"), no_std)]
use rstd::prelude::*; use rstd::prelude::*;
use rstd::{cmp, result}; use rstd::{cmp, result, mem};
use parity_codec::{Codec, Encode, Decode}; use parity_codec::{Codec, Encode, Decode};
use srml_support::{StorageValue, StorageMap, Parameter, decl_event, decl_storage, decl_module}; use srml_support::{StorageValue, StorageMap, Parameter, decl_event, decl_storage, decl_module};
use srml_support::traits::{ use srml_support::traits::{
@@ -373,10 +377,10 @@ decl_module! {
/// Set the balances of a given account. /// Set the balances of a given account.
/// ///
/// This will alter `FreeBalance` and `ReservedBalance` in storage. /// This will alter `FreeBalance` and `ReservedBalance` in storage. it will
/// also decrease the total issuance of the system (`TotalIssuance`).
/// If the new free or reserved balance is below the existential deposit, /// If the new free or reserved balance is below the existential deposit,
/// it will also decrease the total issuance of the system (`TotalIssuance`) /// it will reset the account nonce (`system::AccountNonce`).
/// and reset the account nonce (`system::AccountNonce`).
/// ///
/// The dispatch origin for this call is `root`. /// The dispatch origin for this call is `root`.
/// ///
@@ -386,12 +390,26 @@ decl_module! {
/// # </weight> /// # </weight>
fn set_balance( fn set_balance(
who: <T::Lookup as StaticLookup>::Source, who: <T::Lookup as StaticLookup>::Source,
#[compact] free: T::Balance, #[compact] new_free: T::Balance,
#[compact] reserved: T::Balance #[compact] new_reserved: T::Balance
) { ) {
let who = T::Lookup::lookup(who)?; let who = T::Lookup::lookup(who)?;
Self::set_free_balance(&who, free);
Self::set_reserved_balance(&who, reserved); let current_free = <FreeBalance<T, I>>::get(&who);
if new_free > current_free {
mem::drop(PositiveImbalance::<T, I>::new(new_free - current_free));
} else if new_free < current_free {
mem::drop(NegativeImbalance::<T, I>::new(current_free - new_free));
}
Self::set_free_balance(&who, new_free);
let current_reserved = <ReservedBalance<T, I>>::get(&who);
if new_reserved > current_reserved {
mem::drop(PositiveImbalance::<T, I>::new(new_reserved - current_reserved));
} else if new_reserved < current_reserved {
mem::drop(NegativeImbalance::<T, I>::new(current_reserved - new_reserved));
}
Self::set_reserved_balance(&who, new_reserved);
} }
} }
} }