pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-16 22:31:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

improved gossip topology (#3270)

Browse Source 
* gossip-support: gossip topology

* some fixes

* handle view update for newly added gossip peers

* fix neighbors calculation

* fix test

* resolve TODOs

* typo

* guide updates

* spaces in the guide

* sneaky spaces

* hash randomness

* address some review nits

* use unbounded in bridge for subsystem msg
This commit is contained in:
Andronik Ordian
2021-06-18 21:30:35 +02:00
committed by GitHub
parent ae5b355754
commit ad9c02886d
21 changed files with 720 additions and 287 deletions
Download Patch File Download Diff File Expand all files Collapse all files
polkadot/node/network/approval-distribution/src/lib.rs
+44 -8
View File
@@ -81,6 +81,10 @@ struct State {
/// Peer view data is partially stored here, and partially inline within the [`BlockEntry`]s
peer_views: HashMap<PeerId, View>,
/// Track all our neighbors in the current gossip topology.
/// We're not necessarily connected to all of them.
gossip_peers: HashSet<PeerId>,
}
#[derive(Debug, Clone, Hash, PartialEq, Eq)]
@@ -209,6 +213,15 @@ impl State {
entry.known_by.remove(&peer_id);
})
}
NetworkBridgeEvent::NewGossipTopology(peers) => {
let newly_added: Vec<PeerId> = peers.difference(&self.gossip_peers).cloned().collect();
self.gossip_peers = peers;
for peer_id in newly_added {
if let Some(view) = self.peer_views.remove(&peer_id) {
self.handle_peer_view_change(ctx, metrics, peer_id, view).await;
}
}
}
NetworkBridgeEvent::PeerViewChange(peer_id, view) => {
self.handle_peer_view_change(ctx, metrics, peer_id, view).await;
}
@@ -336,6 +349,7 @@ impl State {
);
Self::unify_with_peer(
ctx,
&self.gossip_peers,
metrics,
&mut self.blocks,
peer_id.clone(),
@@ -439,11 +453,9 @@ impl State {
peer_id: PeerId,
view: View,
) {
let lucky = util::gen_ratio_sqrt_subset(self.peer_views.len(), util::MIN_GOSSIP_PEERS);
tracing::trace!(
target: LOG_TARGET,
?view,
?lucky,
"Peer view change",
);
let finalized_number = view.finalized_number;
@@ -468,12 +480,9 @@ impl State {
});
}
if !lucky {
return;
}
Self::unify_with_peer(
ctx,
&self.gossip_peers,
metrics,
&mut self.blocks,
peer_id.clone(),
@@ -704,7 +713,12 @@ impl State {
.collect::<Vec<_>>();
let assignments = vec![(assignment, claimed_candidate_index)];
let peers = util::choose_random_sqrt_subset(peers, MIN_GOSSIP_PEERS);
let gossip_peers = &self.gossip_peers;
let peers = util::choose_random_subset(
|e| gossip_peers.contains(e),
peers,
MIN_GOSSIP_PEERS,
);
// Add the fingerprint of the assignment to the knowledge of each peer.
for peer in peers.iter() {
@@ -943,7 +957,13 @@ impl State {
.cloned()
.filter(|key| maybe_peer_id.as_ref().map_or(true, |id| id != key))
.collect::<Vec<_>>();
let peers = util::choose_random_sqrt_subset(peers, MIN_GOSSIP_PEERS);
let gossip_peers = &self.gossip_peers;
let peers = util::choose_random_subset(
|e| gossip_peers.contains(e),
peers,
MIN_GOSSIP_PEERS,
);
// Add the fingerprint of the assignment to the knowledge of each peer.
for peer in peers.iter() {
@@ -975,11 +995,27 @@ impl State {
async fn unify_with_peer(
ctx: &mut impl SubsystemContext<Message = ApprovalDistributionMessage>,
gossip_peers: &HashSet<PeerId>,
metrics: &Metrics,
entries: &mut HashMap<Hash, BlockEntry>,
peer_id: PeerId,
view: View,
) {
let is_gossip_peer = gossip_peers.contains(&peer_id);
let lucky = is_gossip_peer || util::gen_ratio(
util::MIN_GOSSIP_PEERS.saturating_sub(gossip_peers.len()),
util::MIN_GOSSIP_PEERS,
);
if !lucky {
tracing::trace!(
target: LOG_TARGET,
?peer_id,
"Unlucky peer",
);
return;
}
metrics.on_unify_with_peer();
let _timer = metrics.time_unify_with_peer();
let mut to_send: Vec<Hash> = Vec::new();