client/finality-grandpa: Add regression test for observer polling network (was #4778) (#4795)

mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-05-30 23:21:02 +00:00

* client/finality-grandpa: Add regression test observer polling network

Ensure `Future` implementation of `ObserverWork` is polling its
`NetworkBridge`. Regression test for bug introduced in d9837d7dd and
fixed in 504b4e89e.

When polled, `NetworkBridge` forwards reputation change requests from
the `GossipValidator` to the underlying `dyn Network`. This test
triggers a reputation change by calling `GossipValidator::validate` with
an invalid gossip message. After polling the `ObserverWork` which should
poll the `NetworkBridge`, the reputation change should be forwarded to
the test network.

* Nits

Co-authored-by: Max Inden <mail@max-inden.de>

This commit is contained in:

Gavin Wood

2020-01-31 19:12:03 +00:00

committed by

GitHub

parent 111207afe8

commit adde404e41

5 changed files with 94 additions and 7 deletions

									
										substrate/client/finality-grandpa/src/communication/mod.rs
									
		+1
		-1
	
												View File
												
				@@ -62,7 +62,7 @@ pub mod gossip;

				mod periodic;

				#[cfg(test)]

				mod tests;

				pub(crate) mod tests;

				pub use sp_finality_grandpa::GRANDPA_ENGINE_ID;