Do not assume AssetIds are Copy (companion for substrate#14158) (#2586)

* Do not assume `AssetId`s are `Copy`

* update lockfile for {"substrate", "polkadot"}

---------

Co-authored-by: parity-processbot <>

cumulus/parachains/common/src/impls.rs

@@ -91,7 +91,7 @@ where
 	Assets: fungibles::Inspect<AccountId>,
 {
 	fn contains(id: &<Assets as fungibles::Inspect<AccountId>>::AssetId) -> bool {
-		!Assets::total_issuance(*id).is_zero()
+		!Assets::total_issuance(id.clone()).is_zero()
 	}
 }
 
@@ -103,7 +103,7 @@ where
 	Assets: fungibles::Inspect<AccountId>,
 {
 	fn contains(id: &<Assets as fungibles::Inspect<AccountId>>::AssetId) -> bool {
-		Assets::asset_exists(*id)
+		Assets::asset_exists(id.clone())
 	}
 }
 

cumulus/parachains/runtimes/testing/penpal/src/xcm_config.rs

@@ -197,7 +197,7 @@ where
 	Assets: fungibles::Inspect<AccountId>,
 {
 	fn contains(id: &<Assets as fungibles::Inspect<AccountId>>::AssetId) -> bool {
-		!Assets::total_issuance(*id).is_zero()
+		!Assets::total_issuance(id.clone()).is_zero()
 	}
 }
 

cumulus/primitives/utility/src/lib.rs

@@ -168,17 +168,18 @@ impl<
 		// Calculate how much we should charge in the asset_id for such amount of weight
 		// Require at least a payment of minimum_balance
 		// Necessary for fully collateral-backed assets
-		let asset_balance: u128 = FeeCharger::charge_weight_in_fungibles(local_asset_id, weight)
-			.map(|amount| {
-				let minimum_balance = ConcreteAssets::minimum_balance(local_asset_id);
-				if amount < minimum_balance {
-					minimum_balance
-				} else {
-					amount
-				}
-			})?
-			.try_into()
-			.map_err(|_| XcmError::Overflow)?;
+		let asset_balance: u128 =
+			FeeCharger::charge_weight_in_fungibles(local_asset_id.clone(), weight)
+				.map(|amount| {
+					let minimum_balance = ConcreteAssets::minimum_balance(local_asset_id);
+					if amount < minimum_balance {
+						minimum_balance
+					} else {
+						amount
+					}
+				})?
+				.try_into()
+				.map_err(|_| XcmError::Overflow)?;
 
 		// Convert to the same kind of multiasset, with the required fungible balance
 		let required = first.id.into_multiasset(asset_balance.into());
@@ -206,7 +207,7 @@ impl<
 			let (local_asset_id, outstanding_balance) =
 				Matcher::matches_fungibles(&(id, fun).into()).ok()?;
 
-			let minimum_balance = ConcreteAssets::minimum_balance(local_asset_id);
+			let minimum_balance = ConcreteAssets::minimum_balance(local_asset_id.clone());
 
 			// Calculate asset_balance
 			// This read should have already be cached in buy_weight