Log error instead of returning it

Log error when `best_parachain_block_at_target` can't be updated instead
of propagating it.

Signed-off-by: Serban Iorga <serban@parity.io>

bridges/relays/lib-substrate-relay/src/parachains/target.rs

@@ -138,21 +138,25 @@ where
 					&best_para_head_hash.head_hash,
 					Some(at_block.1),
 				)
-				.await?
+				.await
-				.and_then(|h| match HeaderOf::<P::SourceParachain>::decode(&mut &h.0[..]) {
+				.and_then(|maybe_encoded_head| match maybe_encoded_head {
-					Ok(header) => Some(header),
+					Some(encoded_head) =>
-					Err(e) => {
+						HeaderOf::<P::SourceParachain>::decode(&mut &encoded_head.0[..])
-						log::error!(
+							.map(|head| Some(head))
-							target: "bridge-metrics",
+							.map_err(Self::Error::ResponseParseFailed),
-							"Failed to decode {} parachain header at {}: {:?}. Metric will have obsolete value",
+					None => Ok(None),
-							P::SourceParachain::NAME,
+				})
-							P::TargetChain::NAME,
+				.map_err(|e| {
-							e,
+					log::error!(
-						);
+						target: "bridge-metrics",
-
+						"Failed to read or decode {} parachain header at {}: {:?}. Metric will have obsolete value",
-						None
+						P::SourceParachain::NAME,
-					},
+						P::TargetChain::NAME,
-				});
+						e,
+					);
+					e
+				})
+				.unwrap_or(None);
 			if let Some(imported_para_head) = imported_para_head {
 				metrics
 					.update_best_parachain_block_at_target(para_id, *imported_para_head.number());