FRAME: inherited call weight syntax (#13932)

* First approach on pallet::call_weight

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Use attr on pallet::call instead

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Ui tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Rename to weight(prefix = ...))

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Simplify to #[pallet::call(weight(T))]

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Add stray token error

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Cleanup

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Migrate remaining pallets

Using script from https://github.com/ggwpez/substrate-scripts/blob/e1b5ea5b5b4018867f3e869fce6f448b4ba9d71f/frame-code-migration/src/call_weight.rs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Try to add some docs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Revert "Migrate remaining pallets"

Lets do this as a follow-up, I dont want to bloat this small MR.

This reverts commit 331d4b42d72de1dacaed714d69166fa1bc9c92dd.

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Renames

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Review fixes

Co-authored-by: Sam Johnson <sam@durosoft.com>

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Test weights

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update UI tests

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update frame/support/procedural/src/pallet/parse/mod.rs

Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>

* Remove old code

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

* Update docs

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: parity-processbot <>
Co-authored-by: Muharem Ismailov <ismailov.m.h@gmail.com>

substrate/frame/support/test/tests/pallet_ui/pass/inherited_call_weight.rs

@@ -0,0 +1,51 @@
+use frame_support::pallet_prelude::*;
+use frame_system::pallet_prelude::*;
+
+pub trait WeightInfo {
+	fn foo() -> Weight;
+}
+
+#[frame_support::pallet]
+mod parentheses {
+	use super::*;
+
+	#[pallet::config]
+	pub trait Config: frame_system::Config {
+		type WeightInfo: crate::WeightInfo;
+	}
+
+	#[pallet::pallet]
+	pub struct Pallet<T>(core::marker::PhantomData<T>);
+
+	#[pallet::call(weight(<T as Config>::WeightInfo))]
+	impl<T: Config> Pallet<T> {
+		#[pallet::call_index(0)]
+		pub fn foo(_: OriginFor<T>) -> DispatchResult {
+			Ok(())
+		}
+	}
+}
+
+#[frame_support::pallet]
+mod assign {
+	use super::*;
+
+	#[pallet::config]
+	pub trait Config: frame_system::Config {
+		type WeightInfo: crate::WeightInfo;
+	}
+
+	#[pallet::pallet]
+	pub struct Pallet<T>(core::marker::PhantomData<T>);
+
+	#[pallet::call(weight = <T as Config>::WeightInfo)]
+	impl<T: Config> Pallet<T> {
+		#[pallet::call_index(0)]
+		pub fn foo(_: OriginFor<T>) -> DispatchResult {
+			Ok(())
+		}
+	}
+}
+
+fn main() {
+}

substrate/frame/support/test/tests/pallet_ui/pass/inherited_call_weight2.rs

@@ -0,0 +1,57 @@
+use frame_support::pallet_prelude::*;
+use frame_system::pallet_prelude::*;
+
+pub trait WeightInfo {
+	fn foo() -> Weight;
+}
+
+impl WeightInfo for () {
+	fn foo() -> Weight {
+		Weight::zero()
+	}
+}
+
+#[frame_support::pallet]
+mod parentheses {
+	use super::*;
+
+	#[pallet::config]
+	pub trait Config: frame_system::Config {
+	}
+
+	#[pallet::pallet]
+	pub struct Pallet<T>(core::marker::PhantomData<T>);
+
+	// Crazy man just uses `()`, but it still works ;)
+	#[pallet::call(weight(()))]
+	impl<T: Config> Pallet<T> {
+		#[pallet::call_index(0)]
+		pub fn foo(_: OriginFor<T>) -> DispatchResult {
+			Ok(())
+		}
+	}
+}
+
+#[frame_support::pallet]
+mod assign {
+	use super::*;
+
+	#[pallet::config]
+	pub trait Config: frame_system::Config {
+	}
+
+	#[pallet::pallet]
+	pub struct Pallet<T>(core::marker::PhantomData<T>);
+
+	// Crazy man just uses `()`, but it still works ;)
+	#[pallet::call(weight = ())]
+	impl<T: Config> Pallet<T> {
+		#[pallet::call_index(0)]
+		pub fn foo(_: OriginFor<T>) -> DispatchResult {
+			Ok(())
+		}
+	}
+}
+
+fn main() {
+}

substrate/frame/support/test/tests/pallet_ui/pass/inherited_call_weight3.rs

@@ -0,0 +1,54 @@
+use frame_support::pallet_prelude::*;
+use frame_system::pallet_prelude::*;
+
+// If, for whatever reason, you dont to not use a `WeightInfo` trait - it will still work.
+struct Impl;
+
+impl Impl {
+	fn foo() -> Weight {
+		Weight::zero()
+	}
+}
+
+#[frame_support::pallet]
+mod parentheses {
+	use super::*;
+
+	#[pallet::config]
+	pub trait Config: frame_system::Config {
+	}
+
+	#[pallet::pallet]
+	pub struct Pallet<T>(core::marker::PhantomData<T>);
+
+	#[pallet::call(weight(crate::Impl))]
+	impl<T: Config> Pallet<T> {
+		#[pallet::call_index(0)]
+		pub fn foo(_: OriginFor<T>) -> DispatchResult {
+			Ok(())
+		}
+	}
+}
+
+#[frame_support::pallet]
+mod assign {
+	use super::*;
+
+	#[pallet::config]
+	pub trait Config: frame_system::Config {
+	}
+
+	#[pallet::pallet]
+	pub struct Pallet<T>(core::marker::PhantomData<T>);
+
+	#[pallet::call(weight = crate::Impl)]
+	impl<T: Config> Pallet<T> {
+		#[pallet::call_index(0)]
+		pub fn foo(_: OriginFor<T>) -> DispatchResult {
+			Ok(())
+		}
+	}
+}
+
+fn main() {
+}

substrate/frame/support/test/tests/pallet_ui/pass/inherited_call_weight_dev_mode.rs

@@ -0,0 +1,30 @@
+use frame_support::pallet_prelude::*;
+use frame_system::pallet_prelude::*;
+
+pub trait WeightInfo {
+	fn foo() -> Weight;
+}
+
+#[frame_support::pallet(dev_mode)]
+mod pallet {
+	use super::*;
+
+	#[pallet::config]
+	pub trait Config: frame_system::Config {
+		type WeightInfo: WeightInfo;
+	}
+
+	#[pallet::pallet]
+	pub struct Pallet<T>(core::marker::PhantomData<T>);
+
+	#[pallet::call(weight(<T as Config>::WeightInfo))]
+	impl<T: Config> Pallet<T> {
+		#[pallet::call_index(0)]
+		pub fn foo(_: OriginFor<T>) -> DispatchResult {
+			Ok(())
+		}
+	}
+}
+
+fn main() {
+}