mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-30 04:57:57 +00:00
Apply some clippy lints (#11154)
* Apply some clippy hints * Revert clippy ci changes * Update client/cli/src/commands/generate.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/cli/src/commands/inspect_key.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/db/src/bench.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/db/src/bench.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/service/src/client/block_rules.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/service/src/client/block_rules.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/network/src/transactions.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/network/src/protocol.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Revert due to missing `or_default` function. * Fix compilation and simplify code * Undo change that corrupts benchmark. * fix clippy * Update client/service/test/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/state-db/src/noncanonical.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/state-db/src/noncanonical.rs remove leftovers! * Update client/tracing/src/logging/directives.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update utils/fork-tree/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * added needed ref * Update frame/referenda/src/benchmarking.rs * Simplify byte-vec creation * let's just not overlap the ranges * Correction * cargo fmt * Update utils/frame/benchmarking-cli/src/shared/stats.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update utils/frame/benchmarking-cli/src/pallet/command.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update utils/frame/benchmarking-cli/src/pallet/command.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Giles Cope <gilescope@gmail.com>
This commit is contained in:
committed by
GitHub
parent
a990473cf9
commit
b581604aa7
@@ -360,9 +360,9 @@ impl<B: BlockT> CacheChanges<B> {
|
||||
// Same block comitted twice with different state changes.
|
||||
// Treat it as reenacted/retracted.
|
||||
if is_best {
|
||||
enacted.push(commit_hash.clone());
|
||||
enacted.push(*commit_hash);
|
||||
} else {
|
||||
retracted.to_mut().push(commit_hash.clone());
|
||||
retracted.to_mut().push(*commit_hash);
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -371,7 +371,7 @@ impl<B: BlockT> CacheChanges<B> {
|
||||
// Propagate cache only if committing on top of the latest canonical state
|
||||
// blocks are ordered by number and only one block with a given number is marked as
|
||||
// canonical (contributed to canonical state cache)
|
||||
if let Some(_) = self.parent_hash {
|
||||
if self.parent_hash.is_some() {
|
||||
let mut local_cache = self.local_cache.write();
|
||||
if is_best {
|
||||
trace!(
|
||||
@@ -423,9 +423,9 @@ impl<B: BlockT> CacheChanges<B> {
|
||||
storage: modifications,
|
||||
child_storage: child_modifications,
|
||||
number: *number,
|
||||
hash: hash.clone(),
|
||||
hash: *hash,
|
||||
is_canon: is_best,
|
||||
parent: parent.clone(),
|
||||
parent: *parent,
|
||||
};
|
||||
let insert_at = cache
|
||||
.modifications
|
||||
@@ -564,7 +564,7 @@ impl<S: StateBackend<HashFor<B>>, B: BlockT> StateBackend<HashFor<B>> for Cachin
|
||||
let cache = self.cache.shared_cache.upgradable_read();
|
||||
if Self::is_allowed(Some(key), None, &self.cache.parent_hash, &cache.modifications) {
|
||||
let mut cache = RwLockUpgradableReadGuard::upgrade(cache);
|
||||
if let Some(entry) = cache.lru_hashes.get(key).map(|a| a.0.clone()) {
|
||||
if let Some(entry) = cache.lru_hashes.get(key).map(|a| a.0) {
|
||||
trace!("Found hash in shared cache: {:?}", HexDisplay::from(&key));
|
||||
return Ok(entry)
|
||||
}
|
||||
@@ -934,7 +934,7 @@ impl<S, B: BlockT> Drop for SyncingCachingState<S, B> {
|
||||
let _lock = self.lock.read();
|
||||
|
||||
self.state_usage.merge_sm(caching_state.usage.take());
|
||||
if let Some(hash) = caching_state.cache.parent_hash.clone() {
|
||||
if let Some(hash) = caching_state.cache.parent_hash {
|
||||
let is_best = self.meta.read().best_hash == hash;
|
||||
caching_state.cache.sync_cache(&[], &[], vec![], vec![], None, None, is_best);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user