Apply some clippy lints (#11154)

* Apply some clippy hints

* Revert clippy ci changes

* Update client/cli/src/commands/generate.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update client/cli/src/commands/inspect_key.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update client/db/src/bench.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update client/db/src/bench.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update client/service/src/client/block_rules.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update client/service/src/client/block_rules.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update client/network/src/transactions.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update client/network/src/protocol.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Revert due to missing `or_default` function.

* Fix compilation and simplify code

* Undo change that corrupts benchmark.

* fix clippy

* Update client/service/test/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update client/state-db/src/noncanonical.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update client/state-db/src/noncanonical.rs

remove leftovers!

* Update client/tracing/src/logging/directives.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update utils/fork-tree/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* added needed ref

* Update frame/referenda/src/benchmarking.rs

* Simplify byte-vec creation

* let's just not overlap the ranges

* Correction

* cargo fmt

* Update utils/frame/benchmarking-cli/src/shared/stats.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update utils/frame/benchmarking-cli/src/pallet/command.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update utils/frame/benchmarking-cli/src/pallet/command.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Giles Cope <gilescope@gmail.com>
This commit is contained in:
Falco Hirschenberger
2022-04-30 23:28:27 +02:00
committed by GitHub
parent a990473cf9
commit b581604aa7
368 changed files with 1927 additions and 2236 deletions
+5 -5
View File
@@ -106,7 +106,7 @@ where
let number = header.number();
if let Some(ref author) = author {
if !acc.insert((number.clone(), author.clone())) {
if !acc.insert((*number, author.clone())) {
return Err("more than one uncle per number per author included")
}
}
@@ -225,7 +225,7 @@ pub mod pallet {
ensure!(new_uncles.len() <= MAX_UNCLES, Error::<T>::TooManyUncles);
if <DidSetUncles<T>>::get() {
Err(Error::<T>::UnclesAlreadySet)?
return Err(Error::<T>::UnclesAlreadySet.into())
}
<DidSetUncles<T>>::put(true);
@@ -334,7 +334,7 @@ impl<T: Config> Pallet<T> {
let hash = uncle.hash();
if let Some(author) = maybe_author.clone() {
T::EventHandler::note_uncle(author, now - uncle.number().clone());
T::EventHandler::note_uncle(author, now - *uncle.number());
}
uncles.push(UncleEntryItem::Uncle(hash, maybe_author));
}
@@ -368,7 +368,7 @@ impl<T: Config> Pallet<T> {
}
{
let parent_number = uncle.number().clone() - One::one();
let parent_number = *uncle.number() - One::one();
let parent_hash = <frame_system::Pallet<T>>::block_hash(&parent_number);
if &parent_hash != uncle.parent_hash() {
return Err(Error::<T>::InvalidUncleParent.into())
@@ -387,7 +387,7 @@ impl<T: Config> Pallet<T> {
}
// check uncle validity.
T::FilterUncle::filter_uncle(&uncle, accumulator).map_err(|e| Into::into(e))
T::FilterUncle::filter_uncle(uncle, accumulator).map_err(Into::into)
}
fn prune_old_uncles(minimum_height: T::BlockNumber) {