mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-06-13 18:41:05 +00:00
Apply some clippy lints (#11154)
* Apply some clippy hints * Revert clippy ci changes * Update client/cli/src/commands/generate.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/cli/src/commands/inspect_key.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/db/src/bench.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/db/src/bench.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/service/src/client/block_rules.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/service/src/client/block_rules.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/network/src/transactions.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/network/src/protocol.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Revert due to missing `or_default` function. * Fix compilation and simplify code * Undo change that corrupts benchmark. * fix clippy * Update client/service/test/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/state-db/src/noncanonical.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update client/state-db/src/noncanonical.rs remove leftovers! * Update client/tracing/src/logging/directives.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update utils/fork-tree/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * added needed ref * Update frame/referenda/src/benchmarking.rs * Simplify byte-vec creation * let's just not overlap the ranges * Correction * cargo fmt * Update utils/frame/benchmarking-cli/src/shared/stats.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update utils/frame/benchmarking-cli/src/pallet/command.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> * Update utils/frame/benchmarking-cli/src/pallet/command.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> Co-authored-by: Giles Cope <gilescope@gmail.com>
This commit is contained in:
committed by
GitHub
parent
a990473cf9
commit
b581604aa7
@@ -456,7 +456,7 @@ pub mod pallet {
|
||||
pub fn kill_storage(origin: OriginFor<T>, keys: Vec<Key>) -> DispatchResultWithPostInfo {
|
||||
ensure_root(origin)?;
|
||||
for key in &keys {
|
||||
storage::unhashed::kill(&key);
|
||||
storage::unhashed::kill(key);
|
||||
}
|
||||
Ok(().into())
|
||||
}
|
||||
@@ -833,7 +833,7 @@ impl<
|
||||
Some(account) => account.clone(),
|
||||
None => zero_account_id,
|
||||
};
|
||||
O::from(RawOrigin::Signed(first_member.clone()))
|
||||
O::from(RawOrigin::Signed(first_member))
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1196,8 +1196,7 @@ impl<T: Config> Pallet<T> {
|
||||
}
|
||||
|
||||
let phase = ExecutionPhase::<T>::get().unwrap_or_default();
|
||||
let event =
|
||||
EventRecord { phase, event, topics: topics.iter().cloned().collect::<Vec<_>>() };
|
||||
let event = EventRecord { phase, event, topics: topics.to_vec() };
|
||||
|
||||
// Index of the to be added event.
|
||||
let event_idx = {
|
||||
@@ -1522,16 +1521,16 @@ impl<T: Config> Pallet<T> {
|
||||
/// of the old and new runtime has the same spec name and that the spec version is increasing.
|
||||
pub fn can_set_code(code: &[u8]) -> Result<(), sp_runtime::DispatchError> {
|
||||
let current_version = T::Version::get();
|
||||
let new_version = sp_io::misc::runtime_version(&code)
|
||||
let new_version = sp_io::misc::runtime_version(code)
|
||||
.and_then(|v| RuntimeVersion::decode(&mut &v[..]).ok())
|
||||
.ok_or_else(|| Error::<T>::FailedToExtractRuntimeVersion)?;
|
||||
.ok_or(Error::<T>::FailedToExtractRuntimeVersion)?;
|
||||
|
||||
if new_version.spec_name != current_version.spec_name {
|
||||
Err(Error::<T>::InvalidSpecName)?
|
||||
return Err(Error::<T>::InvalidSpecName.into())
|
||||
}
|
||||
|
||||
if new_version.spec_version <= current_version.spec_version {
|
||||
Err(Error::<T>::SpecVersionNeedsToIncrease)?
|
||||
return Err(Error::<T>::SpecVersionNeedsToIncrease.into())
|
||||
}
|
||||
|
||||
Ok(())
|
||||
|
||||
Reference in New Issue
Block a user