pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-05-31 05:11:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid hashing headers twice in verify_justification (#973)

Browse Source
This commit is contained in:
Svyatoslav Nikolsky
2021-05-20 02:09:13 +03:00
committed by Bastian Köcher
parent f8f8f42a89
commit b6efe6f740
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bridges/primitives/header-chain/src/justification.rs
+2 -6
View File
@@ -109,12 +109,8 @@ where
} }
} }
let ancestry_hashes = justification // both iterators are `BTree*` iterators, so have the same order => safe to compare
.votes_ancestries if !visited_hashes.iter().eq(ancestry_chain.ancestry.keys()) {
.iter()
.map(|h: &Header| h.hash())
.collect();
if visited_hashes != ancestry_hashes {
return Err(Error::InvalidPrecommitAncestries); return Err(Error::InvalidPrecommitAncestries);
} }